From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, qemu-arm@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: [PATCH v3 15/19] target-arm: Implement cpu_get_phys_page_attrs_debug
Date: Thu, 14 Jan 2016 13:52:51 +0000 [thread overview]
Message-ID: <1452779575-32582-16-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1452779575-32582-1-git-send-email-peter.maydell@linaro.org>
Implement cpu_get_phys_page_attrs_debug instead of cpu_get_phys_page_debug.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
target-arm/cpu-qom.h | 3 ++-
target-arm/cpu.c | 2 +-
target-arm/helper.c | 9 +++++----
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h
index 8cb5bd5..e4d4270 100644
--- a/target-arm/cpu-qom.h
+++ b/target-arm/cpu-qom.h
@@ -219,7 +219,8 @@ bool arm_cpu_exec_interrupt(CPUState *cpu, int int_req);
void arm_cpu_dump_state(CPUState *cs, FILE *f, fprintf_function cpu_fprintf,
int flags);
-hwaddr arm_cpu_get_phys_page_debug(CPUState *cpu, vaddr addr);
+hwaddr arm_cpu_get_phys_page_attrs_debug(CPUState *cpu, vaddr addr,
+ MemTxAttrs *attrs);
int arm_cpu_gdb_read_register(CPUState *cpu, uint8_t *buf, int reg);
int arm_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);
diff --git a/target-arm/cpu.c b/target-arm/cpu.c
index ab0021e..4b21e24 100644
--- a/target-arm/cpu.c
+++ b/target-arm/cpu.c
@@ -1450,7 +1450,7 @@ static void arm_cpu_class_init(ObjectClass *oc, void *data)
#else
cc->do_interrupt = arm_cpu_do_interrupt;
cc->do_unaligned_access = arm_cpu_do_unaligned_access;
- cc->get_phys_page_debug = arm_cpu_get_phys_page_debug;
+ cc->get_phys_page_attrs_debug = arm_cpu_get_phys_page_attrs_debug;
cc->asidx_from_attrs = arm_asidx_from_attrs;
cc->vmsd = &vmstate_arm_cpu;
cc->virtio_is_big_endian = arm_cpu_is_big_endian;
diff --git a/target-arm/helper.c b/target-arm/helper.c
index 59d5a41..26cd74b 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -7341,7 +7341,8 @@ bool arm_tlb_fill(CPUState *cs, vaddr address,
return ret;
}
-hwaddr arm_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
+hwaddr arm_cpu_get_phys_page_attrs_debug(CPUState *cs, vaddr addr,
+ MemTxAttrs *attrs)
{
ARMCPU *cpu = ARM_CPU(cs);
CPUARMState *env = &cpu->env;
@@ -7350,16 +7351,16 @@ hwaddr arm_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
int prot;
bool ret;
uint32_t fsr;
- MemTxAttrs attrs = {};
ARMMMUFaultInfo fi = {};
+ *attrs = (MemTxAttrs) {};
+
ret = get_phys_addr(env, addr, 0, cpu_mmu_index(env, false), &phys_addr,
- &attrs, &prot, &page_size, &fsr, &fi);
+ attrs, &prot, &page_size, &fsr, &fi);
if (ret) {
return -1;
}
-
return phys_addr;
}
--
1.9.1
next prev parent reply other threads:[~2016-01-14 13:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 13:52 [PATCH v3 00/19] Add support for multiple address spaces per CPU and use it for ARM TrustZone Peter Maydell
2016-01-14 13:52 ` [PATCH v3 01/19] exec.c: Don't set cpu->as until cpu_address_space_init Peter Maydell
2016-01-14 13:52 ` [PATCH v3 02/19] exec.c: Allow target CPUs to define multiple AddressSpaces Peter Maydell
2016-01-14 13:52 ` [PATCH v3 03/19] exec-all.h: Document tlb_set_page_with_attrs, tlb_set_page Peter Maydell
2016-01-14 13:52 ` [PATCH v3 04/19] cpu: Add new get_phys_page_attrs_debug() method Peter Maydell
2016-01-14 13:52 ` [PATCH v3 05/19] cpu: Add new asidx_from_attrs() method Peter Maydell
2016-01-14 13:52 ` [PATCH v3 06/19] cputlb.c: Use correct address space when looking up MemoryRegionSection Peter Maydell
2016-01-14 13:52 ` [PATCH v3 07/19] exec.c: Pass MemTxAttrs to iotlb_to_region so it uses the right AS Peter Maydell
2016-01-14 13:52 ` [PATCH v3 08/19] exec.c: Add cpu_get_address_space() Peter Maydell
2016-01-14 13:52 ` [PATCH v3 09/19] exec.c: Use cpu_get_phys_page_attrs_debug Peter Maydell
2016-01-14 13:52 ` [PATCH v3 10/19] exec.c: Use correct AddressSpace in watch_mem_read and watch_mem_write Peter Maydell
2016-01-14 13:52 ` [PATCH v3 11/19] memory: Add address_space_init_shareable() Peter Maydell
2016-01-14 13:52 ` [PATCH v3 12/19] qom/cpu: Add MemoryRegion property Peter Maydell
2016-01-14 23:37 ` [Qemu-arm] " Peter Crosthwaite
2016-01-14 13:52 ` [PATCH v3 13/19] target-arm: Add QOM property for Secure memory region Peter Maydell
2016-01-14 13:52 ` [PATCH v3 14/19] target-arm: Implement asidx_from_attrs Peter Maydell
2016-01-14 13:52 ` Peter Maydell [this message]
2016-01-14 13:52 ` [PATCH v3 16/19] target-arm: Support multiple address spaces in page table walks Peter Maydell
2016-01-14 13:52 ` [PATCH v3 17/19] hw/arm/virt: Wire up memory region to CPUs explicitly Peter Maydell
2016-01-14 13:52 ` [PATCH v3 18/19] hw/arm/virt: add secure memory region and UART Peter Maydell
2016-01-14 13:52 ` [PATCH v3 19/19] HACK: rearrange the virt memory map to suit OP-TEE Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452779575-32582-16-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=alex.bennee@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).