From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
patches@linaro.org
Subject: [Qemu-arm] [PATCH v2 0/6] Runtime pagesize computation
Date: Tue, 21 Jun 2016 18:09:28 +0100 [thread overview]
Message-ID: <1466528974-12183-1-git-send-email-peter.maydell@linaro.org> (raw)
This set of patches is a development based on the ones from Vijaya:
the general idea is similar but I have tried to improve the interface
for defining the page size a bit. I've also tweaked patches 2 and 3
to address code review comments.
The basic idea here is that:
* the target CPU implementation has to opt into variable page size
by defining TARGET_PAGE_BITS_VARY, and then calling
set_preferred_target_page_bits() in its realize function
with whatever the CPU as instantiated actually requires
* the machine also has to opt in, by specifying a new MachineClass
field which states the value they guarantee will be no greater
than the preferred page size for any CPU they create
* we finalize the decision about page size in cpu_exec_init_all()
(and then later attempts to create CPUs which can't cope with
that decision are failed)
I would ideally have liked to finalize things much later, but
this is in practice hugely difficult because so many things
(in particular all the address space/memory system code)
assume the target page size is known.
Note that setting minimum_page-bits for a machine is a migration
compatibility break (the RAM migration format assumes both sides
have the same idea of a page size). Mismatches will probably
result in an unhelpfully obscure migration failure. (Possibly we
could have the migration send the page size if it was different
from TARGET_PAGE_BITS_MIN so we at least got a nice error?)
This could in theory be extended to the user-mode binaries,
but for the moment I have just required them to define a
fixed TARGET_PAGE_BITS.
NB: I have only very lightly tested these and haven't attempted
to measure performance at all. There is an assert() in the
definition of TARGET_PAGE_BITS which is good for making sure
it isn't used before it's valid but not so good for speed.
thanks
-- PMM
Peter Maydell (3):
cpu: Support a target CPU having a variable page size
target-arm: Make page size a runtime setting
hw/arm/virt: Set minimum_page_bits to 12
Vijaya Kumar K (3):
migration: Remove static allocation of xzblre cache buffer
exec.c: Remove static allocation of sub_section of sub_page
translate-all.c: Compute L1 page table properties at runtime
exec.c | 47 ++++++++++++++++++++++++++++++++---
hw/arm/virt.c | 2 ++
include/exec/cpu-all.h | 8 ++++++
include/hw/boards.h | 7 ++++++
include/qemu-common.h | 13 ++++++++++
migration/ram.c | 4 ++-
target-arm/cpu.c | 24 ++++++++++++++++++
target-arm/cpu.h | 9 ++++---
translate-all.c | 67 +++++++++++++++++++++++++++++++++-----------------
vl.c | 10 ++++++++
10 files changed, 160 insertions(+), 31 deletions(-)
--
1.9.1
next reply other threads:[~2016-06-21 17:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 17:09 Peter Maydell [this message]
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 1/6] migration: Remove static allocation of xzblre cache buffer Peter Maydell
2016-06-22 1:44 ` [Qemu-arm] [Qemu-devel] " Richard Henderson
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 2/6] exec.c: Remove static allocation of sub_section of sub_page Peter Maydell
2016-06-22 1:47 ` [Qemu-arm] [Qemu-devel] " Richard Henderson
[not found] ` <BY1PR0701MB169163D3032F7EF4FB8FD000F22C0@BY1PR0701MB1691.namprd07.prod.outlook.com>
2016-06-22 6:55 ` [Qemu-arm] Fw: " Vijay Kilari
2016-06-22 7:07 ` [Qemu-arm] [Qemu-devel] " Richard Henderson
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 3/6] translate-all.c: Compute L1 page table properties at runtime Peter Maydell
2016-06-22 6:56 ` [Qemu-devel] " Richard Henderson
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 4/6] cpu: Support a target CPU having a variable page size Peter Maydell
2016-06-21 18:26 ` [Qemu-arm] [Qemu-devel] " Andrew Jones
2016-06-21 19:46 ` Peter Maydell
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 5/6] target-arm: Make page size a runtime setting Peter Maydell
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 6/6] hw/arm/virt: Set minimum_page_bits to 12 Peter Maydell
2016-06-21 18:45 ` [Qemu-arm] [Qemu-devel] " Andrew Jones
2016-06-21 19:47 ` Peter Maydell
2016-06-22 8:02 ` Andrew Jones
2016-06-22 11:35 ` Dr. David Alan Gilbert
2016-06-22 11:38 ` [Qemu-arm] " Peter Maydell
2016-06-22 11:54 ` Dr. David Alan Gilbert
2016-06-22 12:02 ` [Qemu-arm] " Peter Maydell
2016-06-22 12:17 ` Dr. David Alan Gilbert
2016-06-22 12:18 ` [Qemu-arm] " Andrew Jones
2016-06-22 10:24 ` Paolo Bonzini
2016-06-22 11:43 ` [Qemu-devel] [PATCH v2 0/6] Runtime pagesize computation Dr. David Alan Gilbert
2016-06-28 8:16 ` [Qemu-arm] " Peter Maydell
[not found] ` <BLUPR0701MB1684CF1920D922BD00E93EE6F2230@BLUPR0701MB1684.namprd07.prod.outlook.com>
2016-06-29 7:00 ` [Qemu-arm] Fw: " Vijay Kilari
2016-07-19 11:01 ` Vijay Kilari
2016-07-19 11:04 ` Peter Maydell
2016-10-07 14:20 ` [Qemu-devel] Fw: [Qemu-arm] " Peter Maydell
2016-10-08 4:26 ` [Qemu-arm] Fw: " Vijay Kilari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466528974-12183-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).