qemu-arm.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
	patches@linaro.org
Subject: [Qemu-arm] [PATCH v2 1/6] migration: Remove static allocation of xzblre cache buffer
Date: Tue, 21 Jun 2016 18:09:29 +0100	[thread overview]
Message-ID: <1466528974-12183-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1466528974-12183-1-git-send-email-peter.maydell@linaro.org>

From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>

Allocate xzblre zero page cache buffer dynamically.
Remove dependency on TARGET_PAGE_SIZE to make run-time
page size detection for arm platforms.

Signed-off-by: Vijaya Kumar K <vijayak@cavium.com>
Message-id: 1465808915-4887-2-git-send-email-vijayak@caviumnetworks.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 migration/ram.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/migration/ram.c b/migration/ram.c
index 815bc0e..b665741 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -69,7 +69,7 @@ static uint64_t bitmap_sync_count;
 /* 0x80 is reserved in migration.h start with 0x100 next */
 #define RAM_SAVE_FLAG_COMPRESS_PAGE    0x100
 
-static const uint8_t ZERO_TARGET_PAGE[TARGET_PAGE_SIZE];
+static uint8_t *ZERO_TARGET_PAGE;
 
 static inline bool is_zero_range(uint8_t *p, uint64_t size)
 {
@@ -1429,6 +1429,7 @@ static void ram_migration_cleanup(void *opaque)
         cache_fini(XBZRLE.cache);
         g_free(XBZRLE.encoded_buf);
         g_free(XBZRLE.current_buf);
+        g_free(ZERO_TARGET_PAGE);
         XBZRLE.cache = NULL;
         XBZRLE.encoded_buf = NULL;
         XBZRLE.current_buf = NULL;
@@ -1887,6 +1888,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
 
     if (migrate_use_xbzrle()) {
         XBZRLE_cache_lock();
+        ZERO_TARGET_PAGE = g_malloc0(TARGET_PAGE_SIZE);
         XBZRLE.cache = cache_init(migrate_xbzrle_cache_size() /
                                   TARGET_PAGE_SIZE,
                                   TARGET_PAGE_SIZE);
-- 
1.9.1


  reply	other threads:[~2016-06-21 17:11 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 17:09 [Qemu-arm] [PATCH v2 0/6] Runtime pagesize computation Peter Maydell
2016-06-21 17:09 ` Peter Maydell [this message]
2016-06-22  1:44   ` [Qemu-arm] [Qemu-devel] [PATCH v2 1/6] migration: Remove static allocation of xzblre cache buffer Richard Henderson
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 2/6] exec.c: Remove static allocation of sub_section of sub_page Peter Maydell
2016-06-22  1:47   ` [Qemu-arm] [Qemu-devel] " Richard Henderson
     [not found]   ` <BY1PR0701MB169163D3032F7EF4FB8FD000F22C0@BY1PR0701MB1691.namprd07.prod.outlook.com>
2016-06-22  6:55     ` [Qemu-arm] Fw: " Vijay Kilari
2016-06-22  7:07       ` [Qemu-arm] [Qemu-devel] " Richard Henderson
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 3/6] translate-all.c: Compute L1 page table properties at runtime Peter Maydell
2016-06-22  6:56   ` [Qemu-devel] " Richard Henderson
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 4/6] cpu: Support a target CPU having a variable page size Peter Maydell
2016-06-21 18:26   ` [Qemu-arm] [Qemu-devel] " Andrew Jones
2016-06-21 19:46     ` Peter Maydell
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 5/6] target-arm: Make page size a runtime setting Peter Maydell
2016-06-21 17:09 ` [Qemu-arm] [PATCH v2 6/6] hw/arm/virt: Set minimum_page_bits to 12 Peter Maydell
2016-06-21 18:45   ` [Qemu-arm] [Qemu-devel] " Andrew Jones
2016-06-21 19:47     ` Peter Maydell
2016-06-22  8:02       ` Andrew Jones
2016-06-22 11:35         ` Dr. David Alan Gilbert
2016-06-22 11:38           ` [Qemu-arm] " Peter Maydell
2016-06-22 11:54             ` Dr. David Alan Gilbert
2016-06-22 12:02               ` [Qemu-arm] " Peter Maydell
2016-06-22 12:17                 ` Dr. David Alan Gilbert
2016-06-22 12:18                 ` [Qemu-arm] " Andrew Jones
2016-06-22 10:24       ` Paolo Bonzini
2016-06-22 11:43 ` [Qemu-devel] [PATCH v2 0/6] Runtime pagesize computation Dr. David Alan Gilbert
2016-06-28  8:16 ` [Qemu-arm] " Peter Maydell
     [not found]   ` <BLUPR0701MB1684CF1920D922BD00E93EE6F2230@BLUPR0701MB1684.namprd07.prod.outlook.com>
2016-06-29  7:00     ` [Qemu-arm] Fw: " Vijay Kilari
2016-07-19 11:01       ` Vijay Kilari
2016-07-19 11:04         ` Peter Maydell
2016-10-07 14:20           ` [Qemu-devel] Fw: [Qemu-arm] " Peter Maydell
2016-10-08  4:26             ` [Qemu-arm] Fw: " Vijay Kilari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466528974-12183-2-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=Vijaya.Kumar@caviumnetworks.com \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).