qemu-arm.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, thuth@redhat.com, mst@redhat.com,
	mark.cave-ayland@ilande.co.uk, agraf@suse.de,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org, marcel@redhat.com,
	leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 0/7] hw/pci-bus: Fix PCI bus regression on several archs
Date: Thu, 14 Jul 2016 16:43:39 +0300	[thread overview]
Message-ID: <1468503826-10617-1-git-send-email-marcel@redhat.com> (raw)

Commit b86eacb (hw/pci: delay bus_master_enable_region initialization) delayed
enabling the 'bus-master' region for PCI devices until 'machine-done' event.
The event registration happens in the PCIBus realize function, however
the PCI bus is not 'realized' *at all* for some machines.

It appears to be a hidden issue revealed by the above commit.
Thanks Mark Cave-Ayland and Leon Alrae for reporting it!

For all the series:
Reported-by: Leon Alrae <leon.alrae@imgtec.com>
Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Patch 1: Increase the timeout for the prom-env-test since I encountered random failures.
Patch 2-7: Separate fix for each arch so it will be easier for maintainers to ack.

Thanks,
Marcel

Marcel Apfelbaum (7):
  tests/prom-env-test: increase the test timeout
  hw/alpha: fix PCI bus initialization
  hw/mips: fix PCI bus initialization
  hw/apb: fix PCI bus initialization
  hw/grackle: fix PCI bus initialization
  hw/prep: realize the PCI root bus as part of the prep init
  hw/versatile: realize the PCI root bus as part of the versatile init

 hw/alpha/typhoon.c      |  2 +-
 hw/mips/gt64xxx_pci.c   |  2 +-
 hw/pci-host/apb.c       | 15 +++++++--------
 hw/pci-host/grackle.c   |  2 +-
 hw/pci-host/prep.c      |  1 +
 hw/pci-host/versatile.c |  1 +
 tests/prom-env-test.c   |  2 +-
 7 files changed, 13 insertions(+), 12 deletions(-)

-- 
2.4.3


             reply	other threads:[~2016-07-14 14:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 13:43 Marcel Apfelbaum [this message]
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout Marcel Apfelbaum
2016-07-14 13:51   ` Thomas Huth
2016-07-14 15:19     ` Marcel Apfelbaum
2016-07-18 19:34     ` Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 2/7] hw/alpha: fix PCI bus initialization Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 3/7] hw/mips: " Marcel Apfelbaum
2016-07-15 12:31   ` Leon Alrae
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 4/7] hw/apb: " Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 5/7] hw/grackle: " Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 6/7] hw/prep: realize the PCI root bus as part of the prep init Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 7/7] hw/versatile: realize the PCI root bus as part of the versatile init Marcel Apfelbaum
2016-07-15 15:05 ` [Qemu-devel] [PATCH 0/7] hw/pci-bus: Fix PCI bus regression on several archs Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468503826-10617-1-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=leon.alrae@imgtec.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).