qemu-arm.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, thuth@redhat.com, mst@redhat.com,
	mark.cave-ayland@ilande.co.uk, agraf@suse.de,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org, marcel@redhat.com,
	leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net
Subject: [Qemu-arm] [Qemu-devel] [PATCH 4/7] hw/apb: fix PCI bus initialization
Date: Thu, 14 Jul 2016 16:43:43 +0300	[thread overview]
Message-ID: <1468503826-10617-5-git-send-email-marcel@redhat.com> (raw)
In-Reply-To: <1468503826-10617-1-git-send-email-marcel@redhat.com>

Create and connect the PCI root bus to the
host bridge before the later is 'realized'.

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
 hw/pci-host/apb.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c
index babbbef..16587f8 100644
--- a/hw/pci-host/apb.c
+++ b/hw/pci-host/apb.c
@@ -670,6 +670,13 @@ PCIBus *pci_apb_init(hwaddr special_base,
 
     /* Ultrasparc PBM main bus */
     dev = qdev_create(NULL, TYPE_APB);
+    d = APB_DEVICE(dev);
+    phb = PCI_HOST_BRIDGE(dev);
+    phb->bus = pci_register_bus(DEVICE(phb), "pci",
+                                pci_apb_set_irq, pci_pbm_map_irq, d,
+                                &d->pci_mmio,
+                                get_system_io(),
+                                0, 32, TYPE_PCI_BUS);
     qdev_init_nofail(dev);
     s = SYS_BUS_DEVICE(dev);
     /* apb_config */
@@ -678,18 +685,10 @@ PCIBus *pci_apb_init(hwaddr special_base,
     sysbus_mmio_map(s, 1, special_base + 0x1000000ULL);
     /* pci_ioport */
     sysbus_mmio_map(s, 2, special_base + 0x2000000ULL);
-    d = APB_DEVICE(dev);
 
     memory_region_init(&d->pci_mmio, OBJECT(s), "pci-mmio", 0x100000000ULL);
     memory_region_add_subregion(get_system_memory(), mem_base, &d->pci_mmio);
 
-    phb = PCI_HOST_BRIDGE(dev);
-    phb->bus = pci_register_bus(DEVICE(phb), "pci",
-                                pci_apb_set_irq, pci_pbm_map_irq, d,
-                                &d->pci_mmio,
-                                get_system_io(),
-                                0, 32, TYPE_PCI_BUS);
-
     *pbm_irqs = d->pbm_irqs;
     d->ivec_irqs = ivec_irqs;
 
-- 
2.4.3


  parent reply	other threads:[~2016-07-14 14:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 13:43 [Qemu-devel] [PATCH 0/7] hw/pci-bus: Fix PCI bus regression on several archs Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout Marcel Apfelbaum
2016-07-14 13:51   ` Thomas Huth
2016-07-14 15:19     ` Marcel Apfelbaum
2016-07-18 19:34     ` Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 2/7] hw/alpha: fix PCI bus initialization Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 3/7] hw/mips: " Marcel Apfelbaum
2016-07-15 12:31   ` Leon Alrae
2016-07-14 13:43 ` Marcel Apfelbaum [this message]
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 5/7] hw/grackle: " Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 6/7] hw/prep: realize the PCI root bus as part of the prep init Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 7/7] hw/versatile: realize the PCI root bus as part of the versatile init Marcel Apfelbaum
2016-07-15 15:05 ` [Qemu-devel] [PATCH 0/7] hw/pci-bus: Fix PCI bus regression on several archs Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468503826-10617-5-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=leon.alrae@imgtec.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).