From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
peter.maydell@linaro.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, p.fedin@samsung.com
Cc: drjones@redhat.com, tn@semihalf.com, shlomopongratz@gmail.com,
shannon.zhao@linaro.org, diana.craciun@freescale.com,
christoffer.dall@linaro.org
Subject: [Qemu-arm] [RFC v5 7/7] hw/arm/virt-acpi-build: Add ITS description in ACPI MADT table
Date: Tue, 2 Aug 2016 20:07:27 +0200 [thread overview]
Message-ID: <1470161247-10251-8-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1470161247-10251-1-git-send-email-eric.auger@redhat.com>
This patch exposes the GICv3 ITS to the ACPI guest. The ITS structure
is added to the MADT table.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
v5: new
Tested with Tomasz' kernel series on guest side:
- [PATCH V7 0/8] Introduce ACPI world to ITS,
https://lkml.org/lkml/2016/6/20/321
- for running PCIe on the guest (virtio-pci-net or vhost-net)
the following series is also needed, although not directly ITS:
Support for ARM64 ACPI based PCI host controller,
https://lwn.net/Articles/690995/
---
hw/arm/virt-acpi-build.c | 7 +++++++
include/hw/acpi/acpi-defs.h | 13 ++++++++++++-
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 28fc59c..6cfedff 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -546,6 +546,7 @@ build_madt(GArray *table_data, BIOSLinker *linker, VirtGuestInfo *guest_info)
}
if (guest_info->gic_version == 3) {
+ AcpiMadtGicIts *gic_its;
AcpiMadtGenericRedistributor *gicr = acpi_data_push(table_data,
sizeof *gicr);
@@ -553,6 +554,12 @@ build_madt(GArray *table_data, BIOSLinker *linker, VirtGuestInfo *guest_info)
gicr->length = sizeof(*gicr);
gicr->base_address = cpu_to_le64(memmap[VIRT_GIC_REDIST].base);
gicr->range_length = cpu_to_le32(memmap[VIRT_GIC_REDIST].size);
+
+ gic_its = acpi_data_push(table_data, sizeof *gic_its);
+ gic_its->type = ACPI_APIC_ITS_STRUCTURE;
+ gic_its->length = sizeof(*gic_its);
+ gic_its->gic_its_id = 0;
+ gic_its->base_address = cpu_to_le64(memmap[VIRT_GIC_ITS].base);
} else {
gic_msi = acpi_data_push(table_data, sizeof *gic_msi);
gic_msi->type = ACPI_APIC_GENERIC_MSI_FRAME;
diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h
index 41c1d95..ba3be1e 100644
--- a/include/hw/acpi/acpi-defs.h
+++ b/include/hw/acpi/acpi-defs.h
@@ -294,7 +294,8 @@ typedef struct AcpiMultipleApicTable AcpiMultipleApicTable;
#define ACPI_APIC_GENERIC_DISTRIBUTOR 12
#define ACPI_APIC_GENERIC_MSI_FRAME 13
#define ACPI_APIC_GENERIC_REDISTRIBUTOR 14
-#define ACPI_APIC_RESERVED 15 /* 15 and greater are reserved */
+#define ACPI_APIC_ITS_STRUCTURE 15
+#define ACPI_APIC_RESERVED 16 /* 16 and greater are reserved */
/*
* MADT sub-structures (Follow MULTIPLE_APIC_DESCRIPTION_TABLE)
@@ -386,6 +387,16 @@ struct AcpiMadtGenericMsiFrame {
typedef struct AcpiMadtGenericMsiFrame AcpiMadtGenericMsiFrame;
+struct AcpiMadtGicIts {
+ ACPI_SUB_HEADER_DEF
+ uint16_t reserved;
+ uint32_t gic_its_id;
+ uint64_t base_address;
+ uint32_t reserved2;
+} QEMU_PACKED;
+
+typedef struct AcpiMadtGicIts AcpiMadtGicIts;
+
struct AcpiMadtGenericRedistributor {
ACPI_SUB_HEADER_DEF
uint16_t reserved;
--
2.5.5
next prev parent reply other threads:[~2016-08-02 18:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 18:07 [Qemu-arm] [RFC v5 0/7] vITS support Eric Auger
2016-08-02 18:07 ` [Qemu-arm] [RFC v5 1/7] hw/intc/arm_gicv3_its: Implement ITS base class Eric Auger
2016-08-12 14:12 ` Peter Maydell
2016-08-17 16:03 ` Auger Eric
2016-08-02 18:07 ` [Qemu-arm] [RFC v5 2/7] target-arm: move gicv3_class_name from machine to kvm_arm.h Eric Auger
2016-08-12 14:01 ` Peter Maydell
2016-08-02 18:07 ` [Qemu-arm] [RFC v5 3/7] linux-headers: update to 4.7-rc6 + ITS emulation and GSI routing Eric Auger
2016-08-02 18:07 ` [Qemu-arm] [RFC v5 4/7] target-arm/kvm: Pass requester ID to MSI routing functions Eric Auger
2016-08-12 14:19 ` Peter Maydell
2016-08-17 16:05 ` [Qemu-devel] " Auger Eric
2016-08-02 18:07 ` [Qemu-devel] [RFC v5 5/7] hw/intc/arm_gicv3_its: Implement support for in-kernel ITS emulation Eric Auger
2016-08-12 14:03 ` [Qemu-arm] " Peter Maydell
2016-08-17 15:59 ` Auger Eric
2016-08-02 18:07 ` [Qemu-arm] [RFC v5 6/7] arm/virt: Add ITS to the virt board Eric Auger
2016-08-02 18:07 ` Eric Auger [this message]
2016-08-03 0:56 ` [Qemu-arm] [Qemu-devel] [RFC v5 7/7] hw/arm/virt-acpi-build: Add ITS description in ACPI MADT table Shannon Zhao
2016-08-03 7:22 ` Auger Eric
2016-08-03 8:50 ` Shannon Zhao
2016-08-03 9:02 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470161247-10251-8-git-send-email-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=diana.craciun@freescale.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=shlomopongratz@gmail.com \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).