qemu-arm.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Bolognani <abologna@redhat.com>
To: Wei Huang <wei@redhat.com>, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, drjones@redhat.com,
	shannon.zhao@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-arm] [PATCH V1 1/1] arm64: Add an option to turn on/off host-backed vPMU support
Date: Mon, 15 Aug 2016 11:31:04 +0200	[thread overview]
Message-ID: <1471253464.3003.5.camel@redhat.com> (raw)
In-Reply-To: <1471067570-7503-1-git-send-email-wei@redhat.com>


On Sat, 2016-08-13 at 00:52 -0500, Wei Huang wrote:
> This patch adds a pmu=[on/off] option to enable/disable host vPMU
> support in guest VM. There are several reasons to justify this option.
> First, host-backed vPMU can be problematic for cross-migration between
> different SoC as perf counters are architecture-dependent. It is more
> flexible to have an option to turn it on/off. Secondly this option
> matches the "pmu" option as supported in libvirt tool.
> 
> Note that, like "has_el3", the "pmu" option is only made available on
> CPUs that support host-backed vPMU. They include:
>     * cortex-a53 + kvm
>     * cortex-a57 + kvm
>     * host + kvm
> This option is removed in other configs where it doesn't make sense
> (e.g. cortex-a57 + TCG); and the default pmu support is off. This patch
> has been tested under both DT/ACPI modes.
> 
> Signed-off-by: Wei Huang <wei@redhat.com>
> ---
>  hw/arm/virt-acpi-build.c |  2 +-
>  hw/arm/virt.c            |  2 +-
>  target-arm/cpu.c         | 13 +++++++++++++
>  target-arm/cpu.h         |  3 ++-
>  target-arm/cpu64.c       |  6 ++++++
>  target-arm/kvm64.c       | 10 +++++-----
>  6 files changed, 28 insertions(+), 8 deletions(-)

Did you already try driving this with libvirt? It should work
out of the box.

If you haven't, I will do it :)

-- 
Andrea Bolognani / Red Hat / Virtualization

  reply	other threads:[~2016-08-15  9:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-13  5:52 [Qemu-arm] [PATCH V1 1/1] arm64: Add an option to turn on/off host-backed vPMU support Wei Huang
2016-08-15  9:31 ` Andrea Bolognani [this message]
2016-08-15 16:12   ` Wei Huang
2016-08-15 17:24     ` Andrea Bolognani
2016-08-15 10:09 ` [Qemu-arm] [Qemu-devel] " Andrew Jones
2016-08-15 16:59   ` Andrea Bolognani
2016-08-15 21:05   ` Wei Huang
2016-08-15 16:13 ` [Qemu-arm] " Peter Maydell
2016-08-15 21:15   ` [Qemu-devel] " Wei Huang
2016-08-19 17:05   ` [Qemu-arm] " Wei Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471253464.3003.5.camel@redhat.com \
    --to=abologna@redhat.com \
    --cc=drjones@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhao@linaro.org \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).