From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: Auger Eric <eric.auger@redhat.com>,
Shannon Zhao <zhaoshenglong@huawei.com>,
qemu-arm@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-arm] [PATCH v2 03/10] acpi: reuse AcpiGenericAddress instead of Acpi20GenericAddress
Date: Wed, 28 Feb 2018 15:23:48 +0100 [thread overview]
Message-ID: <1519827835-239519-4-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1519827835-239519-1-git-send-email-imammedo@redhat.com>
Drop duplicate in form of Acpi20GenericAddress and reuse
AcpiGenericAddress.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
---
include/hw/acpi/acpi-defs.h | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h
index 80c8099..9942bc5 100644
--- a/include/hw/acpi/acpi-defs.h
+++ b/include/hw/acpi/acpi-defs.h
@@ -40,18 +40,6 @@ enum {
ACPI_FADT_F_LOW_POWER_S0_IDLE_CAPABLE,
};
-/*
- * ACPI 2.0 Generic Address Space definition.
- */
-struct Acpi20GenericAddress {
- uint8_t address_space_id;
- uint8_t register_bit_width;
- uint8_t register_bit_offset;
- uint8_t reserved;
- uint64_t address;
-} QEMU_PACKED;
-typedef struct Acpi20GenericAddress Acpi20GenericAddress;
-
struct AcpiRsdpDescriptor { /* Root System Descriptor Pointer */
uint64_t signature; /* ACPI signature, contains "RSD PTR " */
uint8_t checksum; /* To make sum of struct == 0 */
@@ -167,7 +155,8 @@ struct AcpiGenericAddress {
uint8_t space_id; /* Address space where struct or register exists */
uint8_t bit_width; /* Size in bits of given register */
uint8_t bit_offset; /* Bit offset within the register */
- uint8_t access_width; /* Minimum Access size (ACPI 3.0) */
+ uint8_t access_width; /* ACPI 3.0: Minimum Access size (ACPI 3.0),
+ ACPI 2.0: Reserved, Table 5-1 */
uint64_t address; /* 64-bit address of struct or register */
} QEMU_PACKED;
@@ -456,7 +445,7 @@ typedef struct AcpiGenericTimerTable AcpiGenericTimerTable;
struct Acpi20Hpet {
ACPI_TABLE_HEADER_DEF /* ACPI common table header */
uint32_t timer_block_id;
- Acpi20GenericAddress addr;
+ struct AcpiGenericAddress addr;
uint8_t hpet_number;
uint16_t min_tick;
uint8_t page_protect;
--
2.7.4
next prev parent reply other threads:[~2018-02-28 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 14:23 [Qemu-arm] [PATCH v2 00/10] generalize build_fadt() Igor Mammedov
2018-02-28 14:23 ` [Qemu-arm] [PATCH v2 01/10] acpi: remove unused acpi-dsdt.aml Igor Mammedov
2018-02-28 14:23 ` [Qemu-arm] [PATCH v2 02/10] pc: replace pm object initialization with one-liner in acpi_get_pm_info() Igor Mammedov
2018-02-28 14:23 ` Igor Mammedov [this message]
2018-02-28 14:23 ` [Qemu-arm] [PATCH v2 04/10] acpi: add build_append_gas() helper for Generic Address Structure Igor Mammedov
2018-02-28 14:23 ` [Qemu-arm] [PATCH v2 05/10] acpi: move ACPI_PORT_SMI_CMD define to header it belongs to Igor Mammedov
2018-03-01 8:41 ` Auger Eric
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 06/10] pc: acpi: isolate FADT specific data into AcpiFadtData structure Igor Mammedov
2018-03-01 8:43 ` [Qemu-arm] " Auger Eric
2018-03-01 9:39 ` Igor Mammedov
2018-02-28 14:23 ` [Qemu-arm] [PATCH v2 07/10] pc: acpi: use build_append_foo() API to construct FADT Igor Mammedov
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 08/10] acpi: move build_fadt() from i386 specific to generic ACPI source Igor Mammedov
2018-02-28 14:23 ` [Qemu-arm] [PATCH v2 09/10] virt_arm: acpi: reuse common build_fadt() Igor Mammedov
2018-03-01 8:51 ` Auger Eric
2018-03-01 9:21 ` Igor Mammedov
2018-03-01 9:38 ` Auger Eric
2018-03-01 16:43 ` Igor Mammedov
2018-02-28 14:23 ` [Qemu-arm] [PATCH v2 10/10] tests: acpi: don't read all fields in test_acpi_fadt_table() Igor Mammedov
2018-03-01 8:59 ` Auger Eric
2018-03-01 8:52 ` [Qemu-devel] [PATCH v2 00/10] generalize build_fadt() Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519827835-239519-4-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=eric.auger@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).