Re: [Qemu-arm] [Qemu-devel] [PATCH v3 0/2] ACPI: Add FADT revision support

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: cover.1470905888.git.lv.zheng@intel.com
Subject: [Qemu-devel] [PATCH v3 0/2] ACPI: Add FADT revision support
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/cover.1470905888.git.lv.zheng@intel.com -> patchew/cover.1470905888.git.lv.zheng@intel.com
Switched to a new branch 'test'
13b8a80 ACPI: Add -acpitable fadt= to allow FADT revision changes
d395c84 ACPI: Cleanup -acpitable option code

=== OUTPUT BEGIN ===
Checking PATCH 1/2: ACPI: Cleanup -acpitable option code...
Checking PATCH 2/2: ACPI: Add -acpitable fadt= to allow FADT revision changes...
ERROR: space prohibited between function name and open parenthesis '('
#156: FILE: hw/i386/acpi-build.c:359:
+        fadt_len = sizeof (AcpiFadtDescriptorRev1);

ERROR: space prohibited between function name and open parenthesis '('
#158: FILE: hw/i386/acpi-build.c:361:
+        fadt_len = sizeof (AcpiFadtDescriptorRev5_1);

total: 2 errors, 0 warnings, 197 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org