From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.159.131 with SMTP id i125csp943923lfe; Thu, 1 Dec 2016 09:06:43 -0800 (PST) X-Received: by 10.55.5.145 with SMTP id 139mr34404037qkf.77.1480612003725; Thu, 01 Dec 2016 09:06:43 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id c6si628435qtb.27.2016.12.01.09.06.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 01 Dec 2016 09:06:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:57581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCUok-00082C-FW for alex.bennee@linaro.org; Thu, 01 Dec 2016 12:06:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCUog-00081s-QT for qemu-arm@nongnu.org; Thu, 01 Dec 2016 12:06:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCUod-0006mC-IK for qemu-arm@nongnu.org; Thu, 01 Dec 2016 12:06:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59310) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cCUod-0006lc-AS; Thu, 01 Dec 2016 12:06:35 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 641163F21E; Thu, 1 Dec 2016 17:06:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-138.phx2.redhat.com [10.3.116.138]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB1H6SMu022984; Thu, 1 Dec 2016 12:06:29 -0500 From: Laszlo Ersek To: qemu devel list Date: Thu, 1 Dec 2016 18:06:17 +0100 Message-Id: <20161201170624.26496-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 01 Dec 2016 17:06:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-arm] [PATCH v4 0/7] q35: add negotiable broadcast SMI X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , "Michael S. Tsirkin" , "Gabriel L. Somlo" , Shannon Zhao , Michael Walle , qemu-arm@nongnu.org, Gerd Hoffmann , Paolo Bonzini , Igor Mammedov Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: yrwJz5K+mB/0 * This is version 4 of the series; the last version was at . This version is practically a rewrite from scratch, seeking to address the v3 feedback. Here's what the individual patches do: - Patch #1 rebases and extends Michael's "writeable fw_cfg blobs" patch from Feb/March 2016. The changes relative to the original patch are documented in the commit message (the code changes are minimal). - Patches #2 and #3 turn the FW_CFG_FILE_SLOTS constant into a device property, and expose the desired number of fw_cfg file slots to board code. This is meant to address a concern raised by Paolo in the v2 review , namely that we're about to run out of FW_CFG_FILE_SLOTS. - Patch #4 introduces the "pc-q35-2.9" and "pc-i440fx-2.9" machine types, which are allowed to take advantage of the new default for fw_cfg file slots (0x20 rather than 0x10). - Patch #5 introduces SMI feature negotiation via fw_cfg, with the following new files: - etc/smi/host-features - etc/smi/guest-features - etc/smi/features-ok This is supposed to follow Michael's recommendation re: imitating virtio . The guest-features file is freely writeable by the guest (no write callbacks in fw_cfg), and the feature validation & lockdown occurs when the guest selects the features-ok file (for reading). Board code is allowed to choose the host feature bitmap to advertise. This patch doesn't add any specific SMI features yet. - Patch #6 adds the ICH9_LPC_SMI_F_BROADCAST feature. - Patch #7 introduces the PCMachineClass.get_smi_host_features method, and implements it for "pc-q35-2.9" and later. The idea is to tie the SMI host features to machine types, and let the machine types calculate their host features with code (i.e., not just a constant). In this patch, the "pc-q35-2.9" machine type exposes the ICH9_LPC_SMI_F_BROADCAST feature iff (smp_cpus == max_cpus), that is, when VCPU hotplug is not possible. (Also from Paolo's v3 feedback, in .) * I've written the OVMF side patches too and tested them together (including gdb / debug messages for "white box" testing). * Note that this version depends on the following PULL req from Michael: [Qemu-devel] [PULL 0/5] virtio, vhost, pc: fixes http://lists.nongnu.org/archive/html/qemu-devel/2016-11/msg05503.html In particular on the following patch: "loader: fix handling of custom address spaces when adding ROM blobs" Cc: "Gabriel L. Somlo" Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Michael Walle Cc: Paolo Bonzini Cc: Peter Maydell Cc: Shannon Zhao Cc: qemu-arm@nongnu.org Thanks Laszlo Laszlo Ersek (6): fw-cfg: turn FW_CFG_FILE_SLOTS into a device property fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma() hw/i386/pc: introduce 2.9 machine types with 0x20 fw_cfg file slots hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg hw/isa/lpc_ich9: add broadcast SMI feature hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off Michael S. Tsirkin (1): fw-cfg: support writeable blobs docs/specs/fw_cfg.txt | 36 +++++++++--- hw/lm32/lm32_hwsetup.h | 2 +- include/hw/compat.h | 11 ++++ include/hw/i386/ich9.h | 15 ++++- include/hw/i386/pc.h | 4 ++ include/hw/loader.h | 7 ++- include/hw/nvram/fw_cfg.h | 5 +- include/hw/nvram/fw_cfg_keys.h | 7 ++- hw/arm/virt-acpi-build.c | 2 +- hw/core/loader.c | 18 +++--- hw/i386/acpi-build.c | 4 +- hw/i386/pc.c | 3 +- hw/i386/pc_piix.c | 16 +++++- hw/i386/pc_q35.c | 37 ++++++++++++- hw/isa/lpc_ich9.c | 92 +++++++++++++++++++++++++++++- hw/nvram/fw_cfg.c | 123 +++++++++++++++++++++++++++++++++++------ 16 files changed, 326 insertions(+), 56 deletions(-) -- 2.9.2