From: Eduardo Habkost <ehabkost@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Marek Vasut <marex@denx.de>, Chris Wulff <crwulff@gmail.com>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v3 01/25] nios2: 10m50_devboard: replace cpu_model with cpu_type
Date: Tue, 6 Feb 2018 20:09:53 -0200 [thread overview]
Message-ID: <20180206220953.GA13301@localhost.localdomain> (raw)
In-Reply-To: <1516694904-64879-2-git-send-email-imammedo@redhat.com>
On Tue, Jan 23, 2018 at 09:08:00AM +0100, Igor Mammedov wrote:
> use cpu_create() instead of being removed cpu_generic_init()
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> CC: Chris Wulff <crwulff@gmail.com>
> CC: Marek Vasut <marex@denx.de>
> ---
> hw/nios2/10m50_devboard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/nios2/10m50_devboard.c b/hw/nios2/10m50_devboard.c
> index e4007f6..42053b2 100644
> --- a/hw/nios2/10m50_devboard.c
> +++ b/hw/nios2/10m50_devboard.c
> @@ -75,7 +75,7 @@ static void nios2_10m50_ghrd_init(MachineState *machine)
> phys_ram_alias);
>
> /* Create CPU -- FIXME */
> - cpu = NIOS2_CPU(cpu_generic_init(TYPE_NIOS2_CPU, "nios2"));
> + cpu = NIOS2_CPU(cpu_create(TYPE_NIOS2_CPU));
Matches what nios2_cpu_class_by_name() does.
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2018-02-06 22:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 8:07 [Qemu-arm] [PATCH v3 00/25] generalize parsing of cpu_model (part 4) Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 01/25] nios2: 10m50_devboard: replace cpu_model with cpu_type Igor Mammedov
2018-02-06 22:09 ` Eduardo Habkost [this message]
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 02/25] tests: add machine 'none' with -cpu test Igor Mammedov
2018-02-06 22:13 ` [Qemu-arm] [Qemu-devel] " Eduardo Habkost
2018-02-06 22:21 ` Eduardo Habkost
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 03/25] arm: cpu: add CPU_RESOLVING_TYPE macro Igor Mammedov
2018-01-23 9:45 ` [Qemu-arm] [Qemu-devel] " Andrew Jones
2018-01-23 9:51 ` [Qemu-arm] [PATCH v4 " Igor Mammedov
2018-02-06 22:18 ` [Qemu-arm] [Qemu-devel] [PATCH v3 " Eduardo Habkost
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 04/25] x86: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-devel] [PATCH v3 05/25] alpha: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 06/25] cris: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-devel] [PATCH v3 07/25] lm32: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 08/25] m68k: " Igor Mammedov
2018-01-24 12:58 ` [Qemu-arm] [Qemu-devel] " Laurent Vivier
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 09/25] microblaze: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 10/25] mips: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-devel] [PATCH v3 11/25] moxie: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 12/25] nios2: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 13/25] openrisc: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 14/25] ppc: " Igor Mammedov
2018-01-23 11:14 ` David Gibson
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 15/25] s390x: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-devel] [PATCH v3 16/25] sh4: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 17/25] sparc: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 18/25] tricore: " Igor Mammedov
2018-01-23 14:05 ` [Qemu-arm] [Qemu-devel] " Bastian Koppelmann
2018-01-23 8:08 ` [Qemu-devel] [PATCH v3 19/25] unicore32: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-devel] [PATCH v3 20/25] xtensa: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-devel] [PATCH v3 21/25] hppa: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-devel] [PATCH v3 22/25] tilegx: " Igor Mammedov
2018-01-23 8:08 ` [Qemu-arm] [PATCH v3 23/25] Use cpu_create(type) instead of cpu_init(cpu_model) Igor Mammedov
2018-01-23 8:08 ` [Qemu-devel] [PATCH v3 24/25] cpu: get rid of unused cpu_init() defines Igor Mammedov
2018-01-23 11:15 ` [Qemu-arm] " David Gibson
2018-02-06 22:26 ` [Qemu-arm] [Qemu-devel] " Eduardo Habkost
2018-01-23 8:08 ` [PATCH v3 25/25] cpu: get rid of cpu_generic_init() Igor Mammedov
2018-02-05 17:09 ` [Qemu-devel] " Igor Mammedov
2018-02-06 22:32 ` [Qemu-arm] [Qemu-devel] [PATCH v3 00/25] generalize parsing of cpu_model (part 4) Eduardo Habkost
2018-02-07 8:52 ` Igor Mammedov
2018-02-07 12:00 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206220953.GA13301@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=crwulff@gmail.com \
--cc=imammedo@redhat.com \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).