From: "Alex Bennée" <alex.bennee@linaro.org>
To: cota@braap.org, famz@redhat.com, berrange@redhat.com,
f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com,
aurelien@aurel32.net, agraf@suse.de
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Yongbok Kim" <yongbok.kim@mips.com>,
qemu-arm@nongnu.org (open list:ARM)
Subject: [PATCH v4 49/49] tests/tcg: override runners for broken tests (!UPSTREAM)
Date: Thu, 17 May 2018 18:47:18 +0100 [thread overview]
Message-ID: <20180517174718.10107-50-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180517174718.10107-1-alex.bennee@linaro.org>
To get a clean run of check-tcg these tests are currently skipped:
- test-mmap -p for i386, hppa, m68k
- hello-mips for mips
- linux-test for sparc
For ARM/aarch64
- fcvt doesn't compare against reference (awaiting fixes in mainline)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
v4
- document broken tests in commit
- temporarily demote fcvt while fixes percolate upstream
---
tests/tcg/aarch64/Makefile.target | 10 +++++-----
tests/tcg/arm/Makefile.target | 10 +++++-----
tests/tcg/hppa/Makefile.target | 7 +++++++
tests/tcg/i386/Makefile.target | 8 ++++++++
tests/tcg/m68k/Makefile.target | 9 +++++++++
tests/tcg/mips/Makefile.target | 4 ++++
tests/tcg/sparc64/Makefile.target | 8 ++++++++
7 files changed, 46 insertions(+), 10 deletions(-)
create mode 100644 tests/tcg/hppa/Makefile.target
create mode 100644 tests/tcg/m68k/Makefile.target
create mode 100644 tests/tcg/sparc64/Makefile.target
diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
index 7dba32138d..d2a6205d7a 100644
--- a/tests/tcg/aarch64/Makefile.target
+++ b/tests/tcg/aarch64/Makefile.target
@@ -12,8 +12,8 @@ TESTS:=$(AARCH64_TESTS)
fcvt: LDFLAGS+=-lm
-run-fcvt: fcvt
- $(call quiet-command, \
- $(QEMU) $< > fcvt.out && \
- diff -u $(AARCH64_SRC)/fcvt.ref fcvt.out, \
- "TEST", "$< (default) on $(TARGET_NAME)")
+# run-fcvt: fcvt
+# $(call quiet-command, \
+# $(QEMU) $< > fcvt.out && \
+# diff -u $(AARCH64_SRC)/fcvt.ref fcvt.out, \
+# "TEST", "$< (default) on $(TARGET_NAME)")
diff --git a/tests/tcg/arm/Makefile.target b/tests/tcg/arm/Makefile.target
index 7bb777f442..f42cf80f84 100644
--- a/tests/tcg/arm/Makefile.target
+++ b/tests/tcg/arm/Makefile.target
@@ -31,9 +31,9 @@ ifeq ($(TARGET_NAME), arm)
fcvt: LDFLAGS+=-lm
# fcvt: CFLAGS+=-march=armv8.2-a+fp16 -mfpu=neon-fp-armv8
-run-fcvt: fcvt
- $(call quiet-command, \
- $(QEMU) $< > fcvt.out && \
- diff -u $(ARM_SRC)/fcvt.ref fcvt.out, \
- "TEST", "$< (default) on $(TARGET_NAME)")
+# run-fcvt: fcvt
+# $(call quiet-command, \
+# $(QEMU) $< > fcvt.out && \
+# diff -u $(ARM_SRC)/fcvt.ref fcvt.out, \
+# "TEST", "$< (default) on $(TARGET_NAME)")
endif
diff --git a/tests/tcg/hppa/Makefile.target b/tests/tcg/hppa/Makefile.target
new file mode 100644
index 0000000000..15fc0b429f
--- /dev/null
+++ b/tests/tcg/hppa/Makefile.target
@@ -0,0 +1,7 @@
+# -*- Mode: makefile -*-
+#
+# HPPA specific tweaks - specifically masking out broken tests
+
+# Currently broken for -p
+run-test-mmap: test-mmap
+ $(call quiet-command, $(QEMU) $< > test-mmap.out, "TEST", "$< (default) on $(TARGET_NAME)")
diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target
index 6d7d4a164e..b5a7011b79 100644
--- a/tests/tcg/i386/Makefile.target
+++ b/tests/tcg/i386/Makefile.target
@@ -48,3 +48,11 @@ run-test-i386-fprem: test-i386-fprem
$(call quiet-command, /bin/true, "SLOW TEST", "$< SKIPPED on $(TARGET_NAME)")
endif
+# Currently broken tests on i386
+ifeq ($(TARGET_NAME), i386)
+
+# Currently broken for -p
+run-test-mmap: test-mmap
+ $(call quiet-command, $(QEMU) $< > test-mmap.out, "TEST", "$< (default) on $(TARGET_NAME)")
+
+endif
diff --git a/tests/tcg/m68k/Makefile.target b/tests/tcg/m68k/Makefile.target
new file mode 100644
index 0000000000..92774ce5ad
--- /dev/null
+++ b/tests/tcg/m68k/Makefile.target
@@ -0,0 +1,9 @@
+# -*- Mode: makefile -*-
+#
+# m68k specific tweaks - specifically masking out broken tests
+#
+
+# Currently broken for -p
+run-test-mmap: test-mmap
+ $(call quiet-command, $(QEMU) $< > test-mmap.out, "TEST", "$< (default) on $(TARGET_NAME)")
+
diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target
index 71f0c2dd53..3db4eaf131 100644
--- a/tests/tcg/mips/Makefile.target
+++ b/tests/tcg/mips/Makefile.target
@@ -17,3 +17,7 @@ hello-mips: LDFLAGS+=-nostdlib
# For MIPS32 and 64 we have a bunch of extra tests in sub-directories
# however they are intended for system tests.
+
+run-hello-mips: hello-mips
+ $(call quiet-command, /bin/true, "BROKEN TEST", "$< SKIPPED on $(TARGET_NAME)")
+
diff --git a/tests/tcg/sparc64/Makefile.target b/tests/tcg/sparc64/Makefile.target
new file mode 100644
index 0000000000..e971a5c818
--- /dev/null
+++ b/tests/tcg/sparc64/Makefile.target
@@ -0,0 +1,8 @@
+# -*- Mode: makefile -*-
+#
+# sparc specific tweaks - specifically masking out broken tests
+
+# different from the other hangs
+# /home/alex/lsrc/qemu/qemu.git/tests/tcg/multiarch/linux-test.c:264: Value too large for defined data type (ret=-1, errno=92/Value too large for defined data type)
+run-linux-test: linux-test
+ $(call quiet-command, /bin/true, "BROKEN TEST", "$< SKIPPED on $(TARGET_NAME)")
--
2.17.0
prev parent reply other threads:[~2018-05-17 18:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180517174718.10107-1-alex.bennee@linaro.org>
2018-05-17 17:46 ` [PATCH v4 26/49] tests/tcg: move ARM specific tests into subdir Alex Bennée
2018-05-18 15:26 ` Philippe Mathieu-Daudé
2018-05-18 15:58 ` Alex Bennée
2018-05-17 17:46 ` [PATCH v4 27/49] tests/tcg: enable building for ARM Alex Bennée
2018-05-18 15:28 ` Philippe Mathieu-Daudé
2018-05-18 15:48 ` Alex Bennée
2018-05-17 17:46 ` [PATCH v4 28/49] tests/tcg/arm: fix up test-arm-iwmmxt test Alex Bennée
2018-05-17 20:15 ` Richard Henderson
2018-05-17 17:46 ` [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test Alex Bennée
2018-05-17 20:20 ` Richard Henderson
2018-05-17 21:24 ` Alex Bennée
2018-05-17 21:34 ` Richard Henderson
2018-05-18 3:47 ` Philippe Mathieu-Daudé
2018-05-17 17:46 ` [PATCH v4 30/49] tests/tcg: enable building for AArch64 Alex Bennée
2018-05-17 20:26 ` Richard Henderson
2018-05-18 14:57 ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [PATCH v4 31/49] tests/tcg/aarch64: add Makefile.target Alex Bennée
2018-05-17 20:28 ` Richard Henderson
2018-05-17 21:25 ` Alex Bennée
2018-05-17 17:47 ` [PATCH v4 32/49] tests/tcg/arm: add fcvt test cases for AArch32/64 Alex Bennée
2018-05-17 20:30 ` Richard Henderson
2018-05-18 3:45 ` Philippe Mathieu-Daudé
2018-05-18 8:16 ` Alex Bennée
2018-05-18 14:53 ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517174718.10107-50-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=balrogg@gmail.com \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=yongbok.kim@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).