From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent.desnogues@gmail.com, peter.maydell@linaro.org,
qemu-arm@nongnu.org
Subject: [Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64
Date: Wed, 1 Aug 2018 08:31:09 -0400 [thread overview]
Message-ID: <20180801123111.3595-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20180801123111.3595-1-richard.henderson@linaro.org>
Used the wrong temporary in the computation of subtractive overflow.
Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/translate-sve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 374051cd20..9dd4c38bab 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -1625,7 +1625,7 @@ static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64 val, bool u, bool d)
/* Detect signed overflow for subtraction. */
tcg_gen_xor_i64(t0, reg, val);
tcg_gen_sub_i64(t1, reg, val);
- tcg_gen_xor_i64(reg, reg, t0);
+ tcg_gen_xor_i64(reg, reg, t1);
tcg_gen_and_i64(t0, t0, reg);
/* Bound the result. */
--
2.17.1
next prev parent reply other threads:[~2018-08-01 12:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 12:31 [Qemu-devel] [PATCH 0/4] target/arm sve fixes Richard Henderson
2018-08-01 12:31 ` [Qemu-arm] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw Richard Henderson
2018-08-01 13:28 ` Laurent Desnogues
2018-08-01 13:45 ` Alex Bennée
2018-08-01 12:31 ` Richard Henderson [this message]
2018-08-01 13:30 ` [Qemu-arm] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64 Laurent Desnogues
2018-08-01 12:31 ` [Qemu-arm] [PATCH 3/4] target/arm: Reorganize SVE WHILE Richard Henderson
2018-08-01 13:29 ` [Qemu-devel] " Laurent Desnogues
2018-08-01 12:31 ` [Qemu-arm] [PATCH 4/4] target/arm: Fix typo in helper_sve_movz_d Richard Henderson
2018-08-01 13:28 ` Laurent Desnogues
2018-08-01 13:44 ` Alex Bennée
2018-08-02 15:39 ` Philippe Mathieu-Daudé
2018-08-01 13:31 ` [Qemu-arm] [PATCH 0/4] target/arm sve fixes Laurent Desnogues
2018-08-01 15:11 ` [Qemu-devel] " Alex Bennée
2018-08-01 20:11 ` [Qemu-arm] " no-reply
2018-08-02 16:32 ` no-reply
2018-08-03 13:31 ` [Qemu-arm] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801123111.3595-3-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent.desnogues@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).