From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5e6c:0:0:0:0:0 with SMTP id a12csp504402lfr; Thu, 15 Apr 2021 06:03:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyuXseVTgKVarqYPQ+tEJIgSCOffrYwEFpKQ/hFjGxaYV+Ny2nT5+NeGGBWTjN3lAy88ua X-Received: by 2002:a7b:c186:: with SMTP id y6mr3102591wmi.1.1618491817419; Thu, 15 Apr 2021 06:03:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618491817; cv=none; d=google.com; s=arc-20160816; b=FfeCS9LHO7v5b4Ii+J4mVvw8urTFqR2LrgxSnA7o+tVTRo6WtRsjW7IEuZ28IquGAr LLi9GOygFh6gq8f8N7xXcMVlePVMnebzI/s8J+QEKpLpdQWtUNdbWtgaiRCQtGx0KRi1 5F22vqES4OcmvJir+5+6WaSajDs0sLrMyZrNvQabzR5HAvGoewVRs9faHlBTfjNocvBs 3w/9YhnkJ/vTNbT6Zpl+iTSukOIaEW3/T5ufvajEFdDc+Qac7k3YkOCXjdWtaQpo0tvE vDmB7HK/A0tbOSk9cVclNzbngUXJTNXyCRZL2jleW8+pKQhLYSfufo0k/MdJOZZKR+dx 3ncg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=BW7u4WcPkobkkMRidYkYfR+F2b4Woa8iJkWP89Rsaw0=; b=N3aWyQ2dcAMACjr8Di8ybgDpyo+UUsryRjpBzkTDoO4pVDs5PgIQsh+QUNKNrBGpYg W7rATeUBYNfE/y5dOc3tJP8FYME5uMN4lOVCJnAoqEE0CeSH5xM6by14LoekysUzu9hJ ZjKiW3c5Bnjj8w8NDQ56lmN18kCi6qEQ5RIUxTMJYk8620N3FyE1iIQEeh6PFoAG19Ki 3neWRjAplZNknxJoSKpzZ8EcOlFx4JApLJ6VWnFIk+6OHqxfyTc2a2vi+nBfUYxYL6l7 R8+HESO0ueF1/fDkNOgeXFKNawzgk8bzl26cKDtLcNBd0uXvn1bMte5ZFIM/nsB662vB UjfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ibm.com header.s=pp1 header.b=YRKahCUi; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b7si2616832wrr.290.2021.04.15.06.03.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Apr 2021 06:03:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@ibm.com header.s=pp1 header.b=YRKahCUi; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1]:33414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX1ei-0005zy-EH for alex.bennee@linaro.org; Thu, 15 Apr 2021 09:03:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX1eV-0005uA-Fa; Thu, 15 Apr 2021 09:03:23 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX1eS-0001FB-KS; Thu, 15 Apr 2021 09:03:23 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13FCY29e022938; Thu, 15 Apr 2021 09:03:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=BW7u4WcPkobkkMRidYkYfR+F2b4Woa8iJkWP89Rsaw0=; b=YRKahCUiwqBkNHMSvkKUR2WQHFcqYVADPxGHoTd9pZRO9zMwiV+HrA/Z5Ljrk0/XotIk J24BHDF0aqND5lDhag+v0c8YuD82MkUpF6A4R9DgCpaFbjoCR8UcayWgBxvYM5J9OyE5 BPfmkTJ85B46Sy82j3HXXdH74gElig7ZO4VL8tN/M1AQZgUe5A1HhJ99rlYJbjDnGTut YBxVjgNgnyVEw/cmXCO9w8680Nh2kNMdK2Ui8i/ANgSf0y+ypf2b/YBo+m9bDQvdndNd 6dne9rTET8ftKFSutiOnGijpw77do8bIpgNZg3U8ZfvmWXidkq531KcnrZXJJ0r+pCBJ EA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 37x13vh433-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Apr 2021 09:03:17 -0400 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 13FClgGT074323; Thu, 15 Apr 2021 09:03:17 -0400 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 37x13vh415-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Apr 2021 09:03:16 -0400 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 13FCradI011692; Thu, 15 Apr 2021 13:03:14 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma05fra.de.ibm.com with ESMTP id 37u3n8a3h7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Apr 2021 13:03:14 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 13FD3BhL25100564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Apr 2021 13:03:11 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F10F5A4069; Thu, 15 Apr 2021 13:03:10 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65BEBA4054; Thu, 15 Apr 2021 13:03:10 +0000 (GMT) Received: from vm.lan (unknown [9.145.157.105]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 15 Apr 2021 13:03:10 +0000 (GMT) From: Ilya Leoshkevich To: Cornelia Huck , Thomas Huth , Richard Henderson , David Hildenbrand , Paolo Bonzini , Peter Maydell , Max Filippov Subject: [PATCH v4 4/4] accel/tcg: Assert that tb->size != 0 after translation Date: Thu, 15 Apr 2021 15:03:05 +0200 Message-Id: <20210415130305.28640-5-iii@linux.ibm.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210415130305.28640-1-iii@linux.ibm.com> References: <20210415130305.28640-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 8blabmXFe8Uzu6MIvoAenvTKtjnIVgBM X-Proofpoint-ORIG-GUID: dbX4gnH0M7z7_gCRIu83RneRgbu--vFn X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-15_04:2021-04-15, 2021-04-15 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 mlxscore=0 spamscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104150084 Received-SPF: pass client-ip=148.163.156.1; envelope-from=iii@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, Ilya Leoshkevich Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: j+wKFIT9tzl5 If arch-specific code generates a translation block of size 0, tb_gen_code() may generate a spurious exception. Add an assertion in order to catch such situations early. Signed-off-by: Ilya Leoshkevich Reviewed-by: David Hildenbrand --- accel/tcg/translate-all.c | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index ba6ab09790..93b2dae112 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1913,6 +1913,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu, tcg_ctx->cpu = env_cpu(env); gen_intermediate_code(cpu, tb, max_insns); + assert(tb->size != 0); tcg_ctx->cpu = NULL; max_insns = tb->icount; -- 2.29.2