From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5e6c:0:0:0:0:0 with SMTP id a12csp508790lfr; Fri, 16 Apr 2021 08:52:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/D/KxorxYzy/LVgs+677HLfLfaAfrQ0L7JH4jILbittmT34vTMc8XfOO9urqG1Cv0DMEs X-Received: by 2002:a05:6e02:156c:: with SMTP id k12mr5121098ilu.49.1618588372726; Fri, 16 Apr 2021 08:52:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618588372; cv=none; d=google.com; s=arc-20160816; b=dKpq/mzsG8CoBDsXmi93F6nKe2gyllrddtbYR9eCO4dAkbWDMRICSC6A91yFI87x2r FQuFCEGbgKtHu+OWnlm066Js08hWEccwCrOrdpn8oyB3S8L7LNMKJDcLPLQktGpcKsaD TdtFUcSNvKf+8T+a/NCxD+6xBxB/cEC7203OpEjnpMzCeIPOqZCYqgalT5X/qiFtOpSI deYJ1bNbj+PKPTHv7XV/99oPqitXuQkarlnQTdt3pPNreA1bGgQF7H2CCpsqo2z/Sdex KXyJfr1XxCJfaOuxIDdOHfL1jrlSKm6C5I0TUtMGc0yQk4wWft3hfjLr6oWh9N3P8dz2 4Zrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=noW5sQQCRmg+yeWGQnejM9mslGtD7xpsjveru2Pctc0=; b=i7koUiGXjYPY51GG4me+rcAgHpo3IwGhL0DMo2gBKxL68KzxKOYDP7c0dQoUKyQDAX mVgspAkwZT/gb7QaA/5UiIjhp9mrV3A2b9k2/kJy21e2Jm1QAirxailWFc6MECp2wlgN mYLtyrgPK9CiCotIHnVaFy2c2eQiApj5OPlje8K1A5zVKwHWDRlRhzWBDpUnAziDo069 wVoSzsJgHim+p9x3snua5/XWU2EVQnSMIcVtd9mPuo8CyyKbzOuWm8McPqYzpKrnMGFq nwpt/nMECiNnOHG8yiPQBGZLcS2/xTlseCJTQjNDCYBXXZYtzvGRY2irkmkzFhxzJr8f j81g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ibm.com header.s=pp1 header.b="cg8F/jys"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c15si2104427jag.124.2021.04.16.08.52.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Apr 2021 08:52:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@ibm.com header.s=pp1 header.b="cg8F/jys"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1]:56304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXQm4-00053E-11 for alex.bennee@linaro.org; Fri, 16 Apr 2021 11:52:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXQjA-00033s-8O; Fri, 16 Apr 2021 11:49:52 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:64850 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXQj8-000085-GT; Fri, 16 Apr 2021 11:49:51 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13GFY0ia065465; Fri, 16 Apr 2021 11:49:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=noW5sQQCRmg+yeWGQnejM9mslGtD7xpsjveru2Pctc0=; b=cg8F/jysqjSbb7PeucDArGIptbmlBdPtiYacJHiGdbWcrii1qyricN9B+iszb47TJ8+j HUPRtTo+hqI3E0mxTbqxkWMiopaxW1rk5OatWaR6QiuvJ154K3IbX/ccbIpIjretUkbA gqYvbFTpA7i++fapDAmqheuxTjfGZu5Ok1OWtBCXi5ZllB9fUyDPXWUzbv8MSgzk3xDN F/MNkejimUHMD/FvG/FmLUA01SbFctYYS8teEKU6vlTM29xR1uYQyUygFFrk7v8ttYR4 9tffG3VdQX7nQQZL9P2LevtPSlVk8g8W05fg5gSAp4mnCTNhSG2+qoqYC1zQgTa9mRDs Qg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 37xxnpq9rc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Apr 2021 11:49:48 -0400 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 13GFYUHM067985; Fri, 16 Apr 2021 11:49:48 -0400 Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0b-001b2d01.pphosted.com with ESMTP id 37xxnpq9qv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Apr 2021 11:49:48 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 13GFcoDE014255; Fri, 16 Apr 2021 15:49:46 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma01fra.de.ibm.com with ESMTP id 37u3n8af7q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Apr 2021 15:49:46 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 13GFnhiW23462286 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 Apr 2021 15:49:43 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B4E711C04C; Fri, 16 Apr 2021 15:49:43 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7C00111C050; Fri, 16 Apr 2021 15:49:42 +0000 (GMT) Received: from vm.lan (unknown [9.145.157.105]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 16 Apr 2021 15:49:42 +0000 (GMT) From: Ilya Leoshkevich To: Cornelia Huck , Thomas Huth , Richard Henderson , David Hildenbrand , Paolo Bonzini , Peter Maydell , Max Filippov Subject: [PATCH v5 2/4] target/arm: Make sure that commpage's tb->size != 0 Date: Fri, 16 Apr 2021 17:49:37 +0200 Message-Id: <20210416154939.32404-3-iii@linux.ibm.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210416154939.32404-1-iii@linux.ibm.com> References: <20210416154939.32404-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: vmJfguCAx6tIG_ESjfhEJnw66f8i9uXT X-Proofpoint-ORIG-GUID: QpSuOqeBSt0GW49ex5au31BXOt4bM06M X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-16_08:2021-04-16, 2021-04-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 mlxscore=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104160113 Received-SPF: pass client-ip=148.163.158.5; envelope-from=iii@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, Ilya Leoshkevich Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: ur2qSc43tUVA tb_gen_code() assumes that tb->size must never be zero, otherwise it may produce spurious exceptions. For ARM this may happen when creating a translation block for the commpage. Fix by pretending that commpage translation blocks have at least one instruction. Signed-off-by: Ilya Leoshkevich --- target/arm/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/translate.c b/target/arm/translate.c index 62b1c2081b..cb9e30c341 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -9060,6 +9060,7 @@ static void arm_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu) unsigned int insn; if (arm_pre_translate_insn(dc)) { + dc->base.pc_next += 4; return; } @@ -9129,6 +9130,7 @@ static void thumb_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu) bool is_16bit; if (arm_pre_translate_insn(dc)) { + dc->base.pc_next += 2; return; } -- 2.29.2