From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, alex.bennee@linaro.org, qemu-arm@nongnu.org
Subject: [PATCH v2 04/23] linux-user/arm: Force v2 frames for fdpic
Date: Fri, 18 Jun 2021 12:29:32 -0700 [thread overview]
Message-ID: <20210618192951.125651-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210618192951.125651-1-richard.henderson@linaro.org>
The value of get_os_release may be controlled by a command
line option. Since fdpic was added in v4.14, and v2 frame
were added in v2.6.12, this makes no change under normal conditions.
Cc: qemu-arm@nongnu.org
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/arm/signal.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/linux-user/arm/signal.c b/linux-user/arm/signal.c
index cb65623965..2d30345fc2 100644
--- a/linux-user/arm/signal.c
+++ b/linux-user/arm/signal.c
@@ -167,7 +167,14 @@ static inline int valid_user_regs(CPUARMState *regs)
static bool v2_frame(void)
{
- return get_osversion() >= 0x020612;
+ /*
+ * We do not create fdpic trampolines for v1 frames.
+ * Thus we force v2 frames, regardless of what uname says.
+ * Support for fdpic dates from Linux 4.14, so this is not
+ * really a behaviour change.
+ */
+ int is_fdpic = info_is_fdpic(((TaskState *)thread_cpu->opaque)->info);
+ return is_fdpic || get_osversion() >= 0x020612;
}
static void
--
2.25.1
next prev parent reply other threads:[~2021-06-18 19:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210618192951.125651-1-richard.henderson@linaro.org>
2021-06-18 19:29 ` [PATCH v2 02/23] linux-user/aarch64: Implement setup_sigtramp Richard Henderson
2021-06-29 13:36 ` Peter Maydell
2021-07-01 19:27 ` Richard Henderson
2021-06-18 19:29 ` [PATCH v2 03/23] linux-user/arm: Split out v2_frame Richard Henderson
2021-06-29 13:53 ` Peter Maydell
2021-06-29 14:30 ` Richard Henderson
2021-06-18 19:29 ` Richard Henderson [this message]
2021-06-29 13:54 ` [PATCH v2 04/23] linux-user/arm: Force v2 frames for fdpic Peter Maydell
2021-06-18 19:29 ` [PATCH v2 05/23] linux-user/arm: Implement setup_sigtramp Richard Henderson
2021-06-29 14:09 ` Peter Maydell
2021-06-29 18:32 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618192951.125651-5-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).