From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
David Hildenbrand <david@redhat.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>
Subject: [RFC PATCH 0/3] Remove some of the old libopcode based disassemblers
Date: Tue, 12 Apr 2022 18:58:33 +0200 [thread overview]
Message-ID: <20220412165836.355850-1-thuth@redhat.com> (raw)
Many of the disassemblers in the disas folder are based on old
versions from the GNU tools (libopcode, GDB, ...) that were still
licensed under the GPL v2. The GNU tools switched to GPL v3 at one
point in time, so QEMU is stuck with the old versions, i.e. these
files did not see much updates for new processors anymore. But
for most architectures, we're preferring the Capstone disassembler
now anyway, so the old libopcode disassemblers are also hardly
used anymore.
I'm not 100% sure (thus this is marked as RFC), but I think we could
simply drop the old disassemblers nowadays, and hardly anybody would
miss them, since we now always embed capstone as a submodule anyway.
Or is there still an advantage in keeping these old files around?
This RFC series tackles with s390, arm (32-bit) and i386 ... I wanted
to get some feedback first, but if we agree that these can be removed,
the sparc, mips and ppc disassemblers likely can be removed, too.
(I think we should keep m68k.c since Capstone does not have support
for Coldfire CPUs yet).
Thomas Huth (3):
disas: Remove old libopcode s390 disassembler
disas: Remove old libopcode arm disassembler
disas: Remove old libopcode i386 disassembler
include/disas/dis-asm.h | 3 -
disas.c | 3 -
disas/arm.c | 4012 -----------------------
disas/i386.c | 6771 ---------------------------------------
disas/s390.c | 1892 -----------
target/arm/cpu.c | 8 -
target/i386/cpu.c | 1 -
target/s390x/cpu.c | 1 -
MAINTAINERS | 6 -
disas/meson.build | 3 -
10 files changed, 12700 deletions(-)
delete mode 100644 disas/arm.c
delete mode 100644 disas/i386.c
delete mode 100644 disas/s390.c
--
2.27.0
next reply other threads:[~2022-04-12 17:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 16:58 Thomas Huth [this message]
2022-04-12 16:58 ` [RFC PATCH 1/3] disas: Remove old libopcode s390 disassembler Thomas Huth
2022-04-12 16:58 ` [RFC PATCH 2/3] disas: Remove old libopcode arm disassembler Thomas Huth
2022-04-12 16:58 ` [RFC PATCH 3/3] disas: Remove old libopcode i386 disassembler Thomas Huth
2022-04-21 18:35 ` [RFC PATCH 0/3] Remove some of the old libopcode based disassemblers Richard Henderson
2022-05-09 12:20 ` Philippe Mathieu-Daudé via
2022-05-09 13:18 ` Thomas Huth
2022-05-09 13:42 ` Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412165836.355850-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).