From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:6512:230d:0:0:0:0 with SMTP id o13csp364157lfu; Tue, 26 Apr 2022 09:44:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5/VvVmd6OSvuJEVLh23Z41TKwNyCZJ9/BgbqBwYjN8/IKRLERndhJK+SyJBIlPyY9EMGY X-Received: by 2002:a25:9909:0:b0:624:57e:d919 with SMTP id z9-20020a259909000000b00624057ed919mr21766603ybn.494.1650991443992; Tue, 26 Apr 2022 09:44:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650991443; cv=none; d=google.com; s=arc-20160816; b=ByWqMNswRRXJ1Un6Y1NmeVqJLf6QuOIphQu3ayLae847qXdSiS9Naa/XMA71woZ035 8xe1d7auv7bWOp+4tsm6u8iIbwpCTilkuEbajBilvCojg/TtPjGMsbBkH4/dnhzDf6ab 965hoq0od1er0B0mnEwO3bCQ/0RqqtM4X5Q0lAyBD4qlcna3T8lv6jKOI0eWAv9uDPkS Ep8uckeYHLVOYCAfoXMBmYR5HBmUbU2x8EKL8XlJOJSyes3DY+HDfeORN/jqiOI+I5ke Xk1+xzp4Pwsp0k6/a6BRdphVCGNpdDLL7Nx5DIwNyRYL6hHgiH4Se8mG6RsuNBr0XcLE bc5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=3kAfkV/aZkCQhNUer/1meejI7m8mfD0mYpM7M5aKteI=; b=UQa1RArREoV++tcLtsYmZlG9KVULnTCW6+sJNZz62m3g4tQ1mJLGzm+9sETgY9IN6+ NPy95+CLMwdRNdR15e/ymXQfiXwejMpaC1WN+Gig0qsw2sX9fMYN0onx7KWalHSVbzXS ZsInLcu8x41/Z/kPxT99Gx5Lts+7cumdJzvZBg8d7IGl3WU8C5vwbyZNKNvRilTcrSOK oN4gG2VHYZpVbCENdkXxVPY5FB7xSUtsiezm0NHQgcLhvuaXgGQlQSTrQV0CrP1cG+hM uhIcFoPxD+3rSkJROgw6DCYMSUYcUAqeZbVWYYENhMVAVOHz+AqjY0JQ7H9GCngtzQWS pyug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="zeaN/IgS"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z66-20020a254c45000000b00641b340f8d8si13534056yba.332.2022.04.26.09.44.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Apr 2022 09:44:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="zeaN/IgS"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njOIF-0005Oj-9R for alex.bennee@linaro.org; Tue, 26 Apr 2022 12:44:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njO5k-000305-Ka for qemu-arm@nongnu.org; Tue, 26 Apr 2022 12:31:14 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:35502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njO5g-0003q4-NL for qemu-arm@nongnu.org; Tue, 26 Apr 2022 12:31:06 -0400 Received: by mail-pg1-x52a.google.com with SMTP id r83so16507650pgr.2 for ; Tue, 26 Apr 2022 09:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3kAfkV/aZkCQhNUer/1meejI7m8mfD0mYpM7M5aKteI=; b=zeaN/IgS2Qb+sM4tHvZO64AFGqFcaCUagKt5VC+DIzkt7o51+2tgeuXJpdk3mX8Q3o qD6zKtrnajjeokSDUXctxVvikkfMcKRRrh5AUh8g4VS31wNtGhk2PTewMlQ1PsYwUMAj 452keZo3V9fvPeWBklyZmzPILhnhT9vNLTYmaHSQ7NLISBSqARdwB/WuAVmNGnN7uWac Vqx54ogXU85BDVaBLz/l2p/7gWIbKANyVuDfy819tpA5fCeXEvoyOHu5i2mYQnwA7pjl Dc5feQ17bABxuYy5jukiiOrZAIUQxm559ROl6x1SVinPiU1Yjo0/8Kjp4Fe8ua8IVlb/ w4UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3kAfkV/aZkCQhNUer/1meejI7m8mfD0mYpM7M5aKteI=; b=bsyAw/ZLMUpA430wjcLWtdef4nYu9s3XJ9u8MF8b8yICGSwPADDvSelflCuvkAVDIz yUEZBZKFnS2yN0sKDuVfRY+v/lsM8tqQh4PYmnryckor+nSTg89votRBJfuTVmRMP/Wc cvsdtWtaLErI0RCwDNErtfz5MO6WnZMs7K7sqn9tJjDwBmWFl2dC1kHGv37NbAU+Hc8v DEwDDR+1rof+fKzNbK5JmPGwlGktF4X8e19B+T/fFesYH5vAzVmGvPLV6opujCqBYoTp a2I+uqn96q0SRO6v+O8kHsc4MYP2787NHMAUrgiGUHKy3cgBw71zdv2vQQppt6ppotRb 80iw== X-Gm-Message-State: AOAM532gRxMna8UbadmQiaaX4BcJh5jjMpr6dz7dU5mx+udIgP7uvvgU Es7F3sAOGFFRctBh4zpdHl2bG/lCbqO/Kw== X-Received: by 2002:a63:38e:0:b0:3ab:ada6:a219 with SMTP id 136-20020a63038e000000b003abada6a219mr1082601pgd.140.1650990663258; Tue, 26 Apr 2022 09:31:03 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id y131-20020a626489000000b00505a8f36965sm15655813pfb.184.2022.04.26.09.31.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 09:31:02 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 18/47] target/arm: Use tcg_constant in simd shift expanders Date: Tue, 26 Apr 2022 09:30:14 -0700 Message-Id: <20220426163043.100432-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426163043.100432-1-richard.henderson@linaro.org> References: <20220426163043.100432-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: yR4/iEXEwAwM Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 847da725ea..45abac6892 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -8353,7 +8353,7 @@ static void handle_shri_with_rndacc(TCGv_i64 tcg_res, TCGv_i64 tcg_src, /* Deal with the rounding step */ if (round) { if (extended_result) { - TCGv_i64 tcg_zero = tcg_const_i64(0); + TCGv_i64 tcg_zero = tcg_constant_i64(0); if (!is_u) { /* take care of sign extending tcg_res */ tcg_gen_sari_i64(tcg_src_hi, tcg_src, 63); @@ -8365,7 +8365,6 @@ static void handle_shri_with_rndacc(TCGv_i64 tcg_res, TCGv_i64 tcg_src, tcg_src, tcg_zero, tcg_rnd, tcg_zero); } - tcg_temp_free_i64(tcg_zero); } else { tcg_gen_add_i64(tcg_src, tcg_src, tcg_rnd); } @@ -8451,8 +8450,7 @@ static void handle_scalar_simd_shri(DisasContext *s, } if (round) { - uint64_t round_const = 1ULL << (shift - 1); - tcg_round = tcg_const_i64(round_const); + tcg_round = tcg_constant_i64(1ULL << (shift - 1)); } else { tcg_round = NULL; } @@ -8478,9 +8476,6 @@ static void handle_scalar_simd_shri(DisasContext *s, tcg_temp_free_i64(tcg_rn); tcg_temp_free_i64(tcg_rd); - if (round) { - tcg_temp_free_i64(tcg_round); - } } /* SHL/SLI - Scalar shift left */ @@ -8578,8 +8573,7 @@ static void handle_vec_simd_sqshrn(DisasContext *s, bool is_scalar, bool is_q, tcg_final = tcg_const_i64(0); if (round) { - uint64_t round_const = 1ULL << (shift - 1); - tcg_round = tcg_const_i64(round_const); + tcg_round = tcg_constant_i64(1ULL << (shift - 1)); } else { tcg_round = NULL; } @@ -8599,9 +8593,6 @@ static void handle_vec_simd_sqshrn(DisasContext *s, bool is_scalar, bool is_q, write_vec_element(s, tcg_final, rd, 1, MO_64); } - if (round) { - tcg_temp_free_i64(tcg_round); - } tcg_temp_free_i64(tcg_rn); tcg_temp_free_i64(tcg_rd); tcg_temp_free_i32(tcg_rd_narrowed); @@ -8653,7 +8644,7 @@ static void handle_simd_qshl(DisasContext *s, bool scalar, bool is_q, } if (size == 3) { - TCGv_i64 tcg_shift = tcg_const_i64(shift); + TCGv_i64 tcg_shift = tcg_constant_i64(shift); static NeonGenTwo64OpEnvFn * const fns[2][2] = { { gen_helper_neon_qshl_s64, gen_helper_neon_qshlu_s64 }, { NULL, gen_helper_neon_qshl_u64 }, @@ -8670,10 +8661,9 @@ static void handle_simd_qshl(DisasContext *s, bool scalar, bool is_q, tcg_temp_free_i64(tcg_op); } - tcg_temp_free_i64(tcg_shift); clear_vec_high(s, is_q, rd); } else { - TCGv_i32 tcg_shift = tcg_const_i32(shift); + TCGv_i32 tcg_shift = tcg_constant_i32(shift); static NeonGenTwoOpEnvFn * const fns[2][2][3] = { { { gen_helper_neon_qshl_s8, @@ -8718,7 +8708,6 @@ static void handle_simd_qshl(DisasContext *s, bool scalar, bool is_q, tcg_temp_free_i32(tcg_op); } - tcg_temp_free_i32(tcg_shift); if (!scalar) { clear_vec_high(s, is_q, rd); -- 2.34.1