From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Andrew Jones" <ajones@ventanamicro.com>,
"Ani Sinha" <anisinha@redhat.com>,
qemu-arm@nongnu.org, "Shannon Zhao" <shannon.zhaosl@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 06/20] hw/arm/virt: Remove VirtMachineClass::acpi_expose_flash field
Date: Fri, 17 Oct 2025 15:08:05 +0200 [thread overview]
Message-ID: <20251017130821.58388-7-philmd@linaro.org> (raw)
In-Reply-To: <20251017130821.58388-1-philmd@linaro.org>
The VirtMachineClass::acpi_expose_flash field was only used by
the virt-5.0 machine, which got removed (see commit 2c1fb4d5c01
"hw/arm/virt-acpi-build: Only expose flash on older machine types"
for more context). Remove it as now unused.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/arm/virt.h | 1 -
hw/arm/virt-acpi-build.c | 28 ----------------------------
2 files changed, 29 deletions(-)
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index c77a33f6df2..ba16acb8626 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -124,7 +124,6 @@ struct VirtMachineClass {
bool no_tcg_its;
bool no_highmem_compact;
bool no_kvm_steal_time;
- bool acpi_expose_flash;
bool no_secure_gpio;
/* Machines < 6.2 have no support for describing cpu topology to guest */
bool no_cpu_topology;
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 8bb6b605154..5db5baa7cf3 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -99,30 +99,6 @@ static void acpi_dsdt_add_uart(Aml *scope, const MemMapEntry *uart_memmap,
aml_append(scope, dev);
}
-static void acpi_dsdt_add_flash(Aml *scope, const MemMapEntry *flash_memmap)
-{
- Aml *dev, *crs;
- hwaddr base = flash_memmap->base;
- hwaddr size = flash_memmap->size / 2;
-
- dev = aml_device("FLS0");
- aml_append(dev, aml_name_decl("_HID", aml_string("LNRO0015")));
- aml_append(dev, aml_name_decl("_UID", aml_int(0)));
-
- crs = aml_resource_template();
- aml_append(crs, aml_memory32_fixed(base, size, AML_READ_WRITE));
- aml_append(dev, aml_name_decl("_CRS", crs));
- aml_append(scope, dev);
-
- dev = aml_device("FLS1");
- aml_append(dev, aml_name_decl("_HID", aml_string("LNRO0015")));
- aml_append(dev, aml_name_decl("_UID", aml_int(1)));
- crs = aml_resource_template();
- aml_append(crs, aml_memory32_fixed(base + size, size, AML_READ_WRITE));
- aml_append(dev, aml_name_decl("_CRS", crs));
- aml_append(scope, dev);
-}
-
static void build_acpi0017(Aml *table)
{
Aml *dev, *scope, *method;
@@ -1011,7 +987,6 @@ static void build_fadt_rev6(GArray *table_data, BIOSLinker *linker,
static void
build_dsdt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
{
- VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
Aml *scope, *dsdt;
MachineState *ms = MACHINE(vms);
const MemMapEntry *memmap = vms->memmap;
@@ -1036,9 +1011,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
acpi_dsdt_add_uart(scope, &memmap[VIRT_UART1],
(irqmap[VIRT_UART1] + ARM_SPI_BASE), 1);
}
- if (vmc->acpi_expose_flash) {
- acpi_dsdt_add_flash(scope, &memmap[VIRT_FLASH]);
- }
fw_cfg_acpi_dsdt_add(scope, &memmap[VIRT_FW_CFG]);
virtio_acpi_dsdt_add(scope, memmap[VIRT_MMIO].base, memmap[VIRT_MMIO].size,
(irqmap[VIRT_MMIO] + ARM_SPI_BASE),
--
2.51.0
next prev parent reply other threads:[~2025-10-17 13:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 13:07 [PATCH 00/20] hw/arm/virt: Remove virt-4.1 -> virt-7.2 machines Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 01/20] hw/arm/virt: Remove deprecated virt-4.1 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 02/20] hw/arm/virt: Remove VirtMachineClass::no_ged field Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 03/20] hw/arm/virt: Remove deprecated virt-4.2 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 04/20] hw/arm/virt: Remove VirtMachineClass::kvm_no_adjvtime field Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 05/20] hw/arm/virt: Remove deprecated virt-5.0 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` Philippe Mathieu-Daudé [this message]
2025-10-17 13:08 ` [PATCH 07/20] hw/arm/virt: Remove deprecated virt-5.1 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 08/20] hw/arm/virt: Remove VirtMachineClass::no_kvm_steal_time field Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 09/20] hw/arm/virt: Remove deprecated virt-5.2 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 10/20] hw/arm/virt: Remove VirtMachineClass::no_secure_gpio field Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 11/20] hw/arm/virt: Remove deprecated virt-6.0 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 12/20] hw/arm/virt: Remove deprecated virt-6.1 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 13/20] hw/arm/virt: Remove VirtMachineClass::no_tcg_its field Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 14/20] hw/arm/virt: Remove VirtMachineClass::no_cpu_topology field Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 15/20] hw/arm/virt: Remove deprecated virt-6.2 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 16/20] hw/arm/virt: Remove VirtMachineClass::no_tcg_lpa2 field Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 17/20] hw/arm/virt: Remove deprecated virt-7.0 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 18/20] hw/arm/virt: Remove deprecated virt-7.1 machine Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 19/20] hw/arm/virt: Remove VirtMachineClass::no_highmem_compact field Philippe Mathieu-Daudé
2025-10-17 13:08 ` [PATCH 20/20] hw/arm/virt: Remove deprecated virt-7.2 machine Philippe Mathieu-Daudé
2025-10-17 13:18 ` [PATCH 00/20] hw/arm/virt: Remove virt-4.1 -> virt-7.2 machines Daniel P. Berrangé
2025-10-17 13:39 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017130821.58388-7-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=ajones@ventanamicro.com \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).