qemu-arm.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Anton Johansson" <anjo@rev.ng>,
	qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Bernhard Beschow" <shentey@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Yanan Wang" <wangyanan55@huawei.com>
Subject: [PATCH v6 01/30] hw/core: Filter machine list available for a particular target binary
Date: Tue, 21 Oct 2025 00:09:10 +0200	[thread overview]
Message-ID: <20251020220941.65269-2-philmd@linaro.org> (raw)
In-Reply-To: <20251020220941.65269-1-philmd@linaro.org>

Binaries can register a QOM type to filter their machines
by filling their TargetInfo::machine_typename field.

Commit 28502121be7 ("system/vl: Filter machine list available
for a particular target binary") added the filter to
machine_help_func() but missed the other places where the machine
list must be filtered, such QMP 'query-machines' command used by
QTests, and select_machine(). Fix that.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/core/machine-qmp-cmds.c | 4 +++-
 monitor/qemu-config-qmp.c  | 3 ++-
 system/vl.c                | 3 ++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
index 51d5c230f7e..28dfd3e15bd 100644
--- a/hw/core/machine-qmp-cmds.c
+++ b/hw/core/machine-qmp-cmds.c
@@ -20,6 +20,7 @@
 #include "qapi/qobject-input-visitor.h"
 #include "qapi/type-helpers.h"
 #include "qemu/uuid.h"
+#include "qemu/target-info.h"
 #include "qemu/target-info-qapi.h"
 #include "qom/qom-qobject.h"
 #include "system/hostmem.h"
@@ -94,9 +95,10 @@ CpuInfoFastList *qmp_query_cpus_fast(Error **errp)
 MachineInfoList *qmp_query_machines(bool has_compat_props, bool compat_props,
                                     Error **errp)
 {
-    GSList *el, *machines = object_class_get_list(TYPE_MACHINE, false);
+    GSList *el, *machines;
     MachineInfoList *mach_list = NULL;
 
+    machines = object_class_get_list(target_machine_typename(), false);
     for (el = machines; el; el = el->next) {
         MachineClass *mc = el->data;
         const char *default_cpu_type = machine_class_default_cpu_type(mc);
diff --git a/monitor/qemu-config-qmp.c b/monitor/qemu-config-qmp.c
index 9a3b183602d..8bd28fc2328 100644
--- a/monitor/qemu-config-qmp.c
+++ b/monitor/qemu-config-qmp.c
@@ -1,5 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */
 #include "qemu/osdep.h"
+#include "qemu/target-info.h"
 #include "qapi/error.h"
 #include "qapi/qapi-commands-misc.h"
 #include "qobject/qlist.h"
@@ -128,7 +129,7 @@ static CommandLineParameterInfoList *query_all_machine_properties(void)
     ObjectProperty *prop;
     bool is_new;
 
-    machines = object_class_get_list(TYPE_MACHINE, false);
+    machines = object_class_get_list(target_machine_typename(), false);
     assert(machines);
 
     /* Loop over all machine classes */
diff --git a/system/vl.c b/system/vl.c
index 646239e4a69..a96063f9901 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -1672,7 +1672,8 @@ static MachineClass *select_machine(QDict *qdict, Error **errp)
 {
     ERRP_GUARD();
     const char *machine_type = qdict_get_try_str(qdict, "type");
-    g_autoptr(GSList) machines = object_class_get_list(TYPE_MACHINE, false);
+    g_autoptr(GSList) machines = object_class_get_list(target_machine_typename(),
+                                                       false);
     MachineClass *machine_class = NULL;
 
     if (machine_type) {
-- 
2.51.0



  reply	other threads:[~2025-10-20 22:12 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 22:09 [PATCH v6 00/30] single-binary: Make hw/arm/ common Philippe Mathieu-Daudé
2025-10-20 22:09 ` Philippe Mathieu-Daudé [this message]
2025-10-20 23:02   ` [PATCH v6 01/30] hw/core: Filter machine list available for a particular target binary Pierrick Bouvier
2025-10-20 22:09 ` [PATCH v6 02/30] hw/boards: Move DEFINE_MACHINE() definition closer to its doc string Philippe Mathieu-Daudé
2025-10-20 23:02   ` Pierrick Bouvier
2025-10-20 22:09 ` [PATCH v6 03/30] hw/boards: Extend DEFINE_MACHINE macro to cover more use cases Philippe Mathieu-Daudé
2025-10-20 23:03   ` Pierrick Bouvier
2025-10-20 22:09 ` [PATCH v6 04/30] hw/boards: Introduce DEFINE_MACHINE_WITH_INTERFACE_ARRAY() macro Philippe Mathieu-Daudé
2025-10-20 22:09 ` [PATCH v6 05/30] hw/arm: Register TYPE_TARGET_ARM/AARCH64_MACHINE QOM interfaces Philippe Mathieu-Daudé
2025-10-20 22:09 ` [PATCH v6 06/30] hw/core: Allow ARM/Aarch64 binaries to use the 'none' machine Philippe Mathieu-Daudé
2025-10-20 22:09 ` [PATCH v6 07/30] hw/arm: Add DEFINE_MACHINE_[ARM_]AARCH64() macros Philippe Mathieu-Daudé
2025-10-20 22:09 ` [PATCH v6 08/30] hw/arm: Filter machine types for qemu-system-arm/aarch64 binaries Philippe Mathieu-Daudé
2025-10-21  5:41   ` Jan Kiszka
2025-10-21  7:55     ` Philippe Mathieu-Daudé
2025-10-20 22:09 ` [PATCH v6 09/30] qemu/target-info: Include missing 'qapi-types-common.h' header Philippe Mathieu-Daudé
2025-10-20 23:04   ` Pierrick Bouvier
2025-10-20 22:09 ` [PATCH v6 10/30] meson: Prepare to accept per-binary TargetInfo structure implementation Philippe Mathieu-Daudé
2025-10-20 22:13 ` [PATCH 11/30] config/target: Implement per-binary TargetInfo structure (ARM, AARCH64) Philippe Mathieu-Daudé
2025-10-20 22:13 ` [PATCH 12/30] hw/arm/aspeed: Build objects once Philippe Mathieu-Daudé
2025-10-20 22:13 ` [PATCH 13/30] hw/arm/raspi: " Philippe Mathieu-Daudé
2025-10-20 22:13 ` [PATCH 14/30] hw/core/machine: Allow dynamic registration of valid CPU types Philippe Mathieu-Daudé
2025-10-20 22:13 ` [PATCH 15/30] hw/arm/virt: Register valid CPU types dynamically Philippe Mathieu-Daudé
2025-10-20 22:14 ` [PATCH v6 16/30] hw/arm/virt: Check accelerator availability at runtime Philippe Mathieu-Daudé
2025-10-20 22:14 ` [PATCH v6 17/30] qemu/target_info: Add target_arm() helper Philippe Mathieu-Daudé
2025-10-20 23:08   ` Pierrick Bouvier
2025-10-20 22:14 ` [PATCH v6 18/30] qemu/target_info: Add target_aarch64() helper Philippe Mathieu-Daudé
2025-10-20 23:08   ` Pierrick Bouvier
2025-10-20 22:14 ` [PATCH v6 19/30] qemu/target-info: Add target_base_arch() Philippe Mathieu-Daudé
2025-10-20 23:15   ` Pierrick Bouvier
2025-10-21  7:53     ` Philippe Mathieu-Daudé
2025-10-20 22:14 ` [PATCH v6 20/30] qemu/target_info: Add target_base_arm() helper Philippe Mathieu-Daudé
2025-10-20 23:16   ` Pierrick Bouvier
2025-10-20 22:14 ` [PATCH v6 21/30] hw/arm/virt: Replace TARGET_AARCH64 -> target_aarch64() Philippe Mathieu-Daudé
2025-10-20 23:16   ` Pierrick Bouvier
2025-10-20 22:15 ` [PATCH v6 22/30] hw/core: Introduce MachineClass::get_default_cpu_type() helper Philippe Mathieu-Daudé
2025-10-20 22:15 ` [PATCH v6 23/30] hw/arm/virt: Get default CPU type at runtime Philippe Mathieu-Daudé
2025-10-20 23:37   ` Pierrick Bouvier
2025-10-20 22:15 ` [PATCH v6 24/30] hw/arm/sbsa-ref: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2025-10-20 23:38   ` Pierrick Bouvier
2025-10-20 22:20 ` [PATCH v6 25/30] hw/arm/sbsa-ref: Build only once Philippe Mathieu-Daudé
2025-10-20 23:39   ` Pierrick Bouvier
2025-10-20 22:20 ` [PATCH v6 26/30] hw/arm/virt-acpi-build: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2025-10-20 23:40   ` Pierrick Bouvier
2025-10-20 22:20 ` [PATCH v6 27/30] hw/arm/virt-acpi-build: Build only once Philippe Mathieu-Daudé
2025-10-20 23:40   ` Pierrick Bouvier
2025-10-20 22:20 ` [PATCH v6 28/30] hw/arm/virt: " Philippe Mathieu-Daudé
2025-10-20 23:40   ` Pierrick Bouvier
2025-10-20 22:20 ` [PATCH v6 29/30] hw/arm/meson: Move Xen files to arm_common_ss[] Philippe Mathieu-Daudé
2025-10-20 23:41   ` Pierrick Bouvier
2025-10-20 22:20 ` [PATCH v6 30/30] hw/arm/meson: Remove now unused arm_ss[] source set Philippe Mathieu-Daudé
2025-10-20 23:41   ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251020220941.65269-2-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=anjo@rev.ng \
    --cc=clg@kaod.org \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=shentey@gmail.com \
    --cc=wangyanan55@huawei.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).