* [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing
@ 2025-10-21 11:04 Philippe Mathieu-Daudé
2025-10-21 12:32 ` Cédric Le Goater
2025-10-27 19:18 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-10-21 11:04 UTC (permalink / raw)
To: qemu-devel
Cc: Joel Stanley, Cédric Le Goater, qemu-arm, Troy Lee,
Peter Maydell, Andrew Jeffery, Steven Lee, Jamin Lin,
Philippe Mathieu-Daudé
Remove pointless alias to the very same machine:
$ qemu-system-aarch64 -M help | fgrep ast2700fc
ast2700fc ast2700 full core support (alias of ast2700fc)
ast2700fc ast2700 full core support
Fixes: a74faf35efc ("hw/arm: Introduce ASPEED AST2700 A1 full core machine")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/aspeed_ast27x0-fc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/arm/aspeed_ast27x0-fc.c b/hw/arm/aspeed_ast27x0-fc.c
index a61ecff3909..463dd30cc5d 100644
--- a/hw/arm/aspeed_ast27x0-fc.c
+++ b/hw/arm/aspeed_ast27x0-fc.c
@@ -180,7 +180,6 @@ static void ast2700fc_class_init(ObjectClass *oc, const void *data)
{
MachineClass *mc = MACHINE_CLASS(oc);
- mc->alias = "ast2700fc";
mc->desc = "ast2700 full core support";
mc->init = ast2700fc_init;
mc->no_floppy = 1;
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing
2025-10-21 11:04 [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing Philippe Mathieu-Daudé
@ 2025-10-21 12:32 ` Cédric Le Goater
2025-10-27 19:18 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2025-10-21 12:32 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Joel Stanley, qemu-arm, Troy Lee, Peter Maydell, Andrew Jeffery,
Steven Lee, Jamin Lin
On 10/21/25 13:04, Philippe Mathieu-Daudé wrote:
> Remove pointless alias to the very same machine:
>
> $ qemu-system-aarch64 -M help | fgrep ast2700fc
> ast2700fc ast2700 full core support (alias of ast2700fc)
> ast2700fc ast2700 full core support
>
> Fixes: a74faf35efc ("hw/arm: Introduce ASPEED AST2700 A1 full core machine")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/arm/aspeed_ast27x0-fc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/arm/aspeed_ast27x0-fc.c b/hw/arm/aspeed_ast27x0-fc.c
> index a61ecff3909..463dd30cc5d 100644
> --- a/hw/arm/aspeed_ast27x0-fc.c
> +++ b/hw/arm/aspeed_ast27x0-fc.c
> @@ -180,7 +180,6 @@ static void ast2700fc_class_init(ObjectClass *oc, const void *data)
> {
> MachineClass *mc = MACHINE_CLASS(oc);
>
> - mc->alias = "ast2700fc";
> mc->desc = "ast2700 full core support";
> mc->init = ast2700fc_init;
> mc->no_floppy = 1;
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing
2025-10-21 11:04 [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing Philippe Mathieu-Daudé
2025-10-21 12:32 ` Cédric Le Goater
@ 2025-10-27 19:18 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-10-27 19:18 UTC (permalink / raw)
To: qemu-devel
Cc: Joel Stanley, Cédric Le Goater, qemu-arm, Troy Lee,
Peter Maydell, Andrew Jeffery, Steven Lee, Jamin Lin
On 21/10/25 13:04, Philippe Mathieu-Daudé wrote:
> Remove pointless alias to the very same machine:
>
> $ qemu-system-aarch64 -M help | fgrep ast2700fc
> ast2700fc ast2700 full core support (alias of ast2700fc)
> ast2700fc ast2700 full core support
>
> Fixes: a74faf35efc ("hw/arm: Introduce ASPEED AST2700 A1 full core machine")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/arm/aspeed_ast27x0-fc.c | 1 -
> 1 file changed, 1 deletion(-)
Merged as commit d7bd42a740d0e8887540d7b450d0bdb2d6ba31ea, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-27 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-21 11:04 [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing Philippe Mathieu-Daudé
2025-10-21 12:32 ` Cédric Le Goater
2025-10-27 19:18 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).