From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Joel Stanley" <joel@jms.id.au>,
qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"David Hildenbrand" <david@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Troy Lee" <leetroy@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Helge Deller" <deller@gmx.de>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Peter Xu" <peterx@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Jamin Lin" <jamin_lin@aspeedtech.com>
Subject: [PATCH 2/6] hw/display/vga: Log unassigned MMIO accesses with unassigned_mem_ops
Date: Mon, 27 Oct 2025 13:36:39 +0100 [thread overview]
Message-ID: <20251027123644.63487-3-philmd@linaro.org> (raw)
In-Reply-To: <20251027123644.63487-1-philmd@linaro.org>
Replace unassigned_io_ops -> unassigned_mem_ops to log
accesses as MMIO ones.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/display/bochs-display.c | 2 +-
hw/display/vga-pci.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index ad2821c9745..9fa52234219 100644
--- a/hw/display/bochs-display.c
+++ b/hw/display/bochs-display.c
@@ -286,7 +286,7 @@ static void bochs_display_realize(PCIDevice *dev, Error **errp)
memory_region_init_io(&s->qext, obj, &bochs_display_qext_ops, s,
"qemu extended regs", PCI_VGA_QEXT_SIZE);
- memory_region_init_io(&s->mmio, obj, &unassigned_io_ops, NULL,
+ memory_region_init_io(&s->mmio, obj, &unassigned_mem_ops, NULL,
"bochs-display-mmio", PCI_VGA_MMIO_SIZE);
memory_region_add_subregion(&s->mmio, PCI_VGA_BOCHS_OFFSET, &s->vbe);
memory_region_add_subregion(&s->mmio, PCI_VGA_QEXT_OFFSET, &s->qext);
diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c
index b81f7fd2d0f..583f5d5dee6 100644
--- a/hw/display/vga-pci.c
+++ b/hw/display/vga-pci.c
@@ -254,7 +254,7 @@ static void pci_std_vga_realize(PCIDevice *dev, Error **errp)
/* mmio bar for vga register access */
if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_MMIO)) {
- memory_region_init_io(&d->mmio, OBJECT(dev), &unassigned_io_ops, NULL,
+ memory_region_init_io(&d->mmio, OBJECT(dev), &unassigned_mem_ops, NULL,
"vga.mmio", PCI_VGA_MMIO_SIZE);
if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_QEXT)) {
@@ -285,7 +285,7 @@ static void pci_secondary_vga_realize(PCIDevice *dev, Error **errp)
s->con = graphic_console_init(DEVICE(dev), 0, s->hw_ops, s);
/* mmio bar */
- memory_region_init_io(&d->mmio, OBJECT(dev), &unassigned_io_ops, NULL,
+ memory_region_init_io(&d->mmio, OBJECT(dev), &unassigned_mem_ops, NULL,
"vga.mmio", PCI_VGA_MMIO_SIZE);
if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_QEXT)) {
--
2.51.0
next prev parent reply other threads:[~2025-10-27 12:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 12:36 [PATCH 0/6] hw: Log unassigned MMIO accesses with unassigned_mem_ops Philippe Mathieu-Daudé
2025-10-27 12:36 ` [PATCH 1/6] system/memory: Expose unassigned_mem_ops symbol Philippe Mathieu-Daudé
2025-10-27 12:36 ` Philippe Mathieu-Daudé [this message]
2025-10-27 12:36 ` [PATCH 3/6] hw/pci-host/gpex: Log unassigned MMIO accesses with unassigned_mem_ops Philippe Mathieu-Daudé
2025-10-27 12:36 ` [PATCH 4/6] hw/pci-host/aspeed: " Philippe Mathieu-Daudé
2025-10-27 12:36 ` [PATCH 5/6] hw/pci-host/astro: " Philippe Mathieu-Daudé
2025-10-27 12:36 ` [PATCH 6/6] hw/sparc64/ebus: " Philippe Mathieu-Daudé
2025-10-27 13:12 ` [PATCH 0/6] hw: " Alex Bennée
2025-10-27 13:21 ` Philippe Mathieu-Daudé
2025-10-27 13:26 ` Peter Maydell
2025-10-27 13:33 ` Philippe Mathieu-Daudé
2025-10-27 13:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027123644.63487-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=andrew@codeconstruct.com.au \
--cc=atar4qemu@gmail.com \
--cc=clg@kaod.org \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kraxel@redhat.com \
--cc=leetroy@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=steven_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).