From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0265FCCFA04 for ; Mon, 3 Nov 2025 10:14:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFrZS-0005di-KO; Mon, 03 Nov 2025 05:13:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFrZR-0005dL-GR for qemu-arm@nongnu.org; Mon, 03 Nov 2025 05:13:53 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vFrZM-0002zO-QJ for qemu-arm@nongnu.org; Mon, 03 Nov 2025 05:13:52 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-471b80b994bso54840855e9.3 for ; Mon, 03 Nov 2025 02:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762164824; x=1762769624; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZhaKZtIHcKQyEzCs44RThvX4QVJ1Sgd9Tp4DxoQS0nM=; b=elQ3XncFJ1cC0c7CLhV+9zkS56AkVxbfDtfvlc1Fd8fvMFfYnPav+8wxvYDCTWfl59 86RNoRzEPypDZFeVv8PmSdTRV6NTblAO/0A9dSOKLvA3agM2ppuEQOoO1UxwOdtjbtPJ s41VZbG4NuAT0kzW4WMQOgkyGPmdNvu+Ml7ImgOHH13/U4g2dwgyvADxUtxEb9XITJmo 5EMi2JiFnY0J4HAgDTPgRhUasp0hXcLT2+Tu5CU/wyO+PLpoLHH2cl7zXo8fHvzAIDa5 +NhXcJ4VYhl4Njh3NdSFFhxHygQKFXEdmfBAdcUa+n2Rp7ytDfQ6fsCDAxg2rzWjkExW GjhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762164824; x=1762769624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZhaKZtIHcKQyEzCs44RThvX4QVJ1Sgd9Tp4DxoQS0nM=; b=mfVE3nqJaZFJFgXmciP0At5yn6oEH/JkVIW0lB0csfs8NQgyehe+DhPD86GMPeMcxm hOfUvouFwWTKqSyUzotKeU600fUGpnN9Mck0l0gDj0yyIxjba22a0DXuJn1IucYx/Ydy A6ijULzwDBehgX+4o9+hb6AUS8CIO0+UxMePID8kq3mAyuBbNtICtBNeb7y8pNq5l26K YGlNRbM7wazy+KFcTp+YZA7Nt/L7uvIpDnvvlwqloYo5HyD06fn7XAhjIAmUvTnvJp6b 9qtwnlO4jMe0ELQNsmw7VoTEG6PGQquWr+18mhjJrhxmFjiRZwwYwnkor/J+urROS4qT z7/A== X-Forwarded-Encrypted: i=1; AJvYcCUAOJ2bq5YJUfn4ixX21omLCzlH5+O9OxYfkOUAGBK69B03/bgqCcTgaJcIaU/u3xvwFMxU1rCu9g==@nongnu.org X-Gm-Message-State: AOJu0YyONSZrIT14g6lNbicxMcTBHFDO3UuLl/qzsfQURKrb7PHGcOha bAATdeCeFLPH7Gd2naK6X+YZczmhdD1nXw5YOvDWNlCEyT/R53FDtMgC3ozJgUkY6Ks= X-Gm-Gg: ASbGncugYIC4lpciijZGvLfeqffnq4KWlWlDRP/9mHJbofAUVogZ2+fuqKilXFfnIOm oOoKJqT9MvO5lNMCPoIkmTqHSmXVjctHxo+IN9BlB7u9UEJP2XJGowqQTM1JdZ+eBtgjrZWegYZ A8q8L9xennHoSrhsDwupAEMFGzj9v4mzQDM6YKIKnrUphqM7VGanBhZYLVptVI6dgUzTqq6RqwM q7DGmlLLifPabl0Sp25+F5slA+o8skZnf89WZ/dhTrP8dZq4lDEAkGzGaLR48eHwiAzTURL8czT n4BFzJNeg2eHhYaMSbU4j4/PWJU9PZg/cbodQ21ouJffVwFlO5bvpDLlfPp45w7GRUMwSrZjWh0 ET6CvvwGPlaVVLBW+bOYirCIsjiTd0NTas9QNq6AVL2qVWDY6ccXTC5QfvQyoP0bzoeXKbxC1SC p7zs1lPt18bfmqXor3E9ii16iAlf0MY1zGv9vDk1bBpoTFCwbjy07CsBfEj5o= X-Google-Smtp-Source: AGHT+IEOGKIgKnlbDQiyqHsOaaJCd31NLapA+qxZRnHzn1WG4l/u8lZPmyrB01DywGkze+48j6mTTQ== X-Received: by 2002:a05:600c:3e8f:b0:475:dac3:699f with SMTP id 5b1f17b1804b1-477307c1470mr105999275e9.9.1762164824081; Mon, 03 Nov 2025 02:13:44 -0800 (PST) Received: from localhost.localdomain (ip-185-104-138-122.ptr.icomera.net. [185.104.138.122]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4773c3a77b1sm148140115e9.17.2025.11.03.02.13.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 03 Nov 2025 02:13:43 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Roman Bolshakov , Alexander Graf , Phil Dennis-Jordan , qemu-arm@nongnu.org, Paolo Bonzini , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Akihiko Odaki , Peter Collingbourne , Cameron Esfahani , Mads Ynddal , Mohamed Mediouni Subject: [PATCH v4 07/23] accel/hvf: Move hvf_log_sync to hvf_log_clear Date: Mon, 3 Nov 2025 11:10:16 +0100 Message-ID: <20251103101034.59039-8-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251103101034.59039-1-philmd@linaro.org> References: <20251103101034.59039-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org From: Richard Henderson Right idea, wrong hook. log_sync is called before using dirty bit data (which for hvf is already up-to-date), whereas log_clear is called before cleaning the range. Signed-off-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- accel/hvf/hvf-all.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 601e63c7f9a..f203a6251f0 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -224,12 +224,13 @@ static void hvf_log_stop(MemoryListener *listener, } } -static void hvf_log_sync(MemoryListener *listener, - MemoryRegionSection *section) +static void hvf_log_clear(MemoryListener *listener, + MemoryRegionSection *section) { /* - * sync of dirty pages is handled elsewhere; just make sure we keep - * tracking the region. + * The dirty page bits within section are being cleared. + * Some number of those pages may have been dirtied and + * the write permission enabled. Reset the range read-only. */ hvf_protect_clean_range(section->offset_within_address_space, int128_get64(section->size)); @@ -254,7 +255,7 @@ static MemoryListener hvf_memory_listener = { .region_del = hvf_region_del, .log_start = hvf_log_start, .log_stop = hvf_log_stop, - .log_sync = hvf_log_sync, + .log_clear = hvf_log_clear, }; static int hvf_accel_init(AccelState *as, MachineState *ms) -- 2.51.0