From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Jamin Lin" <jamin_lin@aspeedtech.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: [PULL 23/30] hw/arm/aspeed: Make aspeed_machine_ast2600_class_emmc_init() a common API for eMMC boot setup
Date: Tue, 4 Nov 2025 09:31:37 +0100 [thread overview]
Message-ID: <20251104083144.187806-24-clg@redhat.com> (raw)
In-Reply-To: <20251104083144.187806-1-clg@redhat.com>
From: Jamin Lin <jamin_lin@aspeedtech.com>
This commit exposes the function aspeed_machine_ast2600_class_emmc_init() as
a common API so that other AST2600-based machine implementations can reuse it
to enable the "boot-emmc" property.
Previously, this function was defined as a static helper within aspeed.c,
limiting its visibility to that file. By making it global and declaring it in
aspeed.h, other machine definition files (e.g., for specific AST2600 boards)
can now easily call this API to register eMMC boot configuration support.
No functional changes.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20251104031325.146374-24-jamin_lin@aspeedtech.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
include/hw/arm/aspeed.h | 10 ++++++++++
hw/arm/aspeed.c | 2 +-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
index 84620f49ed2d..87dcadab264f 100644
--- a/include/hw/arm/aspeed.h
+++ b/include/hw/arm/aspeed.h
@@ -101,4 +101,14 @@ void aspeed_create_pca9552(AspeedSoCState *soc, int bus_id, int addr);
*/
I2CSlave *aspeed_create_pca9554(AspeedSoCState *soc, int bus_id, int addr);
+/*
+ * aspeed_machine_ast2600_class_emmc_init:
+ * @oc: the #ObjectClass to initialize.
+ *
+ * Initialize eMMC-related properties for the AST2600 Aspeed machine class.
+ * This function is typically invoked during class initialization to set up
+ * default configuration or attach eMMC-specific devices for AST2600 platforms.
+ */
+void aspeed_machine_ast2600_class_emmc_init(ObjectClass *oc);
+
#endif
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 89a463242567..2f385290a419 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -755,7 +755,7 @@ static void aspeed_machine_ast2600_set_boot_from_emmc(Object *obj, bool value,
}
}
-static void aspeed_machine_ast2600_class_emmc_init(ObjectClass *oc)
+void aspeed_machine_ast2600_class_emmc_init(ObjectClass *oc)
{
object_class_property_add_bool(oc, "boot-emmc",
aspeed_machine_ast2600_get_boot_from_emmc,
--
2.51.1
next prev parent reply other threads:[~2025-11-04 8:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 8:31 [PULL 00/30] aspeed queue Cédric Le Goater
2025-11-04 8:31 ` [PULL 01/30] hw/arm/aspeed: Move AspeedMachineState definition to common header for reuse Cédric Le Goater
2025-11-04 8:31 ` [PULL 02/30] hw/arm/aspeed: Make aspeed_machine_class_init_cpus_defaults() globally accessible Cédric Le Goater
2025-11-04 8:31 ` [PULL 03/30] hw/arm/aspeed: Export and rename create_pca9552() for reuse Cédric Le Goater
2025-11-04 8:31 ` [PULL 04/30] hw/arm/aspeed: Rename and export create_pca9554() as aspeed_create_pca9554() Cédric Le Goater
2025-11-04 8:31 ` [PULL 05/30] hw/arm/aspeed: Split FP5280G2 machine into a separate source file for maintenance Cédric Le Goater
2025-11-04 8:31 ` [PULL 06/30] hw/arm/aspeed: Split G220A machine into a separate source file for better maintenance Cédric Le Goater
2025-11-04 8:31 ` [PULL 07/30] hw/arm/aspeed: Split Tiogapass machine into a separate source file for cleanup Cédric Le Goater
2025-11-04 8:31 ` [PULL 08/30] hw/arm/aspeed: Split YosemiteV2 machine into a separate source file for maintainability Cédric Le Goater
2025-11-04 8:31 ` [PULL 09/30] hw/arm/aspeed: Split Witherspoon " Cédric Le Goater
2025-11-04 8:31 ` [PULL 10/30] hw/arm/aspeed: Split Sonorapass " Cédric Le Goater
2025-11-04 8:31 ` [PULL 11/30] hw/arm/aspeed: Split Romulus " Cédric Le Goater
2025-11-04 8:31 ` [PULL 12/30] hw/arm/aspeed: Split Supermicro X11SPI machine into a separate " Cédric Le Goater
2025-11-04 8:31 ` [PULL 13/30] hw/arm/aspeed: Split AST2500 EVB machine into a separate source " Cédric Le Goater
2025-11-04 8:31 ` [PULL 14/30] hw/arm/aspeed: Split Quanta-Q71L " Cédric Le Goater
2025-11-04 8:31 ` [PULL 15/30] hw/arm/aspeed: Split Supermicro X11 " Cédric Le Goater
2025-11-04 8:31 ` [PULL 16/30] hw/arm/aspeed: Split Palmetto " Cédric Le Goater
2025-11-04 8:31 ` [PULL 17/30] hw/arm/aspeed: Move ASPEED_RAM_SIZE() macro to common header for reuse Cédric Le Goater
2025-11-04 8:31 ` [PULL 18/30] hw/arm/aspeed: Split Bletchley machine into a separate source file for maintainability Cédric Le Goater
2025-11-04 8:31 ` [PULL 19/30] hw/arm/aspeed: Split FBY35 BMC " Cédric Le Goater
2025-11-04 8:31 ` [PULL 20/30] hw/arm/aspeed: Split Fuji " Cédric Le Goater
2025-11-04 8:31 ` [PULL 21/30] hw/arm/aspeed: Split QCOM Firework " Cédric Le Goater
2025-11-04 8:31 ` [PULL 22/30] hw/arm/aspeed: Split QCOM DC-SCM V1 " Cédric Le Goater
2025-11-04 8:31 ` Cédric Le Goater [this message]
2025-11-04 8:31 ` [PULL 24/30] hw/arm/aspeed: Split GB200NVL " Cédric Le Goater
2025-11-04 8:31 ` [PULL 25/30] hw/arm/aspeed: Split Rainier " Cédric Le Goater
2025-11-04 8:31 ` [PULL 26/30] hw/arm/aspeed: Split Catalina " Cédric Le Goater
2025-11-04 8:31 ` [PULL 27/30] hw/arm/aspeed: Split AST2600 EVB " Cédric Le Goater
2025-11-04 8:31 ` [PULL 28/30] hw/arm/aspeed: Split AST2700 " Cédric Le Goater
2025-11-04 8:31 ` [PULL 29/30] hw/arm/aspeed: Rename and export connect_serial_hds_to_uarts() as aspeed_connect_serial_hds_to_uarts() Cédric Le Goater
2025-11-04 8:31 ` [PULL 30/30] hw/arm/aspeed: Split AST1030 EVB machine into a separate source file for maintainability Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104083144.187806-24-clg@redhat.com \
--to=clg@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).