From: Mohamed Mediouni <mohamed@unpredictable.fr>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Mohamed Mediouni <mohamed@unpredictable.fr>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Zhao Liu <zhao1.liu@intel.com>,
Roman Bolshakov <rbolshakov@ddn.com>,
Wei Liu <wei.liu@kernel.org>,
Pedro Barbuda <pbarbuda@microsoft.com>,
Phil Dennis-Jordan <phil@philjordan.eu>
Subject: [PATCH v2 1/6] target/i386: emulate: include name of unhandled instruction
Date: Thu, 2 Apr 2026 21:30:59 +0200 [thread overview]
Message-ID: <20260402193104.56331-2-mohamed@unpredictable.fr> (raw)
In-Reply-To: <20260402193104.56331-1-mohamed@unpredictable.fr>
Instead of just the command number, include the instruction name to make debugging easier.
Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>
---
target/i386/emulate/x86_emu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/emulate/x86_emu.c b/target/i386/emulate/x86_emu.c
index 55b1a68eb6..c2da1a133f 100644
--- a/target/i386/emulate/x86_emu.c
+++ b/target/i386/emulate/x86_emu.c
@@ -1399,8 +1399,8 @@ static void init_cmd_handler(void)
bool exec_instruction(CPUX86State *env, struct x86_decode *ins)
{
if (!_cmd_handler[ins->cmd].handler) {
- printf("Unimplemented handler (" TARGET_FMT_lx ") for %d (%x %x)\n",
- env->eip,
+ printf("Unimplemented handler (" TARGET_FMT_lx ") for %s - %d (%x %x)\n",
+ env->eip, decode_cmd_to_string(ins->cmd),
ins->cmd, ins->opcode[0],
ins->opcode_len > 1 ? ins->opcode[1] : 0);
env->eip += ins->len;
--
2.50.1 (Apple Git-155)
next prev parent reply other threads:[~2026-04-02 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 19:30 [PATCH v2 0/6] whpx: i386: x2apic emulation for kernel-irqchip=off, feature probing Mohamed Mediouni
2026-04-02 19:30 ` Mohamed Mediouni [this message]
2026-04-02 19:31 ` [PATCH v2 2/6] whpx: i386: x2apic emulation Mohamed Mediouni
2026-04-02 19:31 ` [PATCH v2 3/6] whpx: i386: wire up feature probing Mohamed Mediouni
2026-04-02 19:31 ` [PATCH v2 4/6] whpx: i386: disable TbFlushHypercalls for emulated LAPIC Mohamed Mediouni
2026-04-02 19:31 ` [PATCH v2 5/6] whpx: i386: enable x2apic by default for user-mode LAPIC Mohamed Mediouni
2026-04-02 19:31 ` [PATCH v2 6/6] whpx: i386: reintroduce enlightenments for Windows 10 Mohamed Mediouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402193104.56331-2-mohamed@unpredictable.fr \
--to=mohamed@unpredictable.fr \
--cc=pbarbuda@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=wei.liu@kernel.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox