QEMU-Arm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Troy Lee" <leetroy@gmail.com>,
	"Kane Chen" <kane_chen@aspeedtech.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Joel Stanley" <joel@jms.id.au>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>
Subject: [PATCH v1 2/3] hw/arm/aspeed_coprocessor: Clarify SCU/SCUIO/FMC fields are shared with PSP SoC to AST2700
Date: Fri, 17 Jul 2026 01:47:04 +0000	[thread overview]
Message-ID: <20260717014701.1683876-3-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260717014701.1683876-1-jamin_lin@aspeedtech.com>

Add a comment above Aspeed27x0CoprocessorState's scu_alias/scuio_alias/
fmc_alias and scu/scuio/fmc fields noting that they are not owned by
the coprocessor: they point at resources owned by the main PSP SoC,
only aliased into this coprocessor's own address space.

No functional change.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 include/hw/arm/aspeed_coprocessor.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/hw/arm/aspeed_coprocessor.h b/include/hw/arm/aspeed_coprocessor.h
index 23c3b97f06..ff359ab532 100644
--- a/include/hw/arm/aspeed_coprocessor.h
+++ b/include/hw/arm/aspeed_coprocessor.h
@@ -49,6 +49,11 @@ struct Aspeed27x0CoprocessorState {
 
     ARMv7MState armv7m;
 
+   /*
+    * SCU, SCUIO and FMC are not owned by this coprocessor: they are
+    * shared with the main PSP SoC, and only aliased into this
+    * coprocessor's own address space here.
+    */
     MemoryRegion scu_alias;
     MemoryRegion scuio_alias;
     MemoryRegion fmc_alias;
-- 
2.43.0


  parent reply	other threads:[~2026-07-17  1:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  1:47 [PATCH v1 0/3] tests/qtest/aspeed: Add Data FIFO qtest coverage for AST2700 SMC Jamin Lin
2026-07-17  1:47 ` [PATCH v1 1/3] tests/qtest/ast2700-smc-test: Add Data FIFO mode test Jamin Lin
2026-07-17  1:47 ` Jamin Lin [this message]
2026-07-17  1:47 ` [PATCH v1 3/3] hw/ssi/aspeed_smc: Bump vmstate version after ASPEED_SMC_R_MAX increase Jamin Lin
2026-07-17  7:24 ` [PATCH v1 0/3] tests/qtest/aspeed: Add Data FIFO qtest coverage for AST2700 SMC Cédric Le Goater
2026-07-17  7:28   ` Jamin Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717014701.1683876-3-jamin_lin@aspeedtech.com \
    --to=jamin_lin@aspeedtech.com \
    --cc=alistair@alistair23.me \
    --cc=andrew@codeconstruct.com.au \
    --cc=clg@kaod.org \
    --cc=farosas@suse.de \
    --cc=joel@jms.id.au \
    --cc=kane_chen@aspeedtech.com \
    --cc=leetroy@gmail.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    --cc=troy_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox