QEMU-Arm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bin.meng@processmission.com>
To: QEMU <qemu-devel@nongnu.org>
Cc: "Alistair Francis" <alistair@alistair23.me>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Gaurav Sharma" <gaurav.sharma_7@nxp.com>,
	"Hao Wu" <wuhaotsh@google.com>,
	"Jamin Lin" <jamin_lin@aspeedtech.com>,
	"Jan Kiszka" <jan.kiszka@web.de>,
	"Jean-Christophe Dubois" <jcd@tribudubois.net>,
	"Joel Stanley" <joel@jms.id.au>,
	"Kane Chen" <kane_chen@aspeedtech.com>,
	"Niek Linnenbank" <nieklinnenbank@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
	"Troy Lee" <leetroy@gmail.com>,
	"Tyrone Ting" <kfting@nuvoton.com>,
	qemu-arm@nongnu.org
Subject: [PATCH v2 00/20] hw/arm: Store the ARM boot info in the machine state
Date: Sun, 16 Aug 2026 21:12:30 +0800	[thread overview]
Message-ID: <20260816131300.51799-1-bin.meng@processmission.com> (raw)


Most ARM board files declare their struct arm_boot_info as a static
object at file scope (or, occasionally, as a function-local static
inside the machine init function). arm_load_kernel() stashes a pointer
to that struct in every CPU and dereferences it from do_cpu_reset() on
each reset, so the boot info conceptually belongs to the machine for the
lifetime of the VM, not to a static object whose ownership is left
implicit.

This is a longstanding leftover pattern: modern machines such as virt,
raspi and xlnx-zcu102 already keep the boot info in their MachineState
subclass. This series converts the remaining machines that still use
a static object, moving the struct into their machine state so that its
lifetime and ownership match how arm_load_kernel() actually uses it.

Changes in v2:

Addressed 2 review comments from Peter:

- All assignments now use individual field writes (e.g.:
  bpms->bootinfo.loader_start = ...). This applies to: collie, cubieboard,
  exynos4, imx8mm-evk, integratorcp, kzm, mcimx7d-sabre, musicpal, npcm7xx,
  npcm8xx, omap_sx1, realview, sabrelite
- The following boards that previously used DEFINE_MACHINE_ARM/AARCH64 now
  use the macro DEFINE_MACHINE_EXTENDED() instead: bananapi_m2u,
  cubieboard, imx8mm-evk, integratorcp, mcimx7d-sabre, musicpal,
  orangepi-pc

Bin Meng (20):
  hw/arm: aspeed: Store boot info in the machine state
  hw/arm: aspeed_ast27x0-fc: Store boot info in the machine state
  hw/arm: bananapi_m2u: Store boot info in the machine state
  hw/arm: collie: Store boot info in the machine state
  hw/arm: cubieboard: Store boot info in the machine state
  hw/arm: exynos4_boards: Store boot info in the board state
  hw/arm: imx25_pdk: Store boot info in the board state
  hw/arm: imx8mm-evk: Store boot info in the machine state
  hw/arm: integratorcp: Store boot info in the machine state
  hw/arm: kzm: Store boot info in the board state
  hw/arm: mcimx7d-sabre: Store boot info in the machine state
  hw/arm: musicpal: Store boot info in the machine state
  hw/arm: npcm7xx: Store boot info in the machine state
  hw/arm: npcm8xx: Store boot info in the machine state
  hw/arm: omap_sx1: Store boot info in the machine state
  hw/arm: orangepi: Store boot info in the machine state
  hw/arm: realview: Store boot info in the machine state
  hw/arm: sabrelite: Store boot info in the machine state
  hw/arm: versatilepb: Store boot info in the machine state
  hw/arm: xilinx_zynq: Store boot info in the machine state

 hw/arm/aspeed.c              | 17 +++++++----------
 hw/arm/aspeed_ast27x0-fc.c   | 13 ++++++-------
 hw/arm/bananapi_m2u.c        | 21 +++++++++++++++------
 hw/arm/collie.c              | 12 +++++-------
 hw/arm/cubieboard.c          | 21 +++++++++++++++------
 hw/arm/exynos4_boards.c      | 26 +++++++++++---------------
 hw/arm/imx25_pdk.c           | 11 +++++------
 hw/arm/imx8mm-evk.c          | 29 +++++++++++++++++++----------
 hw/arm/integratorcp.c        | 22 ++++++++++++++++------
 hw/arm/kzm.c                 | 12 +++++-------
 hw/arm/mcimx7d-sabre.c       | 28 +++++++++++++++++++---------
 hw/arm/musicpal.c            | 21 +++++++++++++++------
 hw/arm/npcm7xx.c             | 28 +++++++++++++---------------
 hw/arm/npcm7xx_boards.c      | 10 +++++-----
 hw/arm/npcm8xx.c             | 28 +++++++++++++---------------
 hw/arm/npcm8xx_boards.c      |  2 +-
 hw/arm/omap_sx1.c            | 19 +++++++++++++------
 hw/arm/orangepi.c            | 22 ++++++++++++++++------
 hw/arm/realview.c            | 27 ++++++++++++++++++---------
 hw/arm/sabrelite.c           | 22 ++++++++++------------
 hw/arm/versatilepb.c         | 16 ++++++++++++----
 hw/arm/xilinx_zynq.c         | 17 ++++++++---------
 include/hw/arm/aspeed.h      |  2 ++
 include/hw/arm/npcm7xx.h     | 10 ++++++++--
 include/hw/arm/npcm8xx.h     | 10 ++++++++--
 include/hw/arm/xilinx_zynq.h |  2 ++
 26 files changed, 267 insertions(+), 181 deletions(-)

---
base-commit: af06b5df2610fe5de6c02d17c17bced9e9f0d47d
branch: cleanup-arm-static-boot-info

-- 
2.53.0



             reply	other threads:[~2026-08-16 13:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-16 13:12 Bin Meng [this message]
2026-08-16 13:12 ` [PATCH v2 01/20] hw/arm: aspeed: Store boot info in the machine state Bin Meng
2026-08-16 14:54   ` Philippe Mathieu-Daudé
2026-08-21  9:23     ` Peter Maydell
2026-08-16 13:12 ` [PATCH v2 02/20] hw/arm: aspeed_ast27x0-fc: " Bin Meng
2026-08-16 14:55   ` Philippe Mathieu-Daudé
2026-08-16 13:12 ` [PATCH v2 03/20] hw/arm: bananapi_m2u: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 04/20] hw/arm: collie: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 05/20] hw/arm: cubieboard: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 06/20] hw/arm: exynos4_boards: Store boot info in the board state Bin Meng
2026-08-16 14:56   ` Philippe Mathieu-Daudé
2026-08-16 13:12 ` [PATCH v2 07/20] hw/arm: imx25_pdk: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 08/20] hw/arm: imx8mm-evk: Store boot info in the machine state Bin Meng
2026-08-16 13:12 ` [PATCH v2 09/20] hw/arm: integratorcp: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 10/20] hw/arm: kzm: Store boot info in the board state Bin Meng
2026-08-16 13:12 ` [PATCH v2 11/20] hw/arm: mcimx7d-sabre: Store boot info in the machine state Bin Meng
2026-08-16 13:12 ` [PATCH v2 12/20] hw/arm: musicpal: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 13/20] hw/arm: npcm7xx: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 14/20] hw/arm: npcm8xx: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 15/20] hw/arm: omap_sx1: " Bin Meng
2026-08-16 14:57   ` Philippe Mathieu-Daudé
2026-08-16 13:12 ` [PATCH v2 16/20] hw/arm: orangepi: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 17/20] hw/arm: realview: " Bin Meng
2026-08-16 13:12 ` [PATCH v2 18/20] hw/arm: sabrelite: " Bin Meng
2026-08-16 15:07   ` Philippe Mathieu-Daudé
2026-08-16 13:12 ` [PATCH v2 19/20] hw/arm: versatilepb: " Bin Meng
2026-08-16 15:06   ` Philippe Mathieu-Daudé
2026-08-21  9:49     ` Peter Maydell
2026-08-16 13:12 ` [PATCH v2 20/20] hw/arm: xilinx_zynq: " Bin Meng
2026-08-21  9:49 ` [PATCH v2 00/20] hw/arm: Store the ARM " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260816131300.51799-1-bin.meng@processmission.com \
    --to=bin.meng@processmission.com \
    --cc=alistair@alistair23.me \
    --cc=andrew@codeconstruct.com.au \
    --cc=clg@kaod.org \
    --cc=edgar.iglesias@gmail.com \
    --cc=gaurav.sharma_7@nxp.com \
    --cc=jamin_lin@aspeedtech.com \
    --cc=jan.kiszka@web.de \
    --cc=jcd@tribudubois.net \
    --cc=joel@jms.id.au \
    --cc=kane_chen@aspeedtech.com \
    --cc=kfting@nuvoton.com \
    --cc=leetroy@gmail.com \
    --cc=nieklinnenbank@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    --cc=strahinja.p.jankovic@gmail.com \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox