From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] target/arm: Don't allow guest to use unimplemented granule sizes
Date: Mon, 3 Oct 2022 06:46:11 -0700 [thread overview]
Message-ID: <223e0624-3a6b-f56a-2563-dbdf120d5c8f@linaro.org> (raw)
In-Reply-To: <CAFEAcA9SzEge=PUKJ4gW71gF14NS8aH3JwHwmpVeDXnd18XvFA@mail.gmail.com>
On 10/3/22 03:28, Peter Maydell wrote:
> I'd assumed you had a reason for using two bools rather than
> an enum in ARMVAParameters, so I left that alone :-)
I think it was because the existing code had variables of those names, so the patch
changed "foo" to "param.foo". :-)
> Putting GranuleSize into ARMVAParameters brings us into the
> area of enums in bitfields, where I'm not sure exactly what
> the standard says or our supported compilers allow as an
> impdef extension.
> GranuleSize gsize : 2;
> seems to work, but is it portable?
I think so. Leastwise, we use those elsewhere. I would certainly expect a warning from
any of our supported compilers if we were to use too few bits for the enum type.
r~
next prev parent reply other threads:[~2022-10-03 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 17:48 [PATCH 0/2] target/arm: Enforce implemented granule size limits Peter Maydell
2022-09-30 17:48 ` [PATCH 1/2] target/arm: Don't allow guest to use unimplemented granule sizes Peter Maydell
2022-09-30 20:14 ` Richard Henderson
2022-10-03 10:28 ` Peter Maydell
2022-10-03 13:46 ` Richard Henderson [this message]
2022-09-30 17:48 ` [PATCH 2/2] docs/system/arm/emulation.rst: Report FEAT_GTG support Peter Maydell
2022-09-30 20:15 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=223e0624-3a6b-f56a-2563-dbdf120d5c8f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).