From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:724b:b0:a35:eedd:80b0 with SMTP id n11csp1301528ejk; Tue, 30 Jan 2024 23:05:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIYLsRhtBNlx5zeiHG9Vr/hZLvZlw+O7IZIrY2pUDf5cnhPPLyeZR2VAN8oYQ4ZTYeutyr X-Received: by 2002:a05:622a:48e:b0:42a:5038:212d with SMTP id p14-20020a05622a048e00b0042a5038212dmr968025qtx.52.1706684729867; Tue, 30 Jan 2024 23:05:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706684729; cv=none; d=google.com; s=arc-20160816; b=jne74jCUf530QpSIFmwcqzhVWfJ7B8oGx+T6/M48PetDppF5m45HOyn9L3PtFYDefj BCCH0EeSOSu6S+J9XgVt23F1Va6f7XUs4T2uK9Bz5qqHNEjT6Y3jOa0/towdxPc8HDvS XUwKyJnjn463BmRvD4Kn+Ms9QBAx/i8w1f2xxqQTP1npvVg91aDdmbxuuAAgtiKjxa5Y 9oynGcg4A0MXX6HhrrMkWdwnE7lH3ns/2uXYmnR6A1g6dSDrOm7J/3q6a3V4TD5VtslZ Kdir37/BVLk1kI9FFyn2k4cP2j8zH6lia8vP7LbIr3F3F5CYH1Xs7X6iY2v3hrl8WbGG kOBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :content-language:in-reply-to:autocrypt:from:references:cc:to :subject:user-agent:mime-version:date:message-id:dkim-signature; bh=8AiSAaNqXgkWTRtyKOM3vJug/vLCC6s8u3kvFj9eyqI=; fh=G2js+fSXD8xK50BIQs9IneEWMqm5TUrYNTbllffcVng=; b=tuI4efngMtf/mp7J+TEKD66nL44m+Q/DI6TfF8d35SVQxvHxh1rbJsoVg03czJcfW0 tdPq32XKHJFylIR02KLCgzRmM1fcd8YDY/dwuIOsO8seQ4O4BRgzQ/9zs05Sz2ZyeGTn W71fzbVJ1yC2DJrtcjwF3klHhUX5sto2jgh35oRkGkiEWJcN6pJYG7wrysfMfTNutIiz BIoOG+BkhITm940lhqvtySxrrAKx9m2rSQNeLQ+9F9OLnkWnxX4pmS1aQ77D/y+AQ9Xn qOg2qvp4qKYAFpAE9AtRM52Z/Y1fO7yCJT0skEzZicJE2FzHBVcHm5BQD1+kFuA22zjH d6UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ONXJsrH4; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w7-20020a05622a134700b0042aa70b5cb1si5943897qtk.47.2024.01.30.23.05.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jan 2024 23:05:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ONXJsrH4; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rV4eO-0008CP-DK; Wed, 31 Jan 2024 02:04:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rV4eN-0008CG-8L for qemu-arm@nongnu.org; Wed, 31 Jan 2024 02:04:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rV4e7-0003Hu-S1 for qemu-arm@nongnu.org; Wed, 31 Jan 2024 02:04:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706684671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8AiSAaNqXgkWTRtyKOM3vJug/vLCC6s8u3kvFj9eyqI=; b=ONXJsrH45nvTvF5UFj4Y12zI4z52ImtxADfZR2NtmplAHtjizqbcjTomhTbXe/32QbpERD 84uo+eeKTseeoNNO+VSUg0roOMP/94t6L/ZVJ0mPH1F8x5aO1gVuWkQr0ne6vfW2BdQkEg A8ZCJXKD3lNTdmTIxzKdJuiO9kGsFa4= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-csg8GyLzOPyTGl8sL-1q5A-1; Wed, 31 Jan 2024 02:04:27 -0500 X-MC-Unique: csg8GyLzOPyTGl8sL-1q5A-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-68c48383676so57135566d6.1 for ; Tue, 30 Jan 2024 23:04:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706684667; x=1707289467; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8AiSAaNqXgkWTRtyKOM3vJug/vLCC6s8u3kvFj9eyqI=; b=vE2pVrZanV6s2AfpSHUkRq5G03cR1QPb5KIg4lUcIjS2DnPtXgB4WC8x2KLwnpwK6J MNf74/PUPjyuFXiwRCJhwH2obWZza2eijBDdWcdy8lLh3f/I5O1rLcJgtX+trF1PNkly w+TwDBW92B4Zvo8BkaNZSmiHP4WZEr/xIaqXWIKokE5ft4nRhQLC/xHZO0El/nxWOAhv A8LXSsyegHEXk4zI5mOVvkmvag6qcFh/jsNafr8AXCjF9AW8AnsPIBAPi1ZRu43QZIpx bldWSDguoCZyFWO8+Iz1ZRFTDVsmek/FXUocJG1wECVIEroAg3GHGd9dI0Zp5yYyGVkJ RJTQ== X-Gm-Message-State: AOJu0Yw/N32MqgzWD49vBUAvRyi0JqaeOH4qzUYmlyBYUQjoFZuPAdOT dV3fxHU9QwN+1R3ZnPAwE2FLV1cu16xx+GbNIKZ8yub9WeUQ2lOsvR8aVXU7Y/PSFGGozkbD6tI je6nqq/IAZ5af28vDR6ddyPI6mdxoLoC1xHqDozDGtkiEY9xWDQ== X-Received: by 2002:a05:620a:3cb:b0:783:d83b:f588 with SMTP id r11-20020a05620a03cb00b00783d83bf588mr683147qkm.17.1706684667275; Tue, 30 Jan 2024 23:04:27 -0800 (PST) X-Received: by 2002:a05:620a:3cb:b0:783:d83b:f588 with SMTP id r11-20020a05620a03cb00b00783d83bf588mr683089qkm.17.1706684667032; Tue, 30 Jan 2024 23:04:27 -0800 (PST) Received: from [192.168.0.9] (ip-109-43-177-196.web.vodafone.de. [109.43.177.196]) by smtp.gmail.com with ESMTPSA id g25-20020ae9e119000000b00783dc97436dsm4212378qkm.13.2024.01.30.23.04.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jan 2024 23:04:26 -0800 (PST) Message-ID: <234093a8-ee10-48e3-be52-4d743e4b51e7@redhat.com> Date: Wed, 31 Jan 2024 08:04:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 26/47] hw/net/lan9118: use qemu_configure_nic_device() To: David Woodhouse , qemu-devel@nongnu.org Cc: Richard Henderson , Beniamino Galvani , Peter Maydell , Strahinja Jankovic , Niek Linnenbank , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Andrew Jeffery , Joel Stanley , Igor Mitsyanko , Jean-Christophe Dubois , Andrey Smirnov , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Rob Herring , Subbaraya Sundeep , Jan Kiszka , Tyrone Ting , Hao Wu , Radoslaw Biernacki , Leif Lindholm , Marcin Juszkiewicz , "Edgar E. Iglesias" , Alistair Francis , Helge Deller , Paolo Bonzini , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Song Gao , Thomas Huth , Laurent Vivier , Huacai Chen , Jiaxun Yang , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Aleksandar Rikalo , Aurelien Jarno , Jason Wang , Jia Liu , Stafford Horne , Mark Cave-Ayland , Nicholas Piggin , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , Bin Meng , Palmer Dabbelt , Weiwei Li , Liu Zhiwei , Magnus Damm , Artyom Tarasenko , Stefano Stabellini , Anthony Perard , Paul Durrant , Max Filippov , qemu-arm@nongnu.org, David Woodhouse References: <20240126173228.394202-1-dwmw2@infradead.org> <20240126173228.394202-27-dwmw2@infradead.org> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240126173228.394202-27-dwmw2@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.292, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: kfRqQyHORMkm On 26/01/2024 18.25, David Woodhouse wrote: > From: David Woodhouse > > Some callers instantiate the device unconditionally, others will do so only > if there is a NICInfo to go with it. This appears to be fairly random, but > preseve the existing behaviour for now. > > Signed-off-by: David Woodhouse > --- > hw/arm/kzm.c | 4 ++-- > hw/arm/mps2.c | 2 +- > hw/arm/realview.c | 6 ++---- > hw/arm/vexpress.c | 4 ++-- > hw/net/lan9118.c | 5 ++--- > include/hw/net/lan9118.h | 2 +- > 6 files changed, 10 insertions(+), 13 deletions(-) Reviewed-by: Thomas Huth