From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] target/arm: Don't allow guest to use unimplemented granule sizes
Date: Fri, 30 Sep 2022 13:14:40 -0700 [thread overview]
Message-ID: <3ebee616-2a99-10b5-0902-d41eccbec1f2@linaro.org> (raw)
In-Reply-To: <20220930174853.2233633-2-peter.maydell@linaro.org>
On 9/30/22 10:48, Peter Maydell wrote:
> @@ -10289,20 +10289,113 @@ static int aa64_va_parameter_tcma(uint64_t tcr, ARMMMUIdx mmu_idx)
> }
> }
>
> +typedef enum GranuleSize {
> + /* Same order as TG0 encoding */
> + Gran4K,
> + Gran64K,
> + Gran16K,
> + GranInvalid,
> +} GranuleSize;
It might be worth using this in ARMVAParameters. Even if you don't do that now, it would
be worth putting this typedef in internals.h.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-09-30 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 17:48 [PATCH 0/2] target/arm: Enforce implemented granule size limits Peter Maydell
2022-09-30 17:48 ` [PATCH 1/2] target/arm: Don't allow guest to use unimplemented granule sizes Peter Maydell
2022-09-30 20:14 ` Richard Henderson [this message]
2022-10-03 10:28 ` Peter Maydell
2022-10-03 13:46 ` Richard Henderson
2022-09-30 17:48 ` [PATCH 2/2] docs/system/arm/emulation.rst: Report FEAT_GTG support Peter Maydell
2022-09-30 20:15 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ebee616-2a99-10b5-0902-d41eccbec1f2@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).