[Qemu-arm] [PATCH 0/5] Fixes for the MAINTAINERS file

[Qemu-arm] [PATCH 0/5] Fixes for the MAINTAINERS file

[Thomas Huth]

I've currently got some update patches to the MAINTAINERS file
floating around, and Paolo asked me to send a PULL request for
them - so here's now the assembled set of patches for a final
review. If there are no objections, I'll send a PULL request in
a couple of days.

Note: I've also included John's patch for the bitmap support here,
since it is related - if that should go through another tree
instead, please let me know.

The m68k update is also a v2 of a patch that I've sent some time ago...
Laurent, please have another look at that one to see whether it is
OK now.

John Snow (1):
  MAINTAINERS: Add Fam and Jsnow for Bitmap support

Thomas Huth (4):
  MAINTAINERS: Add some ARM related files to the corresponding sections
  sparc: Add slavio_misc.c and eccmemctl.c to the MAINTAINERS file
  m68k: Update the 68k sections in the MAINTAINERS file
  MAINTAINERS: Add an entry for the CHRP NVRAM files

 MAINTAINERS | 37 +++++++++++++++++++++++++++++++++++--
 1 file changed, 35 insertions(+), 2 deletions(-)

-- 
1.8.3.1

[Qemu-arm] [PATCH 1/5] MAINTAINERS: Add some ARM related files to the corresponding sections

[Thomas Huth]

The files w/cpu/a*mpcore.c are already assigned to the ARM CPU
section, but the corresponding headers include/hw/cpu/a*mpcore.h
are still missing.

The file hw/*/imx* are already assigned to the i.MX31 machine, but
the corresponding header files include/hw/*/imx* are still missing.

The file hw/misc/arm_integrator_debug.c seems to belong to Integrator
CP, hw/cpu/realview_mpcore.c seems to belong to Real View, and
hw/misc/mst_fpga.c seems to belong to PXA2XX.

And the files hw/misc/zynq* and include/hw/misc/zynq* seem to belong
to the Xilinx Zynq machine.

Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Acked-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 82c814a..d7eef43 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -118,6 +118,7 @@ S: Maintained
 F: target-arm/
 F: hw/arm/
 F: hw/cpu/a*mpcore.c
+F: include/hw/cpu/a*mpcore.h
 F: disas/arm.c
 F: disas/arm-a64.cc
 F: disas/libvixl/
@@ -420,6 +421,7 @@ M: Peter Chubb <peter.chubb@nicta.com.au>
 L: qemu-arm@nongnu.org
 S: Odd fixes
 F: hw/*/imx*
+F: include/hw/*/imx*
 F: hw/arm/kzm.c
 F: include/hw/arm/fsl-imx31.h
 
@@ -428,6 +430,7 @@ M: Peter Maydell <peter.maydell@linaro.org>
 L: qemu-arm@nongnu.org
 S: Maintained
 F: hw/arm/integratorcp.c
+F: hw/misc/arm_integrator_debug.c
 
 Musicpal
 M: Jan Kiszka <jan.kiszka@web.de>
@@ -452,6 +455,7 @@ M: Peter Maydell <peter.maydell@linaro.org>
 L: qemu-arm@nongnu.org
 S: Maintained
 F: hw/arm/realview*
+F: hw/cpu/realview_mpcore.c
 F: hw/intc/realview_gic.c
 F: include/hw/intc/realview_gic.h
 
@@ -464,6 +468,7 @@ F: hw/arm/spitz.c
 F: hw/arm/tosa.c
 F: hw/arm/z2.c
 F: hw/*/pxa2xx*
+F: hw/misc/mst_fpga.c
 F: include/hw/arm/pxa.h
 
 Stellaris
@@ -485,7 +490,8 @@ L: qemu-arm@nongnu.org
 S: Maintained
 F: hw/*/xilinx_*
 F: hw/*/cadence_*
-F: hw/misc/zynq_slcr.c
+F: hw/misc/zynq*
+F: include/hw/misc/zynq*
 X: hw/ssi/xilinx_*
 
 Xilinx ZynqMP
-- 
1.8.3.1

[Qemu-arm] [PATCH 2/5] sparc: Add slavio_misc.c and eccmemctl.c to the MAINTAINERS file

[Thomas Huth]

Both files seem to belong to the Sun4m machine.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index d7eef43..451e7cc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -710,6 +710,8 @@ S: Maintained
 F: hw/sparc/sun4m.c
 F: hw/dma/sparc32_dma.c
 F: hw/dma/sun4m_iommu.c
+F: hw/misc/eccmemctl.c
+F: hw/misc/slavio_misc.c
 F: include/hw/sparc/sparc32_dma.h
 F: include/hw/sparc/sun4m.h
 F: pc-bios/openbios-sparc32
-- 
1.8.3.1

[Qemu-arm] [PATCH v2 3/5] m68k: Update the 68k sections in the MAINTAINERS file

[Thomas Huth]

disas/m68k.c obviously belong to the m68k CPU section in
the MAINTAINERS file, but remove the hw/m68k/ directory
here since it only contains machine (not CPU) related
files, as requested by Laurent. Add the machine related
files to the right machine sections instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 451e7cc..5d8b584 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -148,7 +148,7 @@ M68K
 M: Laurent Vivier <laurent@vivier.eu>
 S: Maintained
 F: target-m68k/
-F: hw/m68k/
+F: disas/m68k.c
 
 MicroBlaze
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
@@ -550,6 +550,7 @@ M68K Machines
 an5206
 S: Orphan
 F: hw/m68k/an5206.c
+F: hw/m68k/mcf5206.c
 
 dummy_m68k
 S: Orphan
@@ -558,6 +559,9 @@ F: hw/m68k/dummy_m68k.c
 mcf5208
 S: Orphan
 F: hw/m68k/mcf5208.c
+F: hw/m68k/mcf_intc.c
+F: hw/char/mcf_uart.c
+F: hw/net/mcf_fec.c
 
 MicroBlaze Machines
 -------------------
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH v2 3/5] m68k: Update the 68k sections in the MAINTAINERS file

[Laurent Vivier]

Le 08/11/2016 à 13:17, Thomas Huth a écrit :
> disas/m68k.c obviously belong to the m68k CPU section in
> the MAINTAINERS file, but remove the hw/m68k/ directory
> here since it only contains machine (not CPU) related
> files, as requested by Laurent. Add the machine related
> files to the right machine sections instead.

I think you can also add include/hw/m68k/mcf.h in the machine section.

Thanks,
Laurent

> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 451e7cc..5d8b584 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -148,7 +148,7 @@ M68K
>  M: Laurent Vivier <laurent@vivier.eu>
>  S: Maintained
>  F: target-m68k/
> -F: hw/m68k/
> +F: disas/m68k.c
>  
>  MicroBlaze
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> @@ -550,6 +550,7 @@ M68K Machines
>  an5206
>  S: Orphan
>  F: hw/m68k/an5206.c
> +F: hw/m68k/mcf5206.c
>  
>  dummy_m68k
>  S: Orphan
> @@ -558,6 +559,9 @@ F: hw/m68k/dummy_m68k.c
>  mcf5208
>  S: Orphan
>  F: hw/m68k/mcf5208.c
> +F: hw/m68k/mcf_intc.c
> +F: hw/char/mcf_uart.c
> +F: hw/net/mcf_fec.c
>  
>  MicroBlaze Machines
>  -------------------
> 

Re: [Qemu-arm] [PATCH v2 3/5] m68k: Update the 68k sections in the MAINTAINERS file

[Thomas Huth]

On 08.11.2016 13:21, Laurent Vivier wrote:
> Le 08/11/2016 à 13:17, Thomas Huth a écrit :
>> disas/m68k.c obviously belong to the m68k CPU section in
>> the MAINTAINERS file, but remove the hw/m68k/ directory
>> here since it only contains machine (not CPU) related
>> files, as requested by Laurent. Add the machine related
>> files to the right machine sections instead.
> 
> I think you can also add include/hw/m68k/mcf.h in the machine section.

That header currently contains prototypes for both, the 5206 and the
5208 machine... and I'd like to avoid adding that twice. We should
likely clean that up one day, but since it's currently orphaned anyway,
it's IMHO not that important to have this listed right now.

 Thomas

Re: [Qemu-devel] [PATCH v2 3/5] m68k: Update the 68k sections in the MAINTAINERS file

[Laurent Vivier]

Le 08/11/2016 à 13:17, Thomas Huth a écrit :
> disas/m68k.c obviously belong to the m68k CPU section in
> the MAINTAINERS file, but remove the hw/m68k/ directory
> here since it only contains machine (not CPU) related
> files, as requested by Laurent. Add the machine related
> files to the right machine sections instead.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

> ---
>  MAINTAINERS | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 451e7cc..5d8b584 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -148,7 +148,7 @@ M68K
>  M: Laurent Vivier <laurent@vivier.eu>
>  S: Maintained
>  F: target-m68k/
> -F: hw/m68k/
> +F: disas/m68k.c
>  
>  MicroBlaze
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> @@ -550,6 +550,7 @@ M68K Machines
>  an5206
>  S: Orphan
>  F: hw/m68k/an5206.c
> +F: hw/m68k/mcf5206.c
>  
>  dummy_m68k
>  S: Orphan
> @@ -558,6 +559,9 @@ F: hw/m68k/dummy_m68k.c
>  mcf5208
>  S: Orphan
>  F: hw/m68k/mcf5208.c
> +F: hw/m68k/mcf_intc.c
> +F: hw/char/mcf_uart.c
> +F: hw/net/mcf_fec.c
>  
>  MicroBlaze Machines
>  -------------------
> 

[Qemu-arm] [PATCH 4/5] MAINTAINERS: Add an entry for the CHRP NVRAM files

[Thomas Huth]

I recently added new files to the source tree that are not
covered by any maintainer yet -- and since every new source
file should have a maintainer nowadays, I volunteer to look
after these files now, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5d8b584..05b1c97 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1093,6 +1093,13 @@ S: Maintained
 F: hw/core/generic-loader.c
 F: include/hw/core/generic-loader.h
 
+CHRP NVRAM
+M: Thomas Huth <thuth@redhat.com>
+S: Maintained
+F: hw/nvram/chrp_nvram.c
+F: include/hw/nvram/chrp_nvram.h
+F: tests/prom-env-test.c
+
 Subsystems
 ----------
 Audio
-- 
1.8.3.1

Re: [Qemu-arm] [PATCH 4/5] MAINTAINERS: Add an entry for the CHRP NVRAM files

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

On Tue, Nov 08, 2016 at 01:17:52PM +0100, Thomas Huth wrote:
> I recently added new files to the source tree that are not
> covered by any maintainer yet -- and since every new source
> file should have a maintainer nowadays, I volunteer to look
> after these files now, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5d8b584..05b1c97 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1093,6 +1093,13 @@ S: Maintained
>  F: hw/core/generic-loader.c
>  F: include/hw/core/generic-loader.h
>  
> +CHRP NVRAM
> +M: Thomas Huth <thuth@redhat.com>
> +S: Maintained
> +F: hw/nvram/chrp_nvram.c
> +F: include/hw/nvram/chrp_nvram.h
> +F: tests/prom-env-test.c
> +
>  Subsystems
>  ----------
>  Audio

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[Qemu-arm] [PATCH 5/5] MAINTAINERS: Add Fam and Jsnow for Bitmap support

[Thomas Huth]

From: John Snow <jsnow@redhat.com>

These files are currently unmaintained.

I'm proposing that Fam and I co-maintain them; under the model that
whomever between us isn't authoring a given series will be responsible
for reviewing it.

Signed-off-by: John Snow <jsnow@redhat.com>
Acked-by: Fam Zheng <famz@redhat.com>
Acked-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 05b1c97..d8575ab 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1158,6 +1158,20 @@ F: block/qapi.c
 F: qapi/block*.json
 T: git git://repo.or.cz/qemu/armbru.git block-next
 
+Dirty Bitmaps
+M: Fam Zheng <famz@redhat.com>
+M: John Snow <jsnow@redhat.com>
+L: qemu-block@nongnu.org
+S: Supported
+F: util/hbitmap.c
+F: block/dirty-bitmap.c
+F: include/qemu/hbitmap.h
+F: include/block/dirty-bitmap.h
+F: tests/test-hbitmap.c
+F: docs/bitmaps.md
+T: git git://github.com/famz/qemu.git bitmaps
+T: git git://github.com/jnsnow/qemu.git bitmaps
+
 Character device backends
 M: Paolo Bonzini <pbonzini@redhat.com>
 S: Maintained
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH 0/5] Fixes for the MAINTAINERS file

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

On Tue, Nov 08, 2016 at 01:17:48PM +0100, Thomas Huth wrote:
> I've currently got some update patches to the MAINTAINERS file
> floating around, and Paolo asked me to send a PULL request for
> them - so here's now the assembled set of patches for a final
> review. If there are no objections, I'll send a PULL request in
> a couple of days.
> 
> Note: I've also included John's patch for the bitmap support here,
> since it is related - if that should go through another tree
> instead, please let me know.
> 
> The m68k update is also a v2 of a patch that I've sent some time ago...
> Laurent, please have another look at that one to see whether it is
> OK now.
> 
> John Snow (1):
>   MAINTAINERS: Add Fam and Jsnow for Bitmap support
> 
> Thomas Huth (4):
>   MAINTAINERS: Add some ARM related files to the corresponding sections
>   sparc: Add slavio_misc.c and eccmemctl.c to the MAINTAINERS file
>   m68k: Update the 68k sections in the MAINTAINERS file
>   MAINTAINERS: Add an entry for the CHRP NVRAM files
> 
>  MAINTAINERS | 37 +++++++++++++++++++++++++++++++++++--
>  1 file changed, 35 insertions(+), 2 deletions(-)
> 
> -- 
> 1.8.3.1
> 
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]