From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:4310:0:0:0:0:0 with SMTP id q16csp2303069lfa; Sat, 5 Jun 2021 15:33:24 -0700 (PDT) X-Received: by 2002:a17:902:ed41:b029:102:d012:e432 with SMTP id y1-20020a170902ed41b0290102d012e432mr10983227plb.61.1622932404570; Sat, 05 Jun 2021 15:33:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622932404; cv=none; d=google.com; s=arc-20160816; b=JhGeRZGhBYmMy0ndciTecSaz02bt/qAj9/ydRyBw131Vnb1t3CWJVuOEMQcSfnetPk 0HENjDb4MZ/urqIMsItfzAnxq6pfsfXeEJN1XZSL7N5QjX1md050uYCk+Dx2Ov2GrEeZ 7gJ/XIpS+d6r6NWvQHo8R0BaGTsdv06SDbuN6L1A5SzYVhe9ZrX0WIln+AOeTx2hjCeW 4rdzmDIqHgWEIUfY+z4yVDlIwM3n9IPw4oJgNGsO/XkryGraxR59TpPFzinCWU98k5Ua jLLd37H4lTkQbrQmzo1HpCVkokXLeSAi0x1JutGjGOJXIoj9AX6jQnwOTcNYcjjuOerb MN8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature; bh=YDHg+VEJV3GItXooMJlAAsagEkuPy0NmAs3cfITCXF4=; b=z6GuLG1GfPr1VowzilmMnk1vtKcEVXI+Q1AYeBTW5X66FgPgxZyt4OpvqX/AjcW7x7 ddpfLTjjaV8eZ/L4wTjbocfaUBmpMH3RaQNWFpRrZvozHPG4OYIVg028T+tJw6XCcQnf RyCJNOWrf0JFv2b0A7xKfG6r5zSQMd2qwzvULxV6MHghvv9vmJAhd9JbMg8J1J2fwC9T i+iSekDLDpXnsAdPoTClxlQ7ihjCa06c5emLQNCEt4RHgHc+6d0fsiFv+AZwtN4hi4Xe JE321NouIMXkJICiiZDVkFTDiBwxrfAeioE5GaXN1RtXgTy1dnH/gmcaUF+/Pj0nQtGi oBxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P0jGAM68; spf=pass (google.com: domain of richard.henderson@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=richard.henderson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id s14sor3042084pfu.16.2021.06.05.15.33.24 for (Google Transport Security); Sat, 05 Jun 2021 15:33:24 -0700 (PDT) Received-SPF: pass (google.com: domain of richard.henderson@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P0jGAM68; spf=pass (google.com: domain of richard.henderson@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=richard.henderson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YDHg+VEJV3GItXooMJlAAsagEkuPy0NmAs3cfITCXF4=; b=P0jGAM687Dg3CppBBP4GLl41VhobcQ20r+QSHZ1g/amunEq0TNAKEIPrF8TciAE2GG jDD/XGMzRH6Ymzcw4sdDHKdBtKUEaw8kzmcN3LquJl0kt06EZAWlKery2eeCVbKtg6HE iUUUym8ycjpWjY17lgYuL8pf22jCUvt6MUaix7GmZNpVp7982YI61tCiPYpH/sSKZ2xP jfPpJV6XG0anh6koOirjJ0nVm9OAJ78O+yLynOSDXEh/AEHFF6LWyAYl5VJWeTogmcwx 3twQ6ZNnu6t4Xb3eec8F37ftXlbnyAto6llsyBgpW4AJn60UGqgB1pR4yf5WZBnbt2+c w0wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YDHg+VEJV3GItXooMJlAAsagEkuPy0NmAs3cfITCXF4=; b=V9vc+ioNwk8/dsroOZTX5PZsVsIJhDxplPxRLXkIxtacsUr/IY5wTFXSzvaALiMeGO bDnBNH+qfESh/l/ao026HtSOE7SYHNsppIW5LoF5RU5cN43Kn/flH0v+mNNWdD538YJj oEfLwvZ0q7mi3PjSnPg7QZV+L21yqA4hkctjXinrwT40iNZ69cDr0NtjtvcVTj53+q/9 AgT6RK27p2Tj3cdKYP39dvS8siZoHx3kC9u/zZIS9vl1WPfYTmE+vKkzl3wAsX6bEQeu 4JZyV6xlh+wwehtFcTyxaYUJre1+Jmx2QmqFaIqWnOKk5VHH4rI0vU1rdZf6B3OBKSTT nx7A== X-Gm-Message-State: AOAM531KXBm+e0LqIj9P6+werQAZB3D/JvhbDoI26i4oDDBBnm/ZPWrt UOV57EGOBZRbXhPMufuBIlYJ9Pmz X-Google-Smtp-Source: ABdhPJzpB7x7n00fXCFTLcuK8d27VCIsglRfnwc/sQbp9mhdffYqFMJOUgHN2/ojA1bAsja07WfVzw== X-Received: by 2002:a65:58c8:: with SMTP id e8mr11370635pgu.20.1622932404099; Sat, 05 Jun 2021 15:33:24 -0700 (PDT) Return-Path: Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id b195sm5102037pga.47.2021.06.05.15.33.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Jun 2021 15:33:23 -0700 (PDT) Subject: Re: [PATCH v16 93/99] meson: Introduce target-specific Kconfig To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Peter Maydell , Michael Rolnik , "Edgar E. Iglesias" , Laurent Vivier , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo , Chris Wulff , Marek Vasut , Stafford Horne , David Gibson , Greg Kurz , Palmer Dabbelt , Alistair Francis , Bin Meng , Yoshinori Sato , David Hildenbrand , Cornelia Huck , Thomas Huth , Mark Cave-Ayland , Artyom Tarasenko , Bastian Koppelmann , Max Filippov , "open list:PowerPC TCG CPUs" , "open list:RISC-V TCG CPUs" , "open list:S390 TCG CPUs" References: <20210604155312.15902-1-alex.bennee@linaro.org> <20210604155312.15902-94-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <56411bc8-ffdf-babb-fc72-63bfb7db5df1@linaro.org> Date: Sat, 5 Jun 2021 15:33:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210604155312.15902-94-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: uZ5Issr8gqvp On 6/4/21 8:53 AM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > Add a target-specific Kconfig. > > Target foo now has CONFIG_FOO defined. > > Two architecture have a particularity, ARM and MIPS: > their 64-bit version include the 32-bit subset. > > Signed-off-by: Philippe Mathieu-Daudé > Message-Id: <20210131111316.232778-6-f4bug@amsat.org> > --- > meson.build | 3 ++- > Kconfig | 1 + > target/Kconfig | 23 +++++++++++++++++++++++ > target/alpha/Kconfig | 2 ++ > target/arm/Kconfig | 6 ++++++ > target/avr/Kconfig | 2 ++ > target/cris/Kconfig | 2 ++ > target/hppa/Kconfig | 2 ++ > target/i386/Kconfig | 5 +++++ > target/lm32/Kconfig | 2 ++ > target/m68k/Kconfig | 2 ++ > target/microblaze/Kconfig | 2 ++ > target/mips/Kconfig | 6 ++++++ > target/moxie/Kconfig | 2 ++ > target/nios2/Kconfig | 2 ++ > target/openrisc/Kconfig | 2 ++ > target/ppc/Kconfig | 5 +++++ > target/riscv/Kconfig | 5 +++++ > target/rx/Kconfig | 2 ++ > target/s390x/Kconfig | 2 ++ > target/sh4/Kconfig | 2 ++ > target/sparc/Kconfig | 5 +++++ > target/tilegx/Kconfig | 2 ++ > target/tricore/Kconfig | 2 ++ > target/unicore32/Kconfig | 2 ++ > target/xtensa/Kconfig | 2 ++ > 26 files changed, 92 insertions(+), 1 deletion(-) > create mode 100644 target/Kconfig > create mode 100644 target/alpha/Kconfig > create mode 100644 target/arm/Kconfig > create mode 100644 target/avr/Kconfig > create mode 100644 target/cris/Kconfig > create mode 100644 target/hppa/Kconfig > create mode 100644 target/i386/Kconfig > create mode 100644 target/lm32/Kconfig > create mode 100644 target/m68k/Kconfig > create mode 100644 target/microblaze/Kconfig > create mode 100644 target/mips/Kconfig > create mode 100644 target/moxie/Kconfig > create mode 100644 target/nios2/Kconfig > create mode 100644 target/openrisc/Kconfig > create mode 100644 target/ppc/Kconfig > create mode 100644 target/riscv/Kconfig > create mode 100644 target/rx/Kconfig > create mode 100644 target/s390x/Kconfig > create mode 100644 target/sh4/Kconfig > create mode 100644 target/sparc/Kconfig > create mode 100644 target/tilegx/Kconfig > create mode 100644 target/tricore/Kconfig > create mode 100644 target/unicore32/Kconfig > create mode 100644 target/xtensa/Kconfig I guess you haven't rebased since unicore, moxie et al were removed? > --- a/meson.build > +++ b/meson.build > @@ -1359,7 +1359,8 @@ foreach target : target_dirs > command: [minikconf, > get_option('default_devices') ? '--defconfig' : '--allnoconfig', > config_devices_mak, '@DEPFILE@', '@INPUT@', > - host_kconfig, accel_kconfig]) > + host_kconfig, accel_kconfig, > + 'CONFIG_' + config_target['TARGET_ARCH'].to_upper() + '=y']) I can understand this, > > config_devices_data = configuration_data() > config_devices = keyval.load(config_devices_mak) > diff --git a/Kconfig b/Kconfig > index d52ebd839b..fb6a24a2de 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -1,5 +1,6 @@ > source Kconfig.host > source backends/Kconfig > source accel/Kconfig > +source target/Kconfig > source hw/Kconfig > source semihosting/Kconfig > diff --git a/target/Kconfig b/target/Kconfig > new file mode 100644 > index 0000000000..a6f719f223 > --- /dev/null > +++ b/target/Kconfig > @@ -0,0 +1,23 @@ > +source alpha/Kconfig > +source arm/Kconfig > +source avr/Kconfig > +source cris/Kconfig > +source hppa/Kconfig > +source i386/Kconfig > +source lm32/Kconfig > +source m68k/Kconfig > +source microblaze/Kconfig > +source mips/Kconfig > +source moxie/Kconfig > +source nios2/Kconfig > +source openrisc/Kconfig > +source ppc/Kconfig > +source riscv/Kconfig > +source rx/Kconfig > +source s390x/Kconfig > +source sh4/Kconfig > +source sparc/Kconfig > +source tilegx/Kconfig > +source tricore/Kconfig > +source unicore32/Kconfig > +source xtensa/Kconfig > diff --git a/target/alpha/Kconfig b/target/alpha/Kconfig > new file mode 100644 > index 0000000000..267222c05b > --- /dev/null > +++ b/target/alpha/Kconfig > @@ -0,0 +1,2 @@ > +config ALPHA > + bool But not these. I guess the whole Kconfig thing is processed unconditionally, and there must be some definition? r~