From: Eric Auger <eric.auger@linaro.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: eric.auger@st.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org, alex.williamson@redhat.com,
alex.bennee@linaro.org, thuth@redhat.com,
crosthwaitepeter@gmail.com, patches@linaro.org,
christoffer.dall@linaro.org, pbonzini@redhat.com,
b.reynal@virtualopensystems.com, suravee.suthikulpanit@amd.com,
thomas.lendacky@amd.com
Subject: Re: [PATCH v2 7/7] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check
Date: Mon, 11 Jan 2016 12:18:59 +0100 [thread overview]
Message-ID: <56938FA3.5070600@linaro.org> (raw)
In-Reply-To: <20160111024554.GD22925@voom.redhat.com>
Hi David,
On 01/11/2016 03:45 AM, David Gibson wrote:
> On Wed, Jan 06, 2016 at 03:13:25PM +0000, Eric Auger wrote:
>> qemu_fdt_setprop self-exists in case of error hence no need to check
>> the returned value.
>>
>> Signed-off-by: Eric Auger <eric.auger@linaro.org>
>
> This change is fine, but in general I'm disinclined to invest too much
> in the qemu interfaces for manipulating flattened trees.
>
> I think our device tree manipulation in qemu is now complicated enough
> that we should move towards using an unflattened (i.e. pointer based)
> DT representation inside qemu, which is generally more suitable for
> complex manipulation.
OK. Is there any user-space library available for un-flattened tree
manipulation? I only found references to kernel unflattened tree
manipulations (drivers/of/fdt.c, include/linux/of.h) and dtc flattree.c.
Besides the indicated direction do I understand correctly that you do
not reject the series?
Best Regards
Eric
>
> That would then get flattened into a blob for the guest in a single
> pass at reset time.
>
next prev parent reply other threads:[~2016-01-11 11:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 15:13 [PATCH v2 0/7] AMD XGBE KVM platform passthrough Eric Auger
2016-01-06 15:13 ` [PATCH v2 1/7] hw/vfio/platform: amd-xgbe device Eric Auger
2016-01-06 15:13 ` [PATCH v2 2/7] device_tree: introduce load_device_tree_from_sysfs Eric Auger
2016-01-06 15:13 ` [PATCH v2 3/7] device_tree: introduce qemu_fdt_node_path Eric Auger
2016-01-11 2:38 ` David Gibson
2016-01-11 10:35 ` Eric Auger
2016-01-12 4:28 ` David Gibson
2016-01-12 17:02 ` Eric Auger
2016-01-12 23:07 ` David Gibson
2016-01-06 15:13 ` [PATCH v2 4/7] device_tree: qemu_fdt_getprop converted to use the error API Eric Auger
2016-01-07 0:20 ` Peter Crosthwaite
2016-01-07 8:50 ` Eric Auger
2016-01-06 15:13 ` [PATCH v2 5/7] hw/arm/sysbus-fdt: helpers for clock node generation Eric Auger
2016-01-11 2:41 ` David Gibson
2016-01-11 10:23 ` Eric Auger
2016-01-06 15:13 ` [PATCH v2 6/7] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation Eric Auger
2016-01-06 15:13 ` [PATCH v2 7/7] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check Eric Auger
2016-01-11 2:45 ` David Gibson
2016-01-11 11:18 ` Eric Auger [this message]
2016-01-12 4:31 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56938FA3.5070600@linaro.org \
--to=eric.auger@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=christoffer.dall@linaro.org \
--cc=crosthwaitepeter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=eric.auger@st.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).