From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.159.19 with SMTP id i19csp2243096lfe; Mon, 18 Jan 2016 18:48:29 -0800 (PST) X-Received: by 10.55.214.76 with SMTP id t73mr35144999qki.98.1453171709454; Mon, 18 Jan 2016 18:48:29 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id n83si34638466qhn.6.2016.01.18.18.48.29 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 18 Jan 2016 18:48:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:34599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLMLM-0000Mk-Vm for alex.bennee@linaro.org; Mon, 18 Jan 2016 21:48:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLMLL-0000Lm-BC for qemu-arm@nongnu.org; Mon, 18 Jan 2016 21:48:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLMLI-0004nC-5d for qemu-arm@nongnu.org; Mon, 18 Jan 2016 21:48:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLMLH-0004n5-W1; Mon, 18 Jan 2016 21:48:24 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 823F014CAB5; Tue, 19 Jan 2016 02:48:22 +0000 (UTC) Received: from [10.72.5.45] (vpn1-5-45.pek2.redhat.com [10.72.5.45]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0J2m7ut012057 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 18 Jan 2016 21:48:12 -0500 To: Peter Maydell References: <1452764448-17953-1-git-send-email-mst@redhat.com> <569C8B29.4040300@redhat.com> <569C9E87.2030001@redhat.com> <569CB702.1060803@redhat.com> From: Jason Wang Message-ID: <569DA3E6.5020407@redhat.com> Date: Tue, 19 Jan 2016 10:48:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: "Michael S. Tsirkin" , Alistair Francis , "qemu-devel@nongnu.org Developers" , Prasad Pandit , Peter Crosthwaite , qemu-arm , =?UTF-8?B?5YiY5Luk?= Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH] cadence_gem: fix buffer overflow X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: JZtUts1dcVly On 01/18/2016 06:06 PM, Peter Maydell wrote: > On 18 January 2016 at 09:57, Jason Wang wrote: >> Thanks for the pointer. >> >> In section 16.1.5, it said >> >> "Jumbo frames are not supported." >> >> So it was in fact not an unimplemented feature? > I have a vague feeling from the last time I looked at something like > this that what often happens is the hardware happily goes on dumping > data out on the wire but this is a violation of the ethernet protocol, > ie a guest error. But I'm no ethernet expert... > > thanks > -- PMM > I think it's a guest error (unless we find a guest/driver that depends on this). Anyway, fixing the buffer overflow should be fine.