From: Marcel Apfelbaum <marcel@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mst@redhat.com,
mark.cave-ayland@ilande.co.uk, agraf@suse.de,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org, leon.alrae@imgtec.com,
aurelien@aurel32.net, rth@twiddle.net
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout
Date: Thu, 14 Jul 2016 18:19:49 +0300 [thread overview]
Message-ID: <5787AD95.3080100@redhat.com> (raw)
In-Reply-To: <c4294e73-88a1-ba9b-9e52-3527b142ae57@redhat.com>
On 07/14/2016 04:51 PM, Thomas Huth wrote:
> On 14.07.2016 15:43, Marcel Apfelbaum wrote:
>> On a slower machine the test can take more than 30 seconds.
>> Increase the timeout to 100 seconds.
>>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>> ---
>> tests/prom-env-test.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c
>> index 6df57d2..7a62857 100644
>> --- a/tests/prom-env-test.c
>> +++ b/tests/prom-env-test.c
>> @@ -30,7 +30,7 @@ static void check_guest_memory(void)
>> int i;
>>
>> /* Poll until code has run and modified memory. Wait at most 30 seconds */
>> - for (i = 0; i < 3000; ++i) {
>> + for (i = 0; i < 10000; ++i) {
>> signature = readl(ADDRESS);
>> if (signature == MAGIC) {
>> break;
>
> Ack, but could you please also update the comment before the for-loop?
>
Sure, I'll take care of it once I'll get comments for the other patches.
Thanks,
Marcel
> Thanks,
> Thomas
>
next prev parent reply other threads:[~2016-07-14 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 13:43 [Qemu-devel] [PATCH 0/7] hw/pci-bus: Fix PCI bus regression on several archs Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout Marcel Apfelbaum
2016-07-14 13:51 ` Thomas Huth
2016-07-14 15:19 ` Marcel Apfelbaum [this message]
2016-07-18 19:34 ` Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 2/7] hw/alpha: fix PCI bus initialization Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 3/7] hw/mips: " Marcel Apfelbaum
2016-07-15 12:31 ` Leon Alrae
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 4/7] hw/apb: " Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 5/7] hw/grackle: " Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 6/7] hw/prep: realize the PCI root bus as part of the prep init Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-arm] [Qemu-devel] [PATCH 7/7] hw/versatile: realize the PCI root bus as part of the versatile init Marcel Apfelbaum
2016-07-15 15:05 ` [Qemu-devel] [PATCH 0/7] hw/pci-bus: Fix PCI bus regression on several archs Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5787AD95.3080100@redhat.com \
--to=marcel@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).