From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3F9ACAC5B0 for ; Fri, 3 Oct 2025 12:49:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4fDg-0005Qg-H0; Fri, 03 Oct 2025 08:49:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4fDe-0005Q7-3l for qemu-arm@nongnu.org; Fri, 03 Oct 2025 08:49:06 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v4fDW-0008Gf-EN for qemu-arm@nongnu.org; Fri, 03 Oct 2025 08:49:05 -0400 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-46e3ea0445fso12025745e9.1 for ; Fri, 03 Oct 2025 05:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759495730; x=1760100530; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eKKpGIFhaAnNKkABrFN8kTPx+B+nseENfrTMzjVqiSw=; b=dXXz3hKZrkUtQEDUCTSDes1uRPqi+bNUgZMW/3JD32KZt7sqbBzGdpG2UJKNiwc4zr ItcrvEUy6S8VahAMRnGYFAfRENkOeMs+67Bz2T2RGyyTgUXkcc0VUdPM1KMMNG0zzSXQ ffvWW8kAP7Rg4HPjfJT5ve/Y9m8tin6VRojTbfiFniDnLDt6EhRuWKZltp6hzcCUywDk wnRlcULdaZFXigt0LcBDqeiq6SuuC7Lby3lwXKkKSRCRRryJn7AWzGjvruMcA+Waz4ov 42YHVMCBdX0nHAFv1Nr/ar0huqSsAA5VTg9priPGXNBrroIqIwEkUq8OBu1Xy2eZMM1O RDJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759495730; x=1760100530; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eKKpGIFhaAnNKkABrFN8kTPx+B+nseENfrTMzjVqiSw=; b=ZFSKAsmYlNyx36BVtmbu2sTAEYjYxLfL4iU2FMxunjc5qKgAghtopNrti5zuePVCx9 /mk5ElAQql47oKKxKqX3hgBGV0qBAy8jtfZXdZS3f+0Rf45ISGPl5/wwjkLMXf2okBG2 RrFfZSPUNqjotFIGDMYaChkawEUfefjHs+0vuhZQ6QAXLmharRwjS5qylZzQnyaDLYt1 7yFTfEulkSaXpkIpphidB6g4DAnBUJij5xjQs0SV0FiOMyTleECAHyX/SLukPBfZ4U3z MSBXM5T7x7TAY3vCXKH2pW5T7DmXuqOEOxXMreMk9yNTz5hNowfBd1QBbOcF+2HcIfdc gaGw== X-Forwarded-Encrypted: i=1; AJvYcCWpGCOv2+31F98pjT5EeNJ7wAAN9Fr3/4Nl7h4dGRHBIyAsUfSUzj/fWd4YKuP34ekGHVu5oPFtdA==@nongnu.org X-Gm-Message-State: AOJu0YwvaiH+78zQE14QjJo62OJ+mydJ0EI+eqKR/D52c8hL6LynswbQ 3KoJ1uG1XaBP1o1wa4r7Guu8MbW9MiBQmu9nupbiYE9lNQTeWslklHuo+q5x+/RguIQ= X-Gm-Gg: ASbGnctOXqLejlxWlw3w9gM18wGC9R0xkgKRMrjjKfOiYOUJtVOrL88vFNZrSL3pn3p kryKypt2Af/rPnneZUQWJgTi6dUSsL4WBMCLAK66tZAYf5IY1C96pokuD6Qs/7NqTNjhHI23iN7 82EsB/yTKfK7jgbITCZYINt+LIU9Dg1JptQRkm7jJ8g7VuPX0gYcywB+fE94T+QM/M4JxiDRoCB XMxAwYhYHMfcokG7EKj89fX3hNoNzRll2gpc0FTNBfVo5e534lup9lBdBM3G7V0yzNDYigWJSCS HOZ3CObqbmw4cu08fhVcZmjN80TA/MMzft/J4lIPBlz2Mjd652vZf6ivu5ZmofE8FHUQ7OMs8lp BDrXmVqg51OZjoJO6pEAxfjLkOxL4Zkkc3Es2DhcX3oI8qokIqx1eVuPpY2W32rWkjbZu5fumS3 qqBiu1gdPoidUcdgYj7NX8ziL4i7BL X-Google-Smtp-Source: AGHT+IG60jcQp3Q/xg2SqRGH8uGsUJfDOpxtD+AuoUQpUS70sf8/droB/XiW0ECZtWcZFJ5dNN+Thw== X-Received: by 2002:a05:600c:a343:b0:459:d451:3364 with SMTP id 5b1f17b1804b1-46e71144103mr21838005e9.24.1759495729865; Fri, 03 Oct 2025 05:48:49 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8e9890sm7950209f8f.32.2025.10.03.05.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Oct 2025 05:48:49 -0700 (PDT) Message-ID: <6a015f1e-f298-4218-8ed7-d590bcc15ab1@linaro.org> Date: Fri, 3 Oct 2025 14:48:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] aspeed: Don't set 'auto_create_sdcard' Content-Language: en-US To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley References: <20251003103024.1863551-1-clg@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20251003103024.1863551-1-clg@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philmd@linaro.org; helo=mail-wm1-x342.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 3/10/25 12:30, Cédric Le Goater wrote: > The Aspeed machines inherited from a 'no_sdcard' attribute when first > introduced in QEMU. This attribute was later renamed to > 'auto_create_sdcard' by commit cdc8d7cadaac ("hw/boards: Rename > no_sdcard -> auto_create_sdcard") and set to 'true'. This has the > indesirable efect to automatically create SD cards at init time. > > Remove 'auto_create_sdcard' to avoid creating a SD card device. > > Cc: Philippe Mathieu-Daudé > Link: https://lore.kernel.org/qemu-devel/20250930142448.1030476-1-clg@redhat.com > Signed-off-by: Cédric Le Goater > --- > hw/arm/aspeed.c | 22 ---------------------- > 1 file changed, 22 deletions(-) Reviewed-by: Philippe Mathieu-Daudé