From: Dmitry Osipenko <digetx@gmail.com>
To: QEMU Developers <qemu-devel@nongnu.org>, qemu-arm@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <crosthwaitepeter@gmail.com>
Subject: [Qemu-arm] [PATCH v12 7/9] hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active timer
Date: Sat, 30 Jan 2016 19:43:16 +0300 [thread overview]
Message-ID: <77d17ad13f7b20deb433ca7a7b3d7cf40429665e.1454169735.git.digetx@gmail.com> (raw)
In-Reply-To: <cover.1454169735.git.digetx@gmail.com>
In-Reply-To: <cover.1454169735.git.digetx@gmail.com>
Due to rounding down performed by ptimer_get_count, it returns counter - 1 for
the active timer. That's incorrect because counter should decrement only after
period been expired, not before. I.e. if running timer has been loaded with
value X, then timer counter should stay with X until period expired and
decrement after. Fix this by adding 1 to the counter value for the active and
unexpired timer.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
hw/core/ptimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
index 62f8cb1..b2044fb 100644
--- a/hw/core/ptimer.c
+++ b/hw/core/ptimer.c
@@ -136,7 +136,7 @@ uint64_t ptimer_get_count(ptimer_state *s)
if ((uint32_t)(period_frac << shift))
div += 1;
}
- counter = rem / div;
+ counter = rem / div + (expired ? 0 : 1);
if (expired && counter != 0) {
/* Wrap around periodic counter. */
--
2.7.0
next prev parent reply other threads:[~2016-01-30 16:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 16:43 [Qemu-devel] [PATCH v12 0/9] PTimer fixes/features and ARM MPTimer conversion Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 1/9] hw/ptimer: Fix issues caused by the adjusted timer limit value Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-arm] [PATCH v12 2/9] hw/ptimer: Perform counter wrap around if timer already expired Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-arm] [PATCH v12 3/9] hw/ptimer: Update .delta on period/freq change Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-arm] [PATCH v12 4/9] hw/ptimer: Support "on the fly" timer mode switch Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 5/9] hw/ptimer: Introduce ptimer_get_limit Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 6/9] hw/ptimer: Legalize running with delta = load = 0 and abort on period = 0 Dmitry Osipenko
2016-01-30 16:43 ` Dmitry Osipenko [this message]
2016-02-02 15:19 ` [Qemu-arm] [PATCH v12 7/9] hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active timer Dmitry Osipenko
2016-02-02 15:24 ` Dmitry Osipenko
2016-03-08 3:43 ` Peter Crosthwaite
2016-03-08 19:11 ` Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 8/9] hw/ptimer: Perform delayed tick instead of immediate if delta = 0 Dmitry Osipenko
2016-03-08 21:08 ` [Qemu-arm] " Peter Crosthwaite
2016-03-09 19:56 ` Dmitry Osipenko
2016-03-16 18:34 ` Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 9/9] arm_mptimer: Convert to use ptimer Dmitry Osipenko
2016-03-08 21:03 ` [Qemu-arm] " Peter Crosthwaite
2016-03-16 14:36 ` [Qemu-arm] [PATCH v12 0/9] PTimer fixes/features and ARM MPTimer conversion Peter Maydell
2016-03-16 15:33 ` Dmitry Osipenko
2016-03-28 13:22 ` Dmitry Osipenko
2016-03-29 19:00 ` [Qemu-arm] [Qemu-devel] " Peter Maydell
2016-03-29 20:17 ` Dmitry Osipenko
2016-05-24 16:20 ` [Qemu-arm] " Peter Maydell
2016-05-24 17:15 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d17ad13f7b20deb433ca7a7b3d7cf40429665e.1454169735.git.digetx@gmail.com \
--to=digetx@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).