From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99075C87FCA for ; Thu, 31 Jul 2025 21:27:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uhanV-0006DW-ST; Thu, 31 Jul 2025 17:26:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhaU1-0004xx-MK for qemu-arm@nongnu.org; Thu, 31 Jul 2025 17:06:37 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uhaU0-0004Ia-1z for qemu-arm@nongnu.org; Thu, 31 Jul 2025 17:06:37 -0400 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-b390136ed88so767434a12.2 for ; Thu, 31 Jul 2025 14:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753995994; x=1754600794; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XuAq1KTK/G4AkOm78fXnI9JtAWLzT47y9hX7qWh0Lb0=; b=qAWO/0JSn4btH6xOFPEiiKH8j8sW57jilJKAmoJoFDHoeG2LV8dsur7ra8fVvAgYOR XbTD0LwBDQQN/ezNzHkR5M7PPMX7m93e5PqjD2IPa9I1CdY2be4P5pPSBVaU9vYIrmdn HVais9RcoROTftuUfInZFZiQnWoj9am6UV90FRg+YqW29VczriR3B1/Ey/4ZQvllfyHe gzgyh6a0RHXW7NYB5NeZ/1XYMtDiQWpT2jpVA5ryvSgFaqemXSzkm5oS5qRNL2Zz3VEU 9gVwq2RCSKNqvjTLzsiRdW51WkRscukGxlhQ0gB80CqoCB/QI4fmzLuoPGABL+QNDr63 XneA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753995994; x=1754600794; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XuAq1KTK/G4AkOm78fXnI9JtAWLzT47y9hX7qWh0Lb0=; b=kFaiHKoWR7R2C8+MEFVQ1FHfXXCyGx22n4TQZVTBSRpg0895GuUzB3GUr4PWxXZm3r H63dJ78uJ/JRY/Br5CD1dqCUwWW31j2CiMw7CXxG3wkibJW8L9Pc+wkVI2KGPQ/JbvZb 8AhPDssUedLKgzjcXhNf7wOBlhcrqrSg3JXB8L2miwDLW09VnPeCKXEoGBSr/ZZ4paL2 kg7AmO64mlHu8Vm0+42jj58sWfZj0VDQzeW0JqFyjL1udfTCWqvYjozi7fbeEH6VHkU5 ILH6ZFBXxGloEfSJnltoIB0c4PjsSzNZ7xKy7JAcGjrCf6Iac/sCRlRwgG8h3URPfHMz bS/A== X-Gm-Message-State: AOJu0Yz8HZnaGwxmRWAnSz1KsNwG8+osG3UsFLlaA/c8jTtksV77RZvp 5CihKllnObmEw3StnfLM9AC4/7BaXSYeDIDfeo3WtzaLxC6cmpk5cc/iJS3CTWN9OwI= X-Gm-Gg: ASbGnct6P+mY2iNl70KEmKZVxNb089t52wJbkqbe9sUF30NYqupqcx7JuaJG1FqwYvZ EgsEpW1OupBF64ogvIBGhxcMGKQI2VGUgQ8GynpZpsV9HIjUxzjLizRBoJT0jkR6NTDXeeMVDCj cqItIqKiobVeNGTps34d+ZGFFZAwlX7Ch3ZqWeJWoyAtQ0u9AShdoa3AR7eYGsk+dl7WE4kT6Uu I829skO63qF0pORWUv67ijBb36MtV9P6vagDB/reQcX05GWtPGZWV+VNEquBPQh5RDglBKCxYHC a3dvPUQ458JTcBtB7MzR8khCFf7H6KQ5WwhtgWusFKgNmXf/iM7Cl+kZvJt+QqJ7s8gkog2usIO K/vFq4nFlh59q+Z4auLoNqSxqinJViRXVhNU= X-Google-Smtp-Source: AGHT+IH8UEtYFa2PQBqHiG17v5BAz5LPh0mAqz63ndCBKoqIlBzrLcUFETWuEhP/ByE6Y77daHlgbw== X-Received: by 2002:a17:902:fc50:b0:240:2efe:c384 with SMTP id d9443c01a7336-24096aa7f5emr109094365ad.19.1753995994426; Thu, 31 Jul 2025 14:06:34 -0700 (PDT) Received: from [192.168.1.87] ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241d1ef66fdsm25920015ad.38.2025.07.31.14.06.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 14:06:33 -0700 (PDT) Message-ID: <7ffd2eeb-ae68-43a7-a45a-ec05ece0b71b@linaro.org> Date: Thu, 31 Jul 2025 14:06:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 50/82] target/arm: Split {arm,core}_user_mem_index Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org References: <20250727080254.83840-1-richard.henderson@linaro.org> <20250727080254.83840-51-richard.henderson@linaro.org> From: Pierrick Bouvier In-Reply-To: <20250727080254.83840-51-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 7/27/25 1:02 AM, Richard Henderson wrote: > Separate current to unpriv and arm to core mmu conversions > into two separate functions. > > Signed-off-by: Richard Henderson > --- > target/arm/tcg/translate-a64.c | 24 +++++++++++++++--------- > 1 file changed, 15 insertions(+), 9 deletions(-) If I followed correctly, we replaced all calls to get_a64_user_mem_index by core_user_mem_index. Thus, why not rename directly the function get_a64_user_mem_index in core_user_mem_index? Reviewed-by: Pierrick Bouvier