From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m11sm20398490wmc.15.2021.02.01.04.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 04:03:42 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 718201FF7E; Mon, 1 Feb 2021 12:03:41 +0000 (GMT) References: <20210131111316.232778-1-f4bug@amsat.org> <20210131111316.232778-11-f4bug@amsat.org> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , Sarah Harris , Max Filippov , qemu-block@nongnu.org, "Michael S. Tsirkin" , Eduardo Habkost , Laurent Vivier , Yoshinori Sato , qemu-s390x@nongnu.org, Richard Henderson , Anthony Green , Kevin Wolf , Max Reitz , Chris Wulff , Guan Xuetao , qemu-riscv@nongnu.org, David Hildenbrand , qemu-arm@nongnu.org, Marcel Apfelbaum , Mark Cave-Ayland , Michael Walle , Greg Kurz , qemu-ppc@nongnu.org, Peter Maydell , Stafford Horne , Cornelia Huck , Marek Vasut , Aleksandar Rikalo , Sagar Karandikar , Bastian Koppelmann , Jiaxun Yang , "Edgar E. Iglesias" , Thomas Huth , Artyom Tarasenko , =?utf-8?Q?Mar?= =?utf-8?Q?c-Andr=C3=A9?= Lureau , Palmer Dabbelt , Michael Rolnik , Aurelien Jarno , Alistair Francis , David Gibson Subject: Re: [PATCH 10/10] target: Move SEMIHOSTING feature to target Kconfig Date: Mon, 01 Feb 2021 11:56:08 +0000 In-reply-to: <20210131111316.232778-11-f4bug@amsat.org> Message-ID: <8735ygvvtu.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: 2ZxpSmiMtH3L Philippe Mathieu-Daud=C3=A9 writes: > SEMIHOSTING is an architecture feature, move its declaration to > each target/ARCH/. I'm going to punt on this one and leave it to the arch maintainers to opine because AIUI in a lot of cases semihosting is more of a "useful hack" than something mandated by the architecture. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > default-configs/devices/lm32-softmmu.mak | 2 -- > default-configs/devices/m68k-softmmu.mak | 2 -- > default-configs/devices/mips-softmmu-common.mak | 3 --- > default-configs/devices/nios2-softmmu.mak | 2 -- > default-configs/devices/unicore32-softmmu.mak | 1 - > default-configs/devices/xtensa-softmmu.mak | 2 -- > target/lm32/Kconfig | 1 + > target/m68k/Kconfig | 1 + > target/mips/Kconfig | 1 + > target/nios2/Kconfig | 1 + > target/unicore32/Kconfig | 1 + > target/xtensa/Kconfig | 1 + > 12 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/default-configs/devices/lm32-softmmu.mak b/default-configs/d= evices/lm32-softmmu.mak > index 1bce3f6e8b6..1f69795b749 100644 > --- a/default-configs/devices/lm32-softmmu.mak > +++ b/default-configs/devices/lm32-softmmu.mak > @@ -4,8 +4,6 @@ > # > #CONFIG_MILKYMIST_TMU2=3Dn # disabling it actually causes compile= -time failures >=20=20 > -CONFIG_SEMIHOSTING=3Dy > - > # Boards: > # > CONFIG_LM32_EVR=3Dy > diff --git a/default-configs/devices/m68k-softmmu.mak b/default-configs/d= evices/m68k-softmmu.mak > index 6629fd2aa33..4fef4bd731d 100644 > --- a/default-configs/devices/m68k-softmmu.mak > +++ b/default-configs/devices/m68k-softmmu.mak > @@ -1,7 +1,5 @@ > # Default configuration for m68k-softmmu >=20=20 > -CONFIG_SEMIHOSTING=3Dy > - > # Boards: > # > CONFIG_AN5206=3Dy > diff --git a/default-configs/devices/mips-softmmu-common.mak b/default-co= nfigs/devices/mips-softmmu-common.mak > index ea78fe72759..af652ec7bdd 100644 > --- a/default-configs/devices/mips-softmmu-common.mak > +++ b/default-configs/devices/mips-softmmu-common.mak > @@ -1,8 +1,5 @@ > # Common mips*-softmmu CONFIG defines >=20=20 > -# CONFIG_SEMIHOSTING is always required on this architecture > -CONFIG_SEMIHOSTING=3Dy > - > CONFIG_ISA_BUS=3Dy > CONFIG_PCI=3Dy > CONFIG_PCI_DEVICES=3Dy > diff --git a/default-configs/devices/nios2-softmmu.mak b/default-configs/= devices/nios2-softmmu.mak > index 1bc4082ea99..e130d024e62 100644 > --- a/default-configs/devices/nios2-softmmu.mak > +++ b/default-configs/devices/nios2-softmmu.mak > @@ -1,7 +1,5 @@ > # Default configuration for nios2-softmmu >=20=20 > -CONFIG_SEMIHOSTING=3Dy > - > # Boards: > # > CONFIG_NIOS2_10M50=3Dy > diff --git a/default-configs/devices/unicore32-softmmu.mak b/default-conf= igs/devices/unicore32-softmmu.mak > index 899288e3d71..0bfce48c6da 100644 > --- a/default-configs/devices/unicore32-softmmu.mak > +++ b/default-configs/devices/unicore32-softmmu.mak > @@ -3,4 +3,3 @@ > # Boards: > # > CONFIG_PUV3=3Dy > -CONFIG_SEMIHOSTING=3Dy > diff --git a/default-configs/devices/xtensa-softmmu.mak b/default-configs= /devices/xtensa-softmmu.mak > index 4fe1bf00c94..49e4c9da88c 100644 > --- a/default-configs/devices/xtensa-softmmu.mak > +++ b/default-configs/devices/xtensa-softmmu.mak > @@ -1,7 +1,5 @@ > # Default configuration for Xtensa >=20=20 > -CONFIG_SEMIHOSTING=3Dy > - > # Boards: > # > CONFIG_XTENSA_SIM=3Dy > diff --git a/target/lm32/Kconfig b/target/lm32/Kconfig > index 09de5b703a3..286710fd47b 100644 > --- a/target/lm32/Kconfig > +++ b/target/lm32/Kconfig > @@ -1,2 +1,3 @@ > config LM32 > bool > + select SEMIHOSTING > diff --git a/target/m68k/Kconfig b/target/m68k/Kconfig > index 23debad519a..9eae71486ff 100644 > --- a/target/m68k/Kconfig > +++ b/target/m68k/Kconfig > @@ -1,2 +1,3 @@ > config M68K > bool > + select SEMIHOSTING > diff --git a/target/mips/Kconfig b/target/mips/Kconfig > index 6adf1453548..eb19c94c7d4 100644 > --- a/target/mips/Kconfig > +++ b/target/mips/Kconfig > @@ -1,5 +1,6 @@ > config MIPS > bool > + select SEMIHOSTING >=20=20 > config MIPS64 > bool > diff --git a/target/nios2/Kconfig b/target/nios2/Kconfig > index 1529ab8950d..c65550c861a 100644 > --- a/target/nios2/Kconfig > +++ b/target/nios2/Kconfig > @@ -1,2 +1,3 @@ > config NIOS2 > bool > + select SEMIHOSTING > diff --git a/target/unicore32/Kconfig b/target/unicore32/Kconfig > index 62c9d10b38f..c699d5238ea 100644 > --- a/target/unicore32/Kconfig > +++ b/target/unicore32/Kconfig > @@ -1,2 +1,3 @@ > config UNICORE32 > bool > + select SEMIHOSTING > diff --git a/target/xtensa/Kconfig b/target/xtensa/Kconfig > index a3c8dc7f6d7..5e46049262d 100644 > --- a/target/xtensa/Kconfig > +++ b/target/xtensa/Kconfig > @@ -1,2 +1,3 @@ > config XTENSA > bool > + select SEMIHOSTING --=20 Alex Benn=C3=A9e