From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: cota@braap.org, famz@redhat.com, berrange@redhat.com,
richard.henderson@linaro.org, balrogg@gmail.com,
aurelien@aurel32.net, agraf@suse.de,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, "open list\:ARM" <qemu-arm@nongnu.org>
Subject: Re: [PATCH v4 27/49] tests/tcg: enable building for ARM
Date: Fri, 18 May 2018 16:48:44 +0100 [thread overview]
Message-ID: <87fu2pdkwz.fsf@linaro.org> (raw)
In-Reply-To: <13cbc8f7-ed4b-e302-3a6c-b8791a21047b@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> On 05/17/2018 02:46 PM, Alex Bennée wrote:
>> This allows us to use the docker cross compiler image to build these
>> tests.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> tests/tcg/arm/Makefile.include | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> create mode 100644 tests/tcg/arm/Makefile.include
>>
>> diff --git a/tests/tcg/arm/Makefile.include b/tests/tcg/arm/Makefile.include
>> new file mode 100644
>> index 0000000000..8e7eac008f
>> --- /dev/null
>> +++ b/tests/tcg/arm/Makefile.include
>> @@ -0,0 +1,8 @@
>> +# Makefile.include for all ARM targets
>> +#
>> +# We don't have any bigendian build tools so we only use this for armhf
>> +
>> +ifeq ($(TARGET_NAME),arm)
>> +DOCKER_IMAGE=debian-armhf-cross
>
> [Note for a later series:]
> Since this image comes with ARMv7 libraries, I find clearer to rename as
> arm32v7, following new Docker scheme. This will ease to add arm32v6 (and
> arm32v5 if possible...)
I'm not sure if that is worthwhile. Any linux-user build will be ARMv7
or v8 AArch32 and the compilers can always be set to older CPU types.
Testing that we have correct UNDEF behaviour for older CPUs is probably
better handled by things like RISU?
>
>> +DOCKER_CROSS_COMPILER=arm-linux-gnueabihf-gcc
>> +endif
>>
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
--
Alex Bennée
next prev parent reply other threads:[~2018-05-18 15:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180517174718.10107-1-alex.bennee@linaro.org>
2018-05-17 17:46 ` [PATCH v4 26/49] tests/tcg: move ARM specific tests into subdir Alex Bennée
2018-05-18 15:26 ` Philippe Mathieu-Daudé
2018-05-18 15:58 ` Alex Bennée
2018-05-17 17:46 ` [PATCH v4 27/49] tests/tcg: enable building for ARM Alex Bennée
2018-05-18 15:28 ` Philippe Mathieu-Daudé
2018-05-18 15:48 ` Alex Bennée [this message]
2018-05-17 17:46 ` [PATCH v4 28/49] tests/tcg/arm: fix up test-arm-iwmmxt test Alex Bennée
2018-05-17 20:15 ` Richard Henderson
2018-05-17 17:46 ` [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test Alex Bennée
2018-05-17 20:20 ` Richard Henderson
2018-05-17 21:24 ` Alex Bennée
2018-05-17 21:34 ` Richard Henderson
2018-05-18 3:47 ` Philippe Mathieu-Daudé
2018-05-17 17:46 ` [PATCH v4 30/49] tests/tcg: enable building for AArch64 Alex Bennée
2018-05-17 20:26 ` Richard Henderson
2018-05-18 14:57 ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [PATCH v4 31/49] tests/tcg/aarch64: add Makefile.target Alex Bennée
2018-05-17 20:28 ` Richard Henderson
2018-05-17 21:25 ` Alex Bennée
2018-05-17 17:47 ` [PATCH v4 32/49] tests/tcg/arm: add fcvt test cases for AArch32/64 Alex Bennée
2018-05-17 20:30 ` Richard Henderson
2018-05-18 3:45 ` Philippe Mathieu-Daudé
2018-05-18 8:16 ` Alex Bennée
2018-05-18 14:53 ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [PATCH v4 49/49] tests/tcg: override runners for broken tests (!UPSTREAM) Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu2pdkwz.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=balrogg@gmail.com \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).