From: Samuel Tardieu <sam@rfc1149.net>
To: zhaoguohan@kylinos.cn
Cc: qemu-arm@nongnu.org
Subject: Re: [PATCH] hw/arm/stm32l4x5: fix stale peripheral comments
Date: Thu, 02 Apr 2026 10:14:14 +0200 [thread overview]
Message-ID: <87ika9dbjd.fsf@rfc1149.net> (raw)
In-Reply-To: <20260402080119.200785-1-zhaoguohan@kylinos.cn> (zhaoguohan@kylinos.cn's message of "Thu, 2 Apr 2026 16:01:19 +0800")
zhaoguohan@kylinos.cn writes:
> stm32l4x5_soc.c still has a couple of stale comments left behind by
> copy-and-paste updates.
>
> The EXTI wakeup table labels IRQ 53 as UART4 even though it is the
> UART5 wakeup line, and the reserved APB1 gap after IWDG is still
> annotated as 0x40001800 instead of 0x40003400.
>
> Update the comments to match the current STM32L4x5 layout. No
> functional change.
>
> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
> ---
> hw/arm/stm32l4x5_soc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Samuel Tardieu <sam@rfc1149.net>
prev parent reply other threads:[~2026-04-02 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 8:01 [PATCH] hw/arm/stm32l4x5: fix stale peripheral comments zhaoguohan
2026-04-02 8:14 ` Samuel Tardieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ika9dbjd.fsf@rfc1149.net \
--to=sam@rfc1149.net \
--cc=qemu-arm@nongnu.org \
--cc=zhaoguohan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox