[PATCH] hw/arm/stm32l4x5: fix stale peripheral comments

[PATCH] hw/arm/stm32l4x5: fix stale peripheral comments

[zhaoguohan]

From: GuoHan Zhao <zhaoguohan@kylinos.cn>

stm32l4x5_soc.c still has a couple of stale comments left behind by
copy-and-paste updates.

The EXTI wakeup table labels IRQ 53 as UART4 even though it is the
UART5 wakeup line, and the reserved APB1 gap after IWDG is still
annotated as 0x40001800 instead of 0x40003400.

Update the comments to match the current STM32L4x5 layout. No
functional change.

Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
---
 hw/arm/stm32l4x5_soc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/arm/stm32l4x5_soc.c b/hw/arm/stm32l4x5_soc.c
index 39b8cdf97dca..9c3cecf2c928 100644
--- a/hw/arm/stm32l4x5_soc.c
+++ b/hw/arm/stm32l4x5_soc.c
@@ -70,7 +70,7 @@ static const int exti_irq[NUM_EXTI_IRQ] = {
     38,                     /* USART2 wakeup, Direct   */
     39,                     /* USART3 wakeup, Direct   */
     52,                     /* UART4 wakeup, Direct    */
-    53,                     /* UART4 wakeup, Direct    */
+    53,                     /* UART5 wakeup, Direct    */
     70,                     /* LPUART1 wakeup, Direct  */
     65,                     /* LPTIM1, Direct          */
     66,                     /* LPTIM2, Direct          */
@@ -369,7 +369,7 @@ static void stm32l4x5_soc_realize(DeviceState *dev_soc, Error **errp)
     create_unimplemented_device("RTC",       0x40002800, 0x400);
     create_unimplemented_device("WWDG",      0x40002C00, 0x400);
     create_unimplemented_device("IWDG",      0x40003000, 0x400);
-    /* RESERVED:    0x40001800, 0x400 */
+    /* RESERVED:    0x40003400, 0x400 */
     create_unimplemented_device("SPI2",      0x40003800, 0x400);
     create_unimplemented_device("SPI3",      0x40003C00, 0x400);
     /* RESERVED:    0x40004000, 0x400 */
-- 
2.43.0

Re: [PATCH] hw/arm/stm32l4x5: fix stale peripheral comments

[Samuel Tardieu]

zhaoguohan@kylinos.cn writes:

> stm32l4x5_soc.c still has a couple of stale comments left behind by
> copy-and-paste updates.
>
> The EXTI wakeup table labels IRQ 53 as UART4 even though it is the
> UART5 wakeup line, and the reserved APB1 gap after IWDG is still
> annotated as 0x40001800 instead of 0x40003400.
>
> Update the comments to match the current STM32L4x5 layout. No
> functional change.
>
> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
> ---
>  hw/arm/stm32l4x5_soc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Samuel Tardieu <sam@rfc1149.net>