From: Cornelia Huck <cohuck@redhat.com>
To: eric.auger@redhat.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Sebastian Ott <sebott@redhat.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Alireza Sanaee <alireza.sanaee@huawei.com>
Subject: Re: [PATCH v2 3/3] arm/kvm: get demuxed ID registers from kvm
Date: Thu, 02 Apr 2026 17:19:06 +0200 [thread overview]
Message-ID: <87zf3lcrv9.fsf@redhat.com> (raw)
In-Reply-To: <ece352d8-d819-4562-b6d6-f761898a3bbf@redhat.com>
On Wed, Apr 01 2026, Eric Auger <eric.auger@redhat.com> wrote:
> On 2/4/26 2:32 PM, Cornelia Huck wrote:
>> We now have the infrastructure in place to get and save demuxed ID
> Here we only get their values? What about the save?
We only get, but we could also save, if we had the right interfaces :)
I'll try to reword it to be less confusing.
>> registers from kvm. Use it to get the values that kvm emulates for
>> CCSIDR_EL1.
>>
>> Tested-by: Alireza Sanaee <alireza.sanaee@huawei.com>
>> Reviewed-by: Sebastian Ott <sebott@redhat.com>
>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>> ---
>> target/arm/kvm.c | 33 +++++++++++++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>>
>> @@ -416,6 +444,11 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
>> */
>> err |= get_host_cpu_reg(fd, ahcf, ID_AA64ZFR0_EL1_IDX);
>> }
>> + /* grab demuxed registers */
>> + for (i = 0; i < 14; i++) {
>> + /* KVM only allows 0..13 */
> where is it documented? Maybe add a comment or justification in the
> commit msg. Use a define?
Linux arch/arm64/kvm/sys_regs.c has
#define CSSELR_MAX 14
Not sure if there is any actual documentation.
>> + err |= get_host_cpu_reg_demux(fd, ahcf, CCSIDR_EL1_IDX, i);
>> + }
>> }
>>
>> kvm_arm_destroy_scratch_host_vcpu(fdarray);
> Thanks
>
> Eric
next prev parent reply other threads:[~2026-04-02 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 13:32 [PATCH v2 0/3] arm: demuxed ID registers (CCSIDR_EL1) Cornelia Huck
2026-02-04 13:32 ` [PATCH v2 1/3] arm: handle demuxed ID registers Cornelia Huck
2026-02-04 13:32 ` [PATCH v2 2/3] arm: handle CCSIDR_EL1 as a demuxed register Cornelia Huck
2026-04-01 16:46 ` Eric Auger
2026-04-02 15:04 ` Cornelia Huck
2026-02-04 13:32 ` [PATCH v2 3/3] arm/kvm: get demuxed ID registers from kvm Cornelia Huck
2026-04-01 17:00 ` Eric Auger
2026-04-02 15:19 ` Cornelia Huck [this message]
2026-02-05 11:52 ` [PATCH v2 0/3] arm: demuxed ID registers (CCSIDR_EL1) Peter Maydell
2026-02-05 16:50 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf3lcrv9.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alireza.sanaee@huawei.com \
--cc=eric.auger@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sebott@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox