From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:907:9874:b0:a31:23a7:2a34 with SMTP id ko20csp778028ejc; Fri, 26 Jan 2024 02:11:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1D6WW8kMHNXgLkqgGoxsLlysTYn5KiMoCERUPTvee4nfiHz57jNszxzUy+z0JgaexHTZU X-Received: by 2002:a37:e104:0:b0:783:86d1:5b84 with SMTP id c4-20020a37e104000000b0078386d15b84mr1025325qkm.156.1706263869304; Fri, 26 Jan 2024 02:11:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706263869; cv=none; d=google.com; s=arc-20160816; b=PlkaTsDZlFQbf1IteNuWOioZcoX8AX2iqnOepm//xXEbcYULdgowkH6z8bicNENVHD QEGx6rnkL+tw1Si0PWYD+GW9O+PYLDih4/TsdQPeoG/p6AyXo6Aab64zjea23K3VE5DO zlNQtriR0LRtpTVq6W8CEPK9sd8DlMB3vawo2/I0jdiNoouDRyWzR/mXNqPDKb3Cha6s cFYK/2ZMI8zCk+E6CAvbdyQO8YfnmgFVT9ZANwDBJe4F/tjwPSF6cEsdsJqievweJfIP yvI0Hl7SmSJey1BU+ZF/wJUQcD7I+agddfCgrVmxRQufJGrEnDWUQD8oq3Y967PxjHMH f+2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=pN92veoyfDZMKM6w756kZt9YFnwSlVeNWPlRpGyT0lI=; fh=HTHR+Q2d6bLhEl37Oh4T8uXQP5/6sUv4T2u8Op+j0Ns=; b=vTteSKfuNdjwWg8Ft9WeNofZ5eDvMbSfCNZMfLxmbUvQtZgfrhmArs09jm4r7wq4AI r3jE2dKeMTVxSpy24wgokfyZsBqbDsc0gPMsto6+AwElgTg2osWrWK67BfnPoIqWgZoN K8suD0rGfty/zyIheilhTWXATGyznH1v4hNVPUGxXpVrAGT95RNXp+fcZhd525QYj/cM XlK9NyvbBsrnYQ45FrVqkIQY1MMJOccqntVDwZt/OMktpLPhUG+Hi7TpS4afKW+DL0hZ PDGdsZnygaR0+YJdF2ObGCdXZaa/LgjzZhWQWbRgewlTd3/+hw0H0V85WHNJYpFbNipo 6f+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=A1IkQEO+; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g19-20020a05620a40d300b00783222ee668si1027231qko.567.2024.01.26.02.11.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2024 02:11:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=A1IkQEO+; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTJAq-0004In-4T; Fri, 26 Jan 2024 05:11:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTJAj-0004IQ-QH; Fri, 26 Jan 2024 05:10:53 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTJAg-0005Em-Sk; Fri, 26 Jan 2024 05:10:52 -0500 Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40Q85rF7006758; Fri, 26 Jan 2024 10:10:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=pN92veoyfDZMKM6w756kZt9YFnwSlVeNWPlRpGyT0lI=; b=A1IkQEO+dh9K9J9tgmOj15Z/abHeQpBQdoOvoW80sOR4QBxWZmiPZOhUMlX6BWd/2bH2 YFUtBCXUNTMJ7wPJeahFjZyC2yAk6cXGFHMIOlWX11XSgJxq//meOzlltHzWnJxmco6B PlYdUSB3JG70tAoi9evahBKpIUgvfoA5AI2qMg3gR+gNL0WuxLuI3BNhyrq3CwOPmIO4 IXtEJ4lGSHm5D/+9cLJ2GQ4blXz0pb63eMuDJjyJSGjYUPuvir5xiAJNNmk16j2WCOkI S3gWkzzyFCo28MIvdtFitcORJPz9tJAWLS9x/+mFLJksUtbcH9SZNmNYLPLiQM+JyZHa wQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vv89supwu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 10:10:34 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40Q9kmaw001839; Fri, 26 Jan 2024 10:10:34 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vv89supwp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 10:10:34 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 40Q80jbj025663; Fri, 26 Jan 2024 10:10:33 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vrsgpj3wx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 10:10:33 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 40QAAWrL11010766 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Jan 2024 10:10:32 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 41F965805A; Fri, 26 Jan 2024 10:10:32 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82EC858054; Fri, 26 Jan 2024 10:10:31 +0000 (GMT) Received: from [9.61.160.70] (unknown [9.61.160.70]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 26 Jan 2024 10:10:31 +0000 (GMT) Message-ID: <887842c5-362c-4ab3-b75a-64c0c1eb24a2@linux.ibm.com> Date: Fri, 26 Jan 2024 04:10:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 06/11] hw/fsi: Introduce IBM's FSI master Content-Language: en-US To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, peter.maydell@linaro.org, andrew@codeconstruct.com.au, joel@jms.id.au, pbonzini@redhat.com, marcandre.lureau@redhat.com, berrange@redhat.com, thuth@redhat.com, philmd@linaro.org, lvivier@redhat.com Cc: qemu-arm@nongnu.org, Andrew Jeffery References: <20240126034026.31068-1-ninad@linux.ibm.com> <20240126034026.31068-7-ninad@linux.ibm.com> <8d457bb0-ee65-4dc2-ac9d-77d2c0747491@kaod.org> From: Ninad Palsule In-Reply-To: <8d457bb0-ee65-4dc2-ac9d-77d2c0747491@kaod.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Rs_PEkUiQva7yXFJXs0rciulLLaBdjfY X-Proofpoint-ORIG-GUID: aHUQApzae5deFNJQGvflAvBsMBl96k_T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_14,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 mlxlogscore=515 priorityscore=1501 phishscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401260073 Received-SPF: pass client-ip=148.163.158.5; envelope-from=ninad@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: thLQkNm1r3Q3 Hello Cedric, >> v9: >>    - Initialized registers. >>    - Fixed the address check. >> v11: >>    - Replaced for loop with memset. >>    - Removed Joel's review tag as per Cedric. > > > Reviewed-by: Cédric Le Goater Added tag. Thanks for the review. Regards, Ninad