Re: [PATCH] aspeed: Set 'auto_create_sdcard' to false

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

Hello,

On 30/9/25 16:24, Cédric Le Goater wrote:
> Don't create a default SD card device at init time.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Fixes: cdc8d7cadaac ("hw/boards: Rename no_sdcard -> auto_create_sdcard")

The "Fixes:" tag doesn't seem appropriate here, since that commit does
not have any logical change.

I suspect Aspeed boards have a pre-existing copy/paste issue, and should
not set the auto_create_sdcard bit, using the default @false value.
Which is what you ended doing :) See commit the following commit,
5824fad4e92 ("hw/boards: Do not create unusable default if=sd drives").

I'd be OK for a v2 with an update description, just removing the lines
in the patch (no need to explicit "auto_create_sdcard = false" since
this is the field we want to eventually remove).

Regards,

Phil.

> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/arm/aspeed.c | 44 ++++++++++++++++++++++----------------------
>   1 file changed, 22 insertions(+), 22 deletions(-)
> 
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index a3659ffea475..0d1f043ac214 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -1450,7 +1450,7 @@ static void aspeed_machine_palmetto_class_init(ObjectClass *oc,
>       amc->spi_model = "mx25l25635f";
>       amc->num_cs    = 1;
>       amc->i2c_init  = palmetto_bmc_i2c_init;
> -    mc->auto_create_sdcard = true;
> +    mc->auto_create_sdcard = false;
>       mc->default_ram_size       = 256 * MiB;
>       aspeed_machine_class_init_cpus_defaults(mc);