From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:593b:0:0:0:0:0 with SMTP id v27csp1299574lfi; Fri, 2 Jul 2021 05:22:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/a7QahFUTC8dfQFU0V68nKPKVR2BmXhvI5f/fQZ1JwoT5yXNGtg9j/mPL1RVL+UErdlez X-Received: by 2002:a17:906:c14d:: with SMTP id dp13mr5076347ejc.192.1625228549430; Fri, 02 Jul 2021 05:22:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625228549; cv=none; d=google.com; s=arc-20160816; b=M5eHvBwA6Fw4XnIv0hI6z9OHPwDBVaWBTh9UDiAFz1LwkG8yMmLQQ9H/unla2c+4Er 0s1jROdfLtNPJ2SgitxdiJ5yiLG4czkw0RzJsws3h9hxhFI4LPhUW45K+TnPx0rpVehL LgA9rnHr6ZCZtNjq/QsKX++DhHsDz/80sk3TUbKi1OuHMiQrzRw8YnvYGgZ31tI7DXoa UtqVVsF/pXF1v9VXeOODcKTiGbdbR6wUEG6283RcKy+fkHEjmP4DSCG54+zkap5DR7ed ObA7pMU/ThFBS/hbfwn+xjFsZ2IvaZTT2uFV0UukfRMobOxNkMRgN/fVtupMtN7S2BQU /Ugg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding:to :subject:message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=M/hF982I4L16elpL2pkfgT3y3SGCMPCc5MUfrQ+h2js=; b=zuLX2VsiRk15Guh0RZoHdTzpVwImsihOPX1Q/GISgU5JONWSxwLUorPwKCl4yXoGwM UBw0XSV4xVdn1br3RHHE++kaXVzAFUU6J/pV3nS4sWMM18b3PED9MZPOXLG54XDDEWdS c59WrVKH0lekhOlRpHGZqkpODVtNL+bNbEEv145qrTvpgbyBigI7MukZWRXVF5oihXc3 ypr8bPmbG1C9SG1FKJIVJ6/3m/WkeIpIxVkJDWsH8QLSqiSCTz7CkK6RPFHUcbq06M00 EjEEzX6lbaa3crxvBkx/LbWY4hGSBwSxkblkJ8eCx/uBQdwEWMizT7taTAfSNsfz9Gx3 bthA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qpYEyMDy; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v11si2884566edc.610.2021.07.02.05.22.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Jul 2021 05:22:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qpYEyMDy; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1]:60730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzIBg-0004zg-Ic for alex.bennee@linaro.org; Fri, 02 Jul 2021 08:22:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzIBH-0004x9-TH; Fri, 02 Jul 2021 08:22:04 -0400 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]:46817) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzIBD-0000xE-FL; Fri, 02 Jul 2021 08:22:03 -0400 Received: by mail-qk1-x742.google.com with SMTP id 19so9096259qky.13; Fri, 02 Jul 2021 05:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=M/hF982I4L16elpL2pkfgT3y3SGCMPCc5MUfrQ+h2js=; b=qpYEyMDycCPe82A6r5Oj8CzBkWRQp0XRPeZQOPPrGdTqjnZl2Gzhpo5qtxyJrPgODn rIOXMz7VG3cdJUTlI0p3L8iYpSqnXn7yV9xPxHdPOaBG6BcHOx8kg4l8/CHoalMrOB5G mt9OUvPMh2mW6lS3MRtI+2WET1/xw/L8SDsTifeF9RN/gjxhSgVrfvr3Z7fFEoHaO5NK BmxR9b/Bg2rbCsPdZAgM1rSTUeH8RSWnOjeqsfbShPX0nAwMk4Hql8/DRb9DzQaLCJ1R pXKf2cuJ7vgB1716tZ9Wz3KyBrODAeS9dBIkBxE46XATbHx62j08YUI5QnkyUxUXw9Z3 SlVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=M/hF982I4L16elpL2pkfgT3y3SGCMPCc5MUfrQ+h2js=; b=CDoVoNtrX6/RV7h3gCjUP11UHnTUamvcpfmmBM6nzepf6rnpnV19wEeV2xny1Hl7vy g6O8cVsXzPBsoXvmfLaNITGA9tclH8jxtb4WkS1iOzwlFsTdVAvZ49k8abVNEjwzdrTf n/9Cw3aejKDDuZW2XFUk92mwhmOe+xOqx+Tr7yBZN5l9/kEM7V3DOzCbcFrmRkgVsW+O Zy0yIf5MDIZiGq/wcWx7SOMrfSjRqaIF3mKckusE7+8cH8xfelFCQMBAVQM32FHjHKw8 QSimYL67X19B+1OMXW6U3jksu1qbdbT6rRuZgaQ1MDH/D9vMh6m7SkOWs8QzxT974HyZ k3EA== X-Gm-Message-State: AOAM533utD7dA+4lJi4j+ioeCUHjRNE7hmSGghXysxhMuqfKBZB5CWb8 LtDER2G5wW9TGv4HuhSVMKCDAjSLQXTqgUcJUyE= X-Received: by 2002:a05:620a:12f3:: with SMTP id f19mr5215813qkl.306.1625228514425; Fri, 02 Jul 2021 05:21:54 -0700 (PDT) MIME-Version: 1.0 References: <20210625091818.1047980-1-imammedo@redhat.com> <20210625091818.1047980-27-imammedo@redhat.com> In-Reply-To: <20210625091818.1047980-27-imammedo@redhat.com> From: Dongjiu Geng Date: Fri, 2 Jul 2021 20:21:43 +0800 Message-ID: Subject: Re: [PATCH 25/53] acpi: acpi_build_hest: use acpi_init_table()/acpi_table_composed() instead of build_header() To: Igor Mammedov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::742; envelope-from=gengdongjiu1@gmail.com; helo=mail-qk1-x742.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drjones@redhat.com, qemu-arm@nongnu.org, QEMU Developers , "Michael S. Tsirkin" Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 8kLaZnmBdiUy Igor Mammedov =E4=BA=8E2021=E5=B9=B46=E6=9C=8825=E6= =97=A5=E5=91=A8=E4=BA=94 =E4=B8=8B=E5=8D=885:19=E5=86=99=E9=81=93=EF=BC=9A > > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > Signed-off-by: Igor Mammedov > --- > CC: qemu-arm@nongnu.org > CC: drjones@redhat.com > CC: gengdongjiu1@gmail.com > --- > hw/acpi/ghes.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index a4dac6bf15..ae577c08e4 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -362,18 +362,16 @@ static void build_ghes_v2(GArray *table_data, int s= ource_id, BIOSLinker *linker) > void acpi_build_hest(GArray *table_data, BIOSLinker *linker, > const char *oem_id, const char *oem_table_id) > { > - uint64_t hest_start =3D table_data->len; > + AcpiTable table =3D { .sig =3D "HEST", .rev =3D 1, > + .oem_id =3D oem_id, .oem_table_id =3D oem_table_= id }; > > - /* Hardware Error Source Table header*/ > - acpi_data_push(table_data, sizeof(AcpiTableHeader)); > + acpi_init_table(&table, table_data); > > /* Error Source Count */ > build_append_int_noprefix(table_data, ACPI_GHES_ERROR_SOURCE_COUNT, = 4); > - > build_ghes_v2(table_data, ACPI_HEST_SRC_ID_SEA, linker); > > - build_header(linker, table_data, (void *)(table_data->data + hest_st= art), > - "HEST", table_data->len - hest_start, 1, oem_id, oem_ta= ble_id); > + acpi_table_composed(linker, &table); Thanks for the change, I think this change is reasonable to use common API acpi_init_table() to replace build_header() Reviewed-by: Dongjiu Geng > } > > void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s, > -- > 2.27.0 >