From: Peter Maydell <peter.maydell@linaro.org>
To: Diana Craciun <diana.craciun@nxp.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Eric Auger <eric.auger@redhat.com>,
Mihai Claudiu Caraman <mike.caraman@nxp.com>,
qemu-arm <qemu-arm@nongnu.org>,
bharat.bhushan@nxp.com,
Christoffer Dall <christoffer.dall@linaro.org>,
laurentiu.tudor@nxp.com
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 1/2] Increased the size of requester_id field from MemTxAttrs
Date: Tue, 4 Apr 2017 13:27:29 +0100 [thread overview]
Message-ID: <CAFEAcA8s9aR4rbJzd=9-oRashOGvUtSL4xxqbu2M1Cv2YFND7Q@mail.gmail.com> (raw)
In-Reply-To: <1490276212-32008-2-git-send-email-diana.craciun@nxp.com>
On 23 March 2017 at 13:36, Diana Craciun <diana.craciun@nxp.com> wrote:
> The PCI requester ID field is 16 bits. The requester_id field
> from MemTxAttrs is used for MSIs to specify the device ID for
> the platforms where this device ID is needed (e.g virt machine + GICv3
> ITS). However, if more entities that uses MSIs in the system are used,
> 16 bit is no longer enough to represent the device ID. Increased the size
> of this field to 24 bits in order to accomodate 256 entities.
> Also the name requester_id does no longer reflect the content, so
> the name was changed to stream_id.
This name change would be reverting the name change in
commit a05f686ff3, which says:
MemTxAttrs.stream_id also renamed to requester_id in order to better
reflect semantics of the field.
I don't have a strong opinion about the name myself, but flipping
backwards and forwards doesn't seem like a great plan :-)
thanks
-- PMM
next prev parent reply other threads:[~2017-04-04 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 13:36 [Qemu-devel] [PATCH RFC 0/2] Add global device ID in virt machine Diana Craciun
2017-03-23 13:36 ` [Qemu-devel] [PATCH RFC 1/2] Increased the size of requester_id field from MemTxAttrs Diana Craciun
2017-04-04 12:27 ` Peter Maydell [this message]
2017-05-23 10:45 ` Diana Madalina Craciun
2017-03-23 13:36 ` [Qemu-devel] [PATCH RFC 2/2] Add a unique ID in the virt machine to be used as device ID Diana Craciun
2017-03-23 15:18 ` [Qemu-devel] [PATCH RFC 0/2] Add global device ID in virt machine no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8s9aR4rbJzd=9-oRashOGvUtSL4xxqbu2M1Cv2YFND7Q@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=bharat.bhushan@nxp.com \
--cc=christoffer.dall@linaro.org \
--cc=diana.craciun@nxp.com \
--cc=eric.auger@redhat.com \
--cc=laurentiu.tudor@nxp.com \
--cc=mike.caraman@nxp.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).