From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Phil Dennis-Jordan <phil@philjordan.eu>,
qemu-arm@nongnu.org, Alexander Graf <agraf@csgraf.de>
Subject: Re: [PATCH v2] hw/gpio/pl061: Declare pullups/pulldowns as 8-bit types
Date: Mon, 27 Oct 2025 11:14:15 +0000 [thread overview]
Message-ID: <CAFEAcA9D+zHH_+UQDPc-GqSH-b8NC9VvoXXJwhOxT8Mtry08Mg@mail.gmail.com> (raw)
In-Reply-To: <20251021145313.4584-1-philmd@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On Tue, 21 Oct 2025 at 15:53, Philippe Mathieu-Daudé <philmd@linaro.org>
wrote:
>
> uint8_t is good enough to hold a property "between 0 and 0xff".
>
> Define pullups/pulldowns properties using DEFINE_PROP_UINT8()
> macro, remove unnecessary range checks in pl061_realize().
> Update the two caller sites.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> v2: qdev_prop_set_uint32 -> qdev_prop_set_uint8 in callers (Peter)
Applied to target-arm.next, thanks.
-- PMM
[-- Attachment #2: Type: text/html, Size: 750 bytes --]
prev parent reply other threads:[~2025-10-27 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 14:53 [PATCH v2] hw/gpio/pl061: Declare pullups/pulldowns as 8-bit types Philippe Mathieu-Daudé
2025-10-23 14:18 ` Peter Maydell
2025-10-27 11:14 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9D+zHH_+UQDPc-GqSH-b8NC9VvoXXJwhOxT8Mtry08Mg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=agraf@csgraf.de \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).