From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Cc: "patches@linaro.org" <patches@linaro.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-arm] [PATCH] fix fp16 tininess
Date: Thu, 10 May 2018 15:11:37 +0100 [thread overview]
Message-ID: <CAFEAcA9xoFxqkCKzXTXHZ4D+chhaJP9=RFmyfx2HnJfFhvJWpg@mail.gmail.com> (raw)
In-Reply-To: <20180510140934.22855-1-peter.maydell@linaro.org>
On 10 May 2018 at 15:09, Peter Maydell <peter.maydell@linaro.org> wrote:
> In commit d81ce0ef2c4f105 we added an extra float_status field
> fp_status_fp16 for Arm, but forgot to initialize it correctly
> by setting it to float_tininess_before_rounding. This currently
> will only cause problems for the new V8_FP16 feature, since the
> float-to-float conversion code doesn't use it yet. The effect
> would be that we failed to set the Underflow IEEE exception flag
> in all the cases where we should.
Oops, I forgot to fix the patch summary line from my
quick-hack commit. Something like:
target/arm: Fix tininess detection for fp16 arithmetic
would be a bit clearer.
thanks
-- PMM
next prev parent reply other threads:[~2018-05-10 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 14:09 [PATCH] fix fp16 tininess Peter Maydell
2018-05-10 14:11 ` Peter Maydell [this message]
2018-05-10 14:34 ` Richard Henderson
2018-05-10 15:07 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9xoFxqkCKzXTXHZ4D+chhaJP9=RFmyfx2HnJfFhvJWpg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).