From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:e8d:0:0:0:0:0 with SMTP id 135csp3705145lfo; Mon, 1 Feb 2021 11:56:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJy76R9Odw7hEcY40sTIcY0JOMrS2dyMSMiPTKXk6zvZWXUk+qmORi+foL28gD3PNz+tZ4Hu X-Received: by 2002:a25:d9c1:: with SMTP id q184mr11742933ybg.115.1612209404347; Mon, 01 Feb 2021 11:56:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612209404; cv=none; d=google.com; s=arc-20160816; b=ppvum539nDI4q6T7RNj4qqz+InUavKgD4rnnri4lM+Z4RSifWZ5mlSrMCUXgx9AjXC mXz3Cz4gDvcIORTtI3+LfdE5Nl5FqpvNTTgjpw0RF5zlgQCUdnajhIrZOiYXhPoUgCVm d1pK/OKa+45eJNykZGcCPTeMRTnak3tYHBtqanvpZAtQnCBAqEuAMm5ANZfPBy/skU+X DcGB740axLOeWWN7qusVBzE41Vi1IFMqBYv4qvZFjZuAvyzIXg946GhDtjkytbLfLDkW 28xzztpUrsvtcZSIjOC5g/ubkIlQ3xgN/W1Rg75YrUvHIqjkgytZcShAYfQErSGE65WN 6u/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding:to :subject:message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=OP2EWmjCbiDpjWViceOA9fmZyxGs7V0VIVK1IMMwVh8=; b=JA8jCD5fgCOv02mZs2Br3cRczc1Ua2eaqE+5dOT0EhR1aYSRCpDP7YthjKX3LoCyZY gE6Ha1z2+n10YwMjnu7epcgfXz7JB7KW1j4DX4QiJybAFm4SjqhKd/NEGVbyClwAWG1/ XMMBj/2GGFr5MdFwLBJY4aEK5MJIdTkeKKXbRTZnZZ/AhdZwPaEhZNFXjYGOyu7yHHE+ B0bnc044mak9/O9GvF/IyEr+v6BOW3EVZ6lmdtQKtIGUjGOalCCdFyeBC5Qqampals+l vnFhpLBT77KnA19iN8oxA/u/0WmWXBYw2M0EfhnRWn36XPGDvYIg12JQRLUS1+Y20pxY nWFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Umbl2I+s; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e128si17825885ybe.422.2021.02.01.11.56.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Feb 2021 11:56:44 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Umbl2I+s; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1]:46662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6fJT-0007n8-OE for alex.bennee@linaro.org; Mon, 01 Feb 2021 14:56:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6fJ3-0007lZ-E4; Mon, 01 Feb 2021 14:56:17 -0500 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]:35802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6fJ1-0005FE-4e; Mon, 01 Feb 2021 14:56:17 -0500 Received: by mail-io1-xd2e.google.com with SMTP id y19so18759666iov.2; Mon, 01 Feb 2021 11:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OP2EWmjCbiDpjWViceOA9fmZyxGs7V0VIVK1IMMwVh8=; b=Umbl2I+s1X8Nvo7Ss6IBVgTzI3MBCSVs/IUeVU0dpptSNlnHz7E1MHnIiMJU39kjau /ZOePKVGckuyRigSWhGzd5ZniRsOOXIGa+olSg3mzvvqqtqefvve6S97DxA46G8VnTFn 4mQySrRTF4SnX534MVAYcDXsCmxKuz0iG542uIlyV2Wpaj4RbNDwEbzosj4hGO7nlGoQ CNcD/4EHZuOz3JtvYifDg5DNRw7INMN2MC+Sw60I4jxsAh0DppanAYKbipQfRCTi5nO7 u+eOToMpyl/HBhR8zS80pkOvSFbs2ZaHdzuznsf8Bzc/6gvYu0JDZiP8TAWQP8h/6FYT NGIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OP2EWmjCbiDpjWViceOA9fmZyxGs7V0VIVK1IMMwVh8=; b=H7UzoOAlPkwH3DPY0qK5/JeGvKZqWWapApfdA9YOJwzLKmdFgnOulqehO5XdnX4OR0 McQpffc2ViRDLmHdfIb54W5cQDf8KoPONdoyFVBpDuakd2D2eGlcwgEfsmPASiU+ZMFQ 4kHd93TxLqD6LHUtU7BvyYXvR+0RntCr9O9oBscGwzTWRP3AEn5YVLrSu/WWIYpfnRlq TBy8FXfei5kmKHwjc+ChoGH0iOXKNZY8pG7XMuuMcd84J7aOKiJuJi5cnDAZlAgMycYo yopGXoT3o6UMVilYp5mSQo4QyLOI7oeLhRv9yUybHV2PVZJ9C7FLTPcI1+jpXuwdtN0B D8dw== X-Gm-Message-State: AOAM533zY58ENyeQ1bMenPbIbrxOv7gvCPrCo6JVZVriAxh6Czex7Fl7 gwtYw6Sle8K7E+LLVm4V5Q6NjC5+6HY/RhmDUG8= X-Received: by 2002:a6b:7d42:: with SMTP id d2mr14198447ioq.176.1612209372988; Mon, 01 Feb 2021 11:56:12 -0800 (PST) MIME-Version: 1.0 References: <20210131184449.382425-1-f4bug@amsat.org> <20210131184449.382425-6-f4bug@amsat.org> In-Reply-To: <20210131184449.382425-6-f4bug@amsat.org> From: Alistair Francis Date: Mon, 1 Feb 2021 11:55:45 -0800 Message-ID: Subject: Re: [PATCH v3 5/6] hw/net/can: ZynqMP CAN device requires PTIMER To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::d2e; envelope-from=alistair23@gmail.com; helo=mail-io1-xd2e.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , QEMU Trivial , Alistair Francis , Michael Tokarev , "qemu-devel@nongnu.org Developers" , Laurent Vivier , Niek Linnenbank , qemu-arm , Antony Pavlov , Joel Stanley Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: fOcqVeOniQMT On Sun, Jan 31, 2021 at 10:49 AM Philippe Mathieu-Daud=C3=A9 wrote: > > Add a dependency XLNX_ZYNQMP -> PTIMER to fix: > > /usr/bin/ld: > libcommon.fa.p/hw_net_can_xlnx-zynqmp-can.c.o: in function `xlnx_zynqmp= _can_realize': > hw/net/can/xlnx-zynqmp-can.c:1082: undefined reference to `ptimer_init' > hw/net/can/xlnx-zynqmp-can.c:1085: undefined reference to `ptimer_trans= action_begin' > hw/net/can/xlnx-zynqmp-can.c:1087: undefined reference to `ptimer_set_f= req' > hw/net/can/xlnx-zynqmp-can.c:1088: undefined reference to `ptimer_set_l= imit' > hw/net/can/xlnx-zynqmp-can.c:1089: undefined reference to `ptimer_run' > hw/net/can/xlnx-zynqmp-can.c:1090: undefined reference to `ptimer_trans= action_commit' > libcommon.fa.p/hw_net_can_xlnx-zynqmp-can.c.o:(.data.rel+0x2c8): undefi= ned reference to `vmstate_ptimer' > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/Kconfig b/hw/Kconfig > index 5ad3c6b5a4b..d4cec9e476c 100644 > --- a/hw/Kconfig > +++ b/hw/Kconfig > @@ -81,3 +81,4 @@ config XLNX_ZYNQMP > bool > select REGISTER > select CAN_BUS > + select PTIMER > -- > 2.26.2 > >